Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4441718pxj; Tue, 25 May 2021 08:06:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw37qgw6Lgqo0sZdd1YpXzlyHyJ9q04k5iMmHpA7aEQ8rhfs+6nNNVslqCyOppM0Q1uQb+O X-Received: by 2002:a92:cf45:: with SMTP id c5mr23401159ilr.182.1621955200764; Tue, 25 May 2021 08:06:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621955200; cv=none; d=google.com; s=arc-20160816; b=JPGAacEKVclPWbJrNvf7Z1U2KtVJ0i60EPWZJh6/jYSnID4vvAzS4ivFO1UpR9NBbD cCtq6lckgyLwJ/ly064u1xN7PgWdKzNZyUlLhwbodMfNhOJ5TMwkD1Kd8IdWDAK2Beyr CkatPwsoKW17ZpQNKeIz8orc3t4V4oMcbE12yS0zH2Wazd+Q25LZTZ14xLzsH/9nYmj7 p0CA3TepJkzy8pwcqBEU0LhjGjiaIYBVCBoR1x2iNYiVN7LawRTnd+42vfjx4SXYnDOB NfkRSrBrRtlarpOnsrJNVWdcTScLsnYhH9NiSbgLWaZuJ4uPZxxCfoV3BKVSAedlvw4h EIKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=496u+nzrIOmZIWAM6ZESwntUviVWJhQmr0zUtnxLfVs=; b=opRdtaxfmsm57m+l6qrfAFtD5oh4STm54/dndOT4cM5RQaI9yRU2Khx3P85tmmcD39 5IDwY6pYQo4ghCz7meyZ0Hln+9ElW60kI9weYU4wbAykd6eN+iYhNPk2wDde7U94uctq To3jEBlOSu0KUiZHbmPDyZqs3zT1fG0uQ2I7MWHznZReqcEDaGlG5Ku6iLvIuuoj1urr sIK3zH/Y36j/GKxVM61bcIZLypdY5vIN5aYNGgz7WmcIjmuh7AhvhXZutWAj762gqv/6 L0dkHe1aQDx9mdbnUEUMAvIOxF3HF/UzC1LklSFvQnPePZOtWVnK46fXPlR6A/wYcND0 l4xA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p8si16413383ils.114.2021.05.25.08.06.26; Tue, 25 May 2021 08:06:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232271AbhEYKgI (ORCPT + 99 others); Tue, 25 May 2021 06:36:08 -0400 Received: from mailout1.secunet.com ([62.96.220.44]:45992 "EHLO mailout1.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232394AbhEYKdr (ORCPT ); Tue, 25 May 2021 06:33:47 -0400 X-Greylist: delayed 498 seconds by postgrey-1.27 at vger.kernel.org; Tue, 25 May 2021 06:33:47 EDT Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout1.secunet.com (Postfix) with ESMTP id B894C800056; Tue, 25 May 2021 12:23:56 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 25 May 2021 12:23:56 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 25 May 2021 12:23:56 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 0C0AB3180299; Tue, 25 May 2021 12:23:56 +0200 (CEST) Date: Tue, 25 May 2021 12:23:55 +0200 From: Steffen Klassert To: Yang Li CC: , , , , , , Subject: Re: [PATCH] esp: drop unneeded assignment in esp4_gro_receive() Message-ID: <20210525102355.GW40979@gauss3.secunet.de> References: <1619345672-31802-1-git-send-email-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1619345672-31802-1-git-send-email-yang.lee@linux.alibaba.com> X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 25, 2021 at 06:14:32PM +0800, Yang Li wrote: > Making '!=' operation with 0 directly after calling > the function xfrm_parse_spi() is more efficient, > assignment to err is redundant. > > Eliminate the following clang_analyzer warning: > net/ipv4/esp4_offload.c:41:7: warning: Although the value stored to > 'err' is used in the enclosing expression, the value is never actually > read from 'err' > > No functional change, only more efficient. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Now applied to ipsec-next, thanks!