Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210524181707.132844-1-brgerst@gmail.com> <20210524181707.132844-3-brgerst@gmail.com>
In-Reply-To: <20210524181707.132844-3-brgerst@gmail.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 25 May 2021 21:01:31 +0900
Message-ID: <CAK7LNATV7J9afWf46QGA2QqGScFVGhLc-ey9+DqN31qUF=zcCw@mail.gmail.com>
Subject: Re: [PATCH 2/3] x86/syscalls: Remove -Wno-override-init for syscall tables
To:     Brian Gerst <brgerst@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        X86 ML <x86@kernel.org>, Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 25, 2021 at 3:17 AM Brian Gerst <brgerst@gmail.com> wrote:
>
> Commit 44fe4895f47c ("Stop filling syscall arrays with *_sys_ni_syscall")
> removes the need for -Wno-override-init, since the table is now filled
> sequentially instead of overriding a default value.
>
> Signed-off-by: Brian Gerst <brgerst@gmail.com>
> ---


Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>


>  arch/x86/entry/Makefile | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile
> index 08bf95dbc911..94d2843ce80c 100644
> --- a/arch/x86/entry/Makefile
> +++ b/arch/x86/entry/Makefile
> @@ -17,10 +17,6 @@ CFLAGS_syscall_64.o          += -fno-stack-protector
>  CFLAGS_syscall_32.o            += -fno-stack-protector
>  CFLAGS_syscall_x32.o           += -fno-stack-protector
>
> -CFLAGS_syscall_64.o            += $(call cc-option,-Wno-override-init,)
> -CFLAGS_syscall_32.o            += $(call cc-option,-Wno-override-init,)
> -CFLAGS_syscall_x32.o           += $(call cc-option,-Wno-override-init,)
> -
>  obj-y                          := entry_$(BITS).o thunk_$(BITS).o syscall_$(BITS).o
>  obj-y                          += common.o
>
> --
> 2.31.1
>


--
Best Regards
Masahiro Yamada