Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4470028pxj;
        Tue, 25 May 2021 08:41:49 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzSLEEsnNxoYI8rqW0nmNTwvZ0IU3B521PybIHjUieBY6UzM9a2M382Mw9uF5RP/+myeg+k
X-Received: by 2002:aa7:dc0b:: with SMTP id b11mr32758174edu.124.1621957308935;
        Tue, 25 May 2021 08:41:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1621957308; cv=none;
        d=google.com; s=arc-20160816;
        b=VyqXb989GJ8H9gCiusMkENtoH+nHftL7bIuQFIkGE7nQihFsZKsjyUo5qWJ0F6hbfJ
         M+hL0MCPRxlf/MUo95APhzY6HUWddCm148o3Eb0VfwMuYO6k0P6eXQrijV4lurD0rjf2
         BRuEx3xXgr30db6CIZpYcjEBW7e348SLCDLC72/0yOUmwNNbssbq34AX86bBjMYt8zB3
         O05/VsFjtQB1vaxN58uO1wkNOJPGl9GcaZKsR33qOyWoY0x/QQ+HpZsP38G6W3VW05cu
         W6SCyrK5+LJBmgb0Se5fBDYY8GBSml2u9lVNhIqcye/nDKCGBeiA8lszBb7NbzfMf5Bw
         BG3g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:message-id:cc:to:subject:from:date;
        bh=89me157F52S395JYPTjWgGRdkzNicVUh0zItuw33PYs=;
        b=Wi2/Z5K7QNwxawKqooPjozkn7XHATcVHSEUWR4SHafB+SrnqirYBht1nqctTM1pslQ
         Dtq+FGezUp20qxVr/soFdWO7IoiM/KGrsSBH6jT5h9QcyR2TBUJCmd3bF0M/svikj8Tk
         LDD0dWtAe+kZOJ305vOO2HnmQBmjpgHLrbDWGHcUjwVWbEqdTgYGH4FbCHc6ltI+wjJp
         LJKzRSQdOktsYEC8GDqsP8RX3bjJNod+LFkZbgZWMIUZocnYHiQWJkW53num3U1uf7VE
         oMS02cvczSHlY0LhhA4mIyQ+GaxO34baZ7ZpjKBpwfyPiGJtqk0Q5hIe1dfkr7hSJTUd
         y8Cw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a10si585325edq.515.2021.05.25.08.41.25;
        Tue, 25 May 2021 08:41:48 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231846AbhEYLrb (ORCPT <rfc822;luizmacielfranco@gmail.com>
        + 99 others); Tue, 25 May 2021 07:47:31 -0400
Received: from mta-10-1.privateemail.com ([68.65.122.30]:21635 "EHLO
        MTA-10-1.privateemail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231770AbhEYLra (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 May 2021 07:47:30 -0400
Received: from MTA-10.privateemail.com (localhost [127.0.0.1])
        by MTA-10.privateemail.com (Postfix) with ESMTP id 93B506011B;
        Tue, 25 May 2021 07:46:00 -0400 (EDT)
Received: from [192.168.0.46] (unknown [10.20.151.222])
        by MTA-10.privateemail.com (Postfix) with ESMTPA id D12066011A;
        Tue, 25 May 2021 07:45:59 -0400 (EDT)
Date:   Tue, 25 May 2021 07:45:53 -0400
From:   Hamza Mahfooz <someguy@effective-light.com>
Subject: Question regarding the TODO in virt/kvm/kvm_main.c:226
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Message-Id: <HCVNTQ.0UPDP6HCEHBP3@effective-light.com>
X-Mailer: geary/40.0
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
X-Virus-Scanned: ClamAV using ClamSMTP
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Would it be preferable to remove kvm_arch_vcpu_should_kick or
kvm_request_needs_ipi when merging them. I ask since, the last time I
checked, both functions are only used in kvm_main.c on Linus's tree.