Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4482710pxj; Tue, 25 May 2021 08:59:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyU+bSEJnM23e0GM8g2OXhHWEMe9OsXQkN7pC8pMI/cuokSrjHUJKQ9dILkyXLRyH09shBZ X-Received: by 2002:a05:6402:1d3c:: with SMTP id dh28mr32919757edb.129.1621958394382; Tue, 25 May 2021 08:59:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621958394; cv=none; d=google.com; s=arc-20160816; b=fT0qOdS0Ai7/+TckJGnFx49BwWEkVRT2BoO8Qse/qhOCQfZxm8ztyFE/RPvLUM0Ofm Rj1V/wDOd5ZXGmtcGFSDS7xU/Wo0a7JH7y2dBeSXlE00Mste84GrGS3dBQOn4CpWp8QH TjQXRH9AN527k1UcpEAeZ1qYBUjnO+RLLJfDEqCVvIMgQzIA8trB0Q8KEczGWVyKW16Q LdFgoH9/yOfGTW6eHLdGwRdN7CpQQSGYirQXSQjon7BKsqmHi80a9cg/B8ps4tuTuygz jvTO3yCh+7GTskokGlbs7PkHpVKsMfil8/225AIiuocWQ+OCDAHf+1ulw9F3m4cJ7HDl +31A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Y28saWW4RbQx7WFyioP30Xg1gnMSgGnjvex8TrgoAmQ=; b=Q9QE2lOsFjNGor44ztFBuv7O9ht+EuV3DJJg5vEaRkxWFvjHUKDCHerkyPy74vNwW1 8aSMx+tB6cfIyB5XaOsQYMVNRVGKpSM2rBNW5GZN9T/ADo5AcvGrM+X03AVjhHuC9Sf+ qmfGc0QFb4y36ev41JTryr3aX3Xkyrj+VdtD9lBXo/x0pfX6XavyGreUay1qAtf/vZ1g a9ayB9GEX6nKGT0a/OYruIOXKhUL1XpDJWA6nvj2DEs/sEUqK3FIcd+NbRIrwarN63xt NRYrlHGwQy9hQ54Ff+s0uFO/9cz9sl9qizZMza5r6hsZ+Mpt5JJdN5sORt+bi3BEr9zn BMiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=SmfdiXxk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si19620774ejx.698.2021.05.25.08.59.31; Tue, 25 May 2021 08:59:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=SmfdiXxk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232977AbhEYNCG (ORCPT + 99 others); Tue, 25 May 2021 09:02:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232922AbhEYNCD (ORCPT ); Tue, 25 May 2021 09:02:03 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 008BDC061756 for ; Tue, 25 May 2021 06:00:33 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id o27so30225043qkj.9 for ; Tue, 25 May 2021 06:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Y28saWW4RbQx7WFyioP30Xg1gnMSgGnjvex8TrgoAmQ=; b=SmfdiXxkr36Ea/32dUzc9goah/P/GDAmfDbfC23QxapWU+TYijU+tfipqVELo7UnNb kCjW74Q30JDB5fgFGsHqgJCEmxBDKG9IApVbKABuX/KOwPBR0S9vlJjymq+MrMGk51h3 6ydpK/iuWp9N2XdHcbwhGAfcdpizobjsabPIpm0tzrNvmu9Bxekatij9qaP2uru6JWkm 9Q/bdYcBQsR1yN1XYUK+IHclcbpDWwfEhDxrstMqMj+GfnNWOoDjxxvTrZpSn3pYUBV+ tBirFOf/cNxOyaXXED4cDuzfXDrAdEmlM6leYVvOPcAJrsNxmqDTUvm5putYq5K3bzNj AP8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y28saWW4RbQx7WFyioP30Xg1gnMSgGnjvex8TrgoAmQ=; b=chzkRr9liQmQ1HwWIepcu5KAbsBhavTL93SpCpBm6mFPFJJZAfTYubLM6TNgRTOGwT ILJ8/RCxv2Np8IupCVPvS3LIADdotwEdZw2K08edyR+sEmY5Zx+2CjPHBz2OtmIgP953 0nWUWYd5EK3zvvWm/IE9G5ww8me1AoD6ewTxQv2r3F2Ve5QJk6Z90cZoZEK6jtPoKmPH 01nEr0wkhjScTa4+5m2zXmcfLFuUtx6/hhDUfEDwjkmwbQnsksfUT24JWq06gjTwUgvm AvkpF409lXxx/+apoDUl9JZgR0nA+A1n1ERtEbnJiz7lzz8l1Btd44FXnik2jZDS206f MCAg== X-Gm-Message-State: AOAM533CmkBohkOMBA+NU1jGaWBtbY2P1EtqmyZvOJ4AbdHkbhJa1HG2 QxLejHr7xlJG22p5NtPJmDf9Ew== X-Received: by 2002:a37:9a44:: with SMTP id c65mr23489338qke.152.1621947632397; Tue, 25 May 2021 06:00:32 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:4f4e]) by smtp.gmail.com with ESMTPSA id o5sm4565264qkl.25.2021.05.25.06.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 06:00:31 -0700 (PDT) Date: Tue, 25 May 2021 09:00:30 -0400 From: Johannes Weiner To: Suren Baghdasaryan Cc: tj@kernel.org, lizefan.x@bytedance.com, mingo@redhat.com, peterz@infradead.org, shakeelb@google.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, minchan@kernel.org, corbet@lwn.net, bristot@redhat.com, paulmck@kernel.org, rdunlap@infradead.org, akpm@linux-foundation.org, tglx@linutronix.de, macro@orcam.me.uk, viresh.kumar@linaro.org, mike.kravetz@oracle.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 1/1] cgroup: make per-cgroup pressure stall tracking configurable Message-ID: References: <20210524195339.1233449-1-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210524195339.1233449-1-surenb@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 24, 2021 at 12:53:39PM -0700, Suren Baghdasaryan wrote: > PSI accounts stalls for each cgroup separately and aggregates it at each > level of the hierarchy. This causes additional overhead with psi_avgs_work > being called for each cgroup in the hierarchy. psi_avgs_work has been > highly optimized, however on systems with large number of cgroups the > overhead becomes noticeable. > Systems which use PSI only at the system level could avoid this overhead > if PSI can be configured to skip per-cgroup stall accounting. > Add "cgroup_disable=pressure" kernel command-line option to allow > requesting system-wide only pressure stall accounting. When set, it > keeps system-wide accounting under /proc/pressure/ but skips accounting > for individual cgroups and does not expose PSI nodes in cgroup hierarchy. > > Signed-off-by: Suren Baghdasaryan Acked-by: Johannes Weiner