Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 May 2021 23:15:54 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Navin Sankar Velliangiri <navin@linumiz.com>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linus.walleij@linaro.org, bgolaszewski@baylibre.com
Subject: Re: [PATCH] gpio: 104-idio-16: Fix coding style issues
Message-ID: <YK0Gmqf4IrR9qX6a@shinobu>
References: <20210525045717.20652-1-navin@linumiz.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="LKIMFHI51zCGpcMP"
Content-Disposition: inline
In-Reply-To: <20210525045717.20652-1-navin@linumiz.com>
Precedence: bulk


--LKIMFHI51zCGpcMP
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 25, 2021 at 10:27:17AM +0530, Navin Sankar Velliangiri wrote:
> Fixed multiple bare uses of 'unsigned' without int.
> Reported by checkpatch.
>=20
> Signed-off-by: Navin Sankar Velliangiri <navin@linumiz.com>

Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>

> ---
>  drivers/gpio/gpio-104-idio-16.c | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)
>=20
> diff --git a/drivers/gpio/gpio-104-idio-16.c b/drivers/gpio/gpio-104-idio=
-16.c
> index 50ad0280fd78..55b40299ebfa 100644
> --- a/drivers/gpio/gpio-104-idio-16.c
> +++ b/drivers/gpio/gpio-104-idio-16.c
> @@ -44,11 +44,12 @@ struct idio_16_gpio {
>  	struct gpio_chip chip;
>  	raw_spinlock_t lock;
>  	unsigned long irq_mask;
> -	unsigned base;
> -	unsigned out_state;
> +	unsigned int base;
> +	unsigned int out_state;
>  };
> =20
> -static int idio_16_gpio_get_direction(struct gpio_chip *chip, unsigned o=
ffset)
> +static int idio_16_gpio_get_direction(struct gpio_chip *chip,
> +				      unsigned int offset)
>  {
>  	if (offset > 15)
>  		return GPIO_LINE_DIRECTION_IN;
> @@ -56,22 +57,23 @@ static int idio_16_gpio_get_direction(struct gpio_chi=
p *chip, unsigned offset)
>  	return GPIO_LINE_DIRECTION_OUT;
>  }
> =20
> -static int idio_16_gpio_direction_input(struct gpio_chip *chip, unsigned=
 offset)
> +static int idio_16_gpio_direction_input(struct gpio_chip *chip,
> +					unsigned int offset)
>  {
>  	return 0;
>  }
> =20
>  static int idio_16_gpio_direction_output(struct gpio_chip *chip,
> -	unsigned offset, int value)
> +	unsigned int offset, int value)
>  {
>  	chip->set(chip, offset, value);
>  	return 0;
>  }
> =20
> -static int idio_16_gpio_get(struct gpio_chip *chip, unsigned offset)
> +static int idio_16_gpio_get(struct gpio_chip *chip, unsigned int offset)
>  {
>  	struct idio_16_gpio *const idio16gpio =3D gpiochip_get_data(chip);
> -	const unsigned mask =3D BIT(offset-16);
> +	const unsigned int mask =3D BIT(offset-16);
> =20
>  	if (offset < 16)
>  		return -EINVAL;
> @@ -96,10 +98,11 @@ static int idio_16_gpio_get_multiple(struct gpio_chip=
 *chip,
>  	return 0;
>  }
> =20
> -static void idio_16_gpio_set(struct gpio_chip *chip, unsigned offset, in=
t value)
> +static void idio_16_gpio_set(struct gpio_chip *chip, unsigned int offset,
> +			     int value)
>  {
>  	struct idio_16_gpio *const idio16gpio =3D gpiochip_get_data(chip);
> -	const unsigned mask =3D BIT(offset);
> +	const unsigned int mask =3D BIT(offset);
>  	unsigned long flags;
> =20
>  	if (offset > 15)
> @@ -180,7 +183,7 @@ static void idio_16_irq_unmask(struct irq_data *data)
>  	}
>  }
> =20
> -static int idio_16_irq_set_type(struct irq_data *data, unsigned flow_typ=
e)
> +static int idio_16_irq_set_type(struct irq_data *data, unsigned int flow=
_type)
>  {
>  	/* The only valid irq types are none and both-edges */
>  	if (flow_type !=3D IRQ_TYPE_NONE &&
> --=20
> 2.31.1
>=20

--LKIMFHI51zCGpcMP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmCtBoIACgkQhvpINdm7
VJKCEg//fusSfdxeeRrqUHz5kd30lBWIq6bo5khxw2hmi7Ng+fNK/NfogbrqY+ws
LSgsFROi/EAvqgefw8NaA8r2Hg5x4L/J5E+L8zAcdZH9iToz1f20iiAoROgIBkVK
opTcujViXRpaKVMdmEpT9BqvR1XIB/6SthXKTwdio5N5hfpE/oOL+SREecDxiXWu
IDtKmGHzte0sChZYYFGDTIDs+CpNgOrmuMvnygP5gdUnFr14ykXTlmMV6J6Ka6b3
oRP8P06K8y74dMUPT7gNzVfNV9I97/IfjUyu4W4BNJae1+sDpFTEziRfUm+GB/cR
dsQgU88aSPv+gkSWx+xip/L+NiSRcmosbPxp80XfTNUva13n3sTAk7n+QYUUC8Gq
SPaTyUlAPE0VTSEiFSxct3/loFecoHX2iDAafg/XgDS2slRv4PpVEQfvTajmYYwU
bnZX/91sY5ZgAmymiMO62pHJFbAQ7Q3wnzvgQkYOrz+aqzVpf70ule4NSrnpC4R9
ujfVJXPa9iTj6mCNNc8r3AVLlYYBP32y9CqQyabXN4XKEvdX8wsYXvloVUO0Ubtc
ObUZMqNtru5zx1MaXKjYgMxUwNQ2TNZdugzceXG9ltZiJfcYoeMAYQW7f48Ca+f+
ed3O9+7bVcACW+E2TTUfe6mtkel3BOg6I9aaz0y3dD7fDZ+XKPc=
=IdTt
-----END PGP SIGNATURE-----

--LKIMFHI51zCGpcMP--