Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4578625pxj; Tue, 25 May 2021 11:07:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8kwf8IFEu0/RElpTvQF272TiMtCFsU3gZw/GSZQdUor6xCPUHoZ7Vjnmh62kNd41nR4lG X-Received: by 2002:a05:6e02:1d9a:: with SMTP id h26mr13165840ila.224.1621966060642; Tue, 25 May 2021 11:07:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621966060; cv=none; d=google.com; s=arc-20160816; b=HxC/fFLTuYQegMgUJEkYvY5vbCWWcjWw6UiaVcl9JqLUllKbuBrOIDYUTpgnjff7l5 8YE1ovs73sf+8I1afYMeSZpxjaacj+8hDWw2QJGymxsfPfJx30FsOuJm1foB3I+WqzzC r6AVVcozh/OQo6mDVnNO+qrKvlBBN4M4AgL4j/SMtWWGny6wjlZ7h6m6Vtsb+HVlWEmr 9K4gsveEHLNjvBETRlu2VsKP8FMV7nCAkOhrOhcSS4q7gVAm/4fURus0/HUZR0larVy2 ys3I051Bs6Hu7gqY4WrUDbLCvnhTlEOzh1gOT2742BAB58JCKT/FxkSxVsmvmAmwh5ul 7z2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=981ntmvmAfYh2am9y2T40Yf7wN+YymgvH6+BnPSvWys=; b=SFS6Svmel9Eb25C6M4h8XFy4UvaB59DqtMmhOhQ5UlYo29nI9MXsYHuXvUalvh8ZH+ ZSJMieI1I3dAftP9N5GdHGz4xwAkBy9ey1dm/RQ4QshLBqNu2iAZC+t+s3yrvZHvDC8b jrCdScghJDf19pa/nUBvpMW2zDAfQaSMJkCP4q4RIopd6aTHTyC5wU1T1K5VsnRhyMsq qbvycd5C8O4VB//nATKrvsdkQBv3cZb+UeAvdNgzmtfknZRRascI9s+phyJ5gvlYaZYJ gByn6I7Vhndt/ia2YhLg86R2Ai1yLDBMeQ1mBTk6pTe14jcQ2hiH1RpnO6cWwz9ncsQX 5POw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si17735482iln.71.2021.05.25.11.07.12; Tue, 25 May 2021 11:07:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233862AbhEYR0Q (ORCPT + 99 others); Tue, 25 May 2021 13:26:16 -0400 Received: from mga03.intel.com ([134.134.136.65]:9404 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233843AbhEYR0Q (ORCPT ); Tue, 25 May 2021 13:26:16 -0400 IronPort-SDR: ORtokHP8GR+g4SaXWfdeAE+JDGJVwxfY5z5f0gcX0cugm8brw5jFZ1wabDmgBEBbJBiz4wiEVN fVzYdac7PPXw== X-IronPort-AV: E=McAfee;i="6200,9189,9995"; a="202288219" X-IronPort-AV: E=Sophos;i="5.82,328,1613462400"; d="scan'208";a="202288219" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 10:24:33 -0700 IronPort-SDR: iSJB6XtPrtPA88Et5nfaFUasQXO07mqz6NAlMsTbI4655hsWgUQEF6JYKXVXNX+nNviIytsXNY l00jeGp5eGPQ== X-IronPort-AV: E=Sophos;i="5.82,328,1613462400"; d="scan'208";a="633105450" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 10:24:32 -0700 From: ira.weiny@intel.com To: Dan Williams Cc: Ira Weiny , Vishal Verma , linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 3/3] dax: Ensure errno is returned from dax_direct_access Date: Tue, 25 May 2021 10:24:28 -0700 Message-Id: <20210525172428.3634316-4-ira.weiny@intel.com> X-Mailer: git-send-email 2.28.0.rc0.12.gb6a658bd00c9 In-Reply-To: <20210525172428.3634316-1-ira.weiny@intel.com> References: <20210525172428.3634316-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ira Weiny If the caller specifies a negative nr_pages that is an invalid parameter. Return -EINVAL to ensure callers get an errno if they want to check it. Reviewed-by: Dan Williams Signed-off-by: Ira Weiny --- drivers/dax/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dax/super.c b/drivers/dax/super.c index 5fa6ae9dbc8b..44736cbd446e 100644 --- a/drivers/dax/super.c +++ b/drivers/dax/super.c @@ -313,7 +313,7 @@ long dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff, long nr_pages, return -ENXIO; if (nr_pages < 0) - return nr_pages; + return -EINVAL; avail = dax_dev->ops->direct_access(dax_dev, pgoff, nr_pages, kaddr, pfn); -- 2.28.0.rc0.12.gb6a658bd00c9