Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 May 2021 10:21:57 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Muchun Song <songmuchun@bytedance.com>
CC:     <hannes@cmpxchg.org>, <mhocko@kernel.org>,
        <akpm@linux-foundation.org>, <shakeelb@google.com>,
        <vdavydov.dev@gmail.com>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, <duanxiongchun@bytedance.com>,
        <fam.zheng@bytedance.com>, <bsingharora@gmail.com>,
        <shy828301@gmail.com>, <alex.shi@linux.alibaba.com>
Subject: Re: [RFC PATCH v3 03/12] mm: memcontrol: make lruvec lock safe when
 the LRU pages reparented
Message-ID: <YK0yNQGu3jTCFTD8@carbon.dhcp.thefacebook.com>
References: <20210421070059.69361-1-songmuchun@bytedance.com>
 <20210421070059.69361-4-songmuchun@bytedance.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20210421070059.69361-4-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:5cc2) by MWHPR12CA0034.namprd12.prod.outlook.com (2603:10b6:301:2::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.24 via Frontend Transport; Tue, 25 May 2021 17:22:00 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 71984d87-0445-47c7-3880-08d91fa19bf0
X-MS-TrafficTypeDiagnostic: BYAPR15MB3288:
X-Microsoft-Antispam-PRVS: <BYAPR15MB32884A2A1CA86EB1D6730B5CBE259@BYAPR15MB3288.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: LQ4/SAcRKDnNRJzYIKnCm8TsLc4+Zcd6KRgCIqXag0HRxALF/yZuU6ymK51gmATI7fx55wRi3gMV8pRSn4WDwB1uzA5BtNJz6lpjI1wcmgfOUvg7uQ14xYesDtFkA4B5NsvdSwKaSWblObyZowXB2l8x+kFsGx4rWUMDuH672QH+cCoqt/3H2ttOKH6c13bEcjKyeulTHFrlG2vDJNutDj5FCpMgCPed/Glm/Emy1hBzFnej+3tIXRde408fUDveayhDrJqv9Lfa6LP12zdi5BncVkhe3f2Tb4BXk+GQA3FSqXY9yUji0Hej4ram/rmLftJ3sBPBQFIudfqvtScfd5qQxE37XIRTGFe2PLMJ/n9Z+F5f3qJ8Kku8mOvzBHBNrlv8ffsDN0mTLsb0sFqnspM+kffung4Y7H9gIct0Fnol188EPlwIrSvcophEi3ZjvO48LaLUU3+mjP8WkXtA+b8nIkbbkyPcqf7UsCUtvxTYBXZTik3e38lKguFTGZJeHqAAsq1TMEpMSRzor+oIYwa1bxtp+qpY4Uka50pCmdXeK7zeadLX2b0wK4L0EpcW0uC+w6FV7wwA+L/nfV+iJWm6xAMBFtQww8QEICadm1A=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(376002)(396003)(346002)(366004)(9686003)(8676002)(6506007)(66556008)(66476007)(16526019)(7696005)(478600001)(66946007)(83380400001)(55016002)(52116002)(7416002)(8936002)(5660300002)(186003)(4326008)(86362001)(6916009)(6666004)(316002)(2906002)(38100700002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?FRGjtuHlgpNl+ViXEriekyCEj6iW/t7TTmp8qDZD2HCyttFHkhec63nV6JKR?=
 =?us-ascii?Q?xEWrKPv74ZDAA+CUMTY9DsHvTZVIDnUbB3Ty1Jt+9o573rFAStWjMY1tOapw?=
 =?us-ascii?Q?Ev6gGDYenX55LUeZgC3a9+serf6aKDF3i2h8cpmu29uJ7zcPKPUb7guca3yu?=
 =?us-ascii?Q?H4DzsaPd0hIqXt7f7vDtUb6sXF6KGXDLgROruZJvFmIYeeZwcGS5zHWnFsFX?=
 =?us-ascii?Q?vwo27chWPeXsMcz30WfwOlOa6eBan50H9sjiafTFpnOPmOQGP8wcihca2jBd?=
 =?us-ascii?Q?AvdKMnhwYMlod7CwBeuT/hSQ0KtiMxiPTQGDZ9FXSSy+wxHncF9ykND+rsOX?=
 =?us-ascii?Q?D2U5l6MRx530Ij3TEJm5uevDYYI0o2VGi2a6eYPY9nVDXAelUoVUJjhurkt1?=
 =?us-ascii?Q?P8+L8jwOSSVOMEqDzgIK+OK9chabkpenAVSkurEOfTd3PA9k8UUtd8KLYOuS?=
 =?us-ascii?Q?aZVKwG0Lmb34cf/WCTd/XkGLHLf1N+0oACPVXjBEUKcsO742Fd4s9wed3ln6?=
 =?us-ascii?Q?OmMyQFYlY4349jYAg35mc7XhccwlTN6AgMmYKIFKlg910WFfS+6IEnAKgDra?=
 =?us-ascii?Q?gD0ynlimKenbUVX6lAnvHd+xpfJYhKf+7T2X+OMgwEEmhG2n9aJCseHmcAHG?=
 =?us-ascii?Q?c/YrnDdHZeWaZRT6Sl00qxjOSvTqinKZ/NkH9SSB4llfGx0IHro4Fxx8sdop?=
 =?us-ascii?Q?1YvjplxJJp3kjqG/rY6DP9cpOcfK7gO2jGi2fVfvbUlCqwn8Y6l/efcgqGUz?=
 =?us-ascii?Q?ZVkh76nHsYl/yv6oqGAGBOQyKVXwh5xWAvu3OcKzNUPpGgyhEwNnc7i7dyLt?=
 =?us-ascii?Q?yFoVT3Bvig2VKd014YZwy0BqaVBaGn5E7PCpU1z/uleMrLyHi1efLBwidyI8?=
 =?us-ascii?Q?d5x3R5pKe51UjliJYjSG/7bo2nJnaMAJjEpBu0BJGVGdmC6vXKYY+u4VsGT0?=
 =?us-ascii?Q?b/8iM3CPw8mxrNR2g+eekQGiwCT8LAkSihIeU7bHaFU6nbiYyiy+FtWDR6Cq?=
 =?us-ascii?Q?AsPKtfsyh7CHX0AVhceYM/j6NAnfiMIfWbZZ8wazLBlcdC5T+3w4jawHUVe8?=
 =?us-ascii?Q?MzhlaUkLLVFi0IS9ue/XUi424DZCQx2cmCk901JsEMQXAq4zrxSDsiDbqzkE?=
 =?us-ascii?Q?gq/y7DcOcr4hb5W+2pGNgRC/owRFWpTiFVnJ4YMA3AxbxAp13loTSZAiUo/P?=
 =?us-ascii?Q?4yxhrs6Y0ywlhzZyB7BrW3GZLQxJYJeoTibfa01Xk1kMP/z6SMEI+256ulDB?=
 =?us-ascii?Q?bliJy5P/g9ZZ/VEb5E0EE9gPuFvCCzWeng0jLP0QDNzetJe9R6Hr0hxALBna?=
 =?us-ascii?Q?XnNL0TbG2tWCvjw7hOqcGiMk79Yaes/oRdBouLEmEb+MTQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 71984d87-0445-47c7-3880-08d91fa19bf0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2021 17:22:01.7522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: un90LGFufARSTjnivoBlNwAPaopNMCJE9EE28BD9AWnWeRZbL0ARITgtDgSAK5+o
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3288
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: PmdJrOm44Yapo6Mb7Eh08dn7144oadjc
X-Proofpoint-GUID: PmdJrOm44Yapo6Mb7Eh08dn7144oadjc
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761
 definitions=2021-05-25_08:2021-05-25,2021-05-25 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 lowpriorityscore=0
 phishscore=0 malwarescore=0 mlxlogscore=841 spamscore=0 bulkscore=0
 impostorscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 adultscore=0
 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2105250106
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 21, 2021 at 03:00:50PM +0800, Muchun Song wrote:
> The diagram below shows how to make the page lruvec lock safe when the
> LRU pages reparented.
> 
> lock_page_lruvec(page)
>     retry:
>         lruvec = mem_cgroup_page_lruvec(page);
> 
>         // The page is reparented at this time.
>         spin_lock(&lruvec->lru_lock);
> 
>         if (unlikely(lruvec_memcg(lruvec) != page_memcg(page)))
>             // Acquired the wrong lruvec lock and need to retry.
>             // Because this page is on the parent memcg lruvec list.
>             goto retry;
> 
>         // If we reach here, it means that page_memcg(page) is stable.
> 
> memcg_reparent_objcgs(memcg)
>     // lruvec belongs to memcg and lruvec_parent belongs to parent memcg.
>     spin_lock(&lruvec->lru_lock);
>     spin_lock(&lruvec_parent->lru_lock);
> 
>     // Move all the pages from the lruvec list to the parent lruvec list.
> 
>     spin_unlock(&lruvec_parent->lru_lock);
>     spin_unlock(&lruvec->lru_lock);
> 
> After we acquire the lruvec lock, we need to check whether the page is
> reparented. If so, we need to reacquire the new lruvec lock. On the
> routine of the LRU pages reparenting, we will also acquire the lruvec
> lock (Will be implemented in the later patch). So page_memcg() cannot
> be changed when we hold the lruvec lock.
> 
> Since lruvec_memcg(lruvec) is always equal to page_memcg(page) after
> we hold the lruvec lock, lruvec_memcg_debug() check is pointless. So
> remove it.
> 
> This is a preparation for reparenting the LRU pages.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>

Acked-by: Roman Gushchin <guro@fb.com>

Thanks!