Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4578835pxj; Tue, 25 May 2021 11:07:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUu4MyKCWFIiR/tvK52SUuxHItoUQZGePzTFrEZESWbab7BMJObk34+J+7y4VRKojkRMIw X-Received: by 2002:a6b:7948:: with SMTP id j8mr6797723iop.32.1621966074749; Tue, 25 May 2021 11:07:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621966074; cv=none; d=google.com; s=arc-20160816; b=DT/xSfAwgzU8glOrWcbVhwdJRon/cBT28HbxLISQZ6WYCY/g1ZMPFH74Pf0Jwkt0lY E4Hivoug0CJHZZGnBOFnXX0exY2yb8wyJ+qzbENSIAGI/7rQ26Si4bh3UCYdzYfQSx6L 1NqKEXdnhjeF2KinadLTpjM07rU5qsmy6OVIPsJLm1dePtYPl90aGVjRh0K0BcL+wYL3 GFCz7H70EHF9/NrpA0q9O3LBuXrKn2fwpioUVjzkbEW+upV9TDhlkh5SUGG+SCneRb8r K10Ttk0qXr5/sOFMRmKBofhVkfmFN/COzN/FQxVwn5zrcrgNkKOSfJV0EILj9doMQADF HmSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=+3SAVuavTR/wZkguDBB8AEuJ++f2xmeQOgdroW/FBYI=; b=MHdCqKtwQ+OCiN8M5Xw4CDwa567RPUM3qExu8J4Vw5jZGx2UpsEcniDqXReI6WkZFq D9j2pekLduH4OI2n4vtcDzs1p52W2018sD13AQNWXoaDqIIyspPoS0AaUSXlUqElbsg3 5/XBstRCI/rwWHsUQcIpPiGiUmM3QuwIPUOznIic8QqthdzPnl9YYSxNATqhlGn3AUbg rNuhIyHPMQmzFNCpVmfCS6SEYzIvyAWfWveJ0L3MjOAve8WgN5OXmtPxe1kbZw2yK2zO 7u3ANMSCYrc9EBv/8R/o2+WR2hUfk+YYvvhTaNCkTNbGXfchjyzz04og1R8ef8hB88Kq 7oUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si17232398iln.143.2021.05.25.11.07.41; Tue, 25 May 2021 11:07:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233889AbhEYR0T (ORCPT + 99 others); Tue, 25 May 2021 13:26:19 -0400 Received: from mga03.intel.com ([134.134.136.65]:9404 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233852AbhEYR0Q (ORCPT ); Tue, 25 May 2021 13:26:16 -0400 IronPort-SDR: T4J9M3K8ez9XlBmhz8UYK0JfdQw1kV8H4R5TI5DiSWm4YLZ130kxwzgpobp6DjHsVxX7JB39Ye Kug+r8syaVRw== X-IronPort-AV: E=McAfee;i="6200,9189,9995"; a="202288198" X-IronPort-AV: E=Sophos;i="5.82,328,1613462400"; d="scan'208";a="202288198" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 10:24:32 -0700 IronPort-SDR: iTg7kWfPtWs9sWulBMt5sNbz3FIReiZmGS+ArfHxfJGzKJ5yq+zmb6tNwOwraCEALNJrKnbBck x13LZednWADA== X-IronPort-AV: E=Sophos;i="5.82,328,1613462400"; d="scan'208";a="633105443" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 10:24:32 -0700 From: ira.weiny@intel.com To: Dan Williams Cc: Ira Weiny , Vishal Verma , linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 2/3] fs/dax: Clarify nr_pages to dax_direct_access() Date: Tue, 25 May 2021 10:24:27 -0700 Message-Id: <20210525172428.3634316-3-ira.weiny@intel.com> X-Mailer: git-send-email 2.28.0.rc0.12.gb6a658bd00c9 In-Reply-To: <20210525172428.3634316-1-ira.weiny@intel.com> References: <20210525172428.3634316-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ira Weiny dax_direct_access() takes a number of pages. PHYS_PFN(PAGE_SIZE) is a very round about way to specify '1'. Change the nr_pages parameter to the explicit value of '1'. Reviewed-by: Dan Williams Signed-off-by: Ira Weiny --- fs/dax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dax.c b/fs/dax.c index b3d27fdc6775..07621322aeee 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -710,7 +710,7 @@ static int copy_cow_page_dax(struct block_device *bdev, struct dax_device *dax_d return rc; id = dax_read_lock(); - rc = dax_direct_access(dax_dev, pgoff, PHYS_PFN(PAGE_SIZE), &kaddr, NULL); + rc = dax_direct_access(dax_dev, pgoff, 1, &kaddr, NULL); if (rc < 0) { dax_read_unlock(id); return rc; -- 2.28.0.rc0.12.gb6a658bd00c9