Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4585068pxj; Tue, 25 May 2021 11:16:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAo/HxsLWwAnQ7lKZu5BM92v+xfPMvTYSNn0hCqMnFvSzWksiS9qPKKnxlgg2J4bjjIRGC X-Received: by 2002:a05:6602:3427:: with SMTP id n39mr23184115ioz.157.1621966568786; Tue, 25 May 2021 11:16:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621966568; cv=none; d=google.com; s=arc-20160816; b=sPk7Yu1x+QuCdMWyvBfI9FwmfJNhjLTUaZHEQRxy3+MuZ9ZUhQFkINMj87hmUumvkR FL1WZDVzAd3mMY7VA/gOIO4bAy85dDNsZbmE1Bfrh7oRJ63v23YlsZN/9kzf+FitCqBU 4Axrwxr1pDNrpv71Wa/QBqn84FO0kydIZJKFMQWXm7vcoQBMQPn6YCcvHyvIJWV8DuJc MPzb+4OaIi4lJzGlukdycIfERMQ9X9yb5irCLtr3gwSWKkCalacxQmc9226zr/VwlY74 8PDYEFs6tooQ25cBHPXEFVVlc19FuE7cY5E7ctqknX6MLZWvaUm5EiQjhtgQer0ILMux pfJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=spDwl7Z/5U9Bf7Bfr4yNjI4brbwqdSqnDF+e/2FaLNo=; b=erlD8THrxvSLH9uxmoPhJIrP/B/Kq8kW6WrSaP22DSXdtmAX+VjtymDW624XJewrXn w0pUnClNmTPab/Txcuzx1gS24QSIeqTBx7BfXGju1GOwKgGlsVph576FkwzdEG0VeSIj NndWocg6ZFQU6vv34S2JYgyg6llEDjgn4a8qqKvQ4bQFR1UHThJ6lz7PqvuPRgwjsE93 QGnupggJrVpP+xKkn9dNgAR/eWAlvac9HIZzEcxqorSsoUhRYvTcPwvnjltg04DbUTBp yxGqLCUZoFmBeA+/in9FhrANJW4v0m57HPnr9/LzIZBkMoltFwfCXZ2mDts1Q8DXlQlD XZsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p4si7718790ilc.63.2021.05.25.11.15.54; Tue, 25 May 2021 11:16:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234083AbhEYRfa (ORCPT + 99 others); Tue, 25 May 2021 13:35:30 -0400 Received: from mga07.intel.com ([134.134.136.100]:21084 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234112AbhEYRfI (ORCPT ); Tue, 25 May 2021 13:35:08 -0400 IronPort-SDR: SDFIVORGZ20lEY9DZsvi/QS4M8tXOLEX1aiySjxk5u5QYm9JEuXhsqfSR7xbWkVL/JUibzIhc3 NKcuIKZClBxA== X-IronPort-AV: E=McAfee;i="6200,9189,9995"; a="266146624" X-IronPort-AV: E=Sophos;i="5.82,328,1613462400"; d="scan'208";a="266146624" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 10:33:28 -0700 IronPort-SDR: uYyiphpiITEdDe1WLHNkWMzMf0/MMsb7IWtaflrFYLJtS3I456pExVpM8bqInQ2FPnDvVE5dbu 0leTx13CQstg== X-IronPort-AV: E=Sophos;i="5.82,328,1613462400"; d="scan'208";a="476518595" Received: from krlloyd-mobl3.amr.corp.intel.com (HELO [10.255.229.251]) ([10.255.229.251]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 10:33:27 -0700 Subject: Re: [PATCH v5 15/28] x86/arch_prctl: Create ARCH_GET_XSTATE/ARCH_PUT_XSTATE To: Borislav Petkov , Len Brown Cc: "Chang S. Bae" , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , X86 ML , "Brown, Len" , "Liu, Jing2" , "Ravi V. Shankar" , Linux Kernel Mailing List References: <20210523193259.26200-1-chang.seok.bae@intel.com> <20210523193259.26200-16-chang.seok.bae@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <33fff4fc-e4e3-dc1b-251e-90561a55b382@intel.com> Date: Tue, 25 May 2021 10:33:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/25/21 10:27 AM, Borislav Petkov wrote: > On Mon, May 24, 2021 at 07:10:57PM -0400, Len Brown wrote: >> 1. CPUID has AMX >> 2. XCR0 has AMX >> 3. Linux permission has been requested and granted to this process > Actually, you want *only* 3 as 1 is a bad idea - we're in this mess > because userspace does feature detection on its own even when kernel > support is needed. > > When Linux grants the permission, 1 and 2 should be implicitly given. We did this for pkeys. Essentially, we said, "don't bother with CPUID.OSPKE and XCRO[PKRU] checking". Just call alloc_pkey() and we'll do the checking for you. One stop shopping. So far, it's worked well.