Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
In-Reply-To: <20210525105049.34804-1-cuibixuan@huawei.com>
References: <20210525105049.34804-1-cuibixuan@huawei.com>
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.9.1
Date:   Tue, 25 May 2021 14:21:55 -0400
Message-ID: <CAE-0n53ugXGsdJfa_B6kfcmMzvQPDXMjz=NWf6_kVwSSW+5gaQ@mail.gmail.com>
Subject: Re: [PATCH -next v2] module: fix build error when CONFIG_SYSFS is disabled
To:     Bixuan Cui <cuibixuan@huawei.com>, jeyu@kernel.org
Cc:     sfr@canb.auug.org.au, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Quoting Bixuan Cui (2021-05-25 03:50:49)
> Fix build error when disable CONFIG_SYSFS:
> kernel/module.c:2805:8: error: implicit declaration of function =EF=BF=BD=
=EF=BF=BD=EF=BF=BDsect_empty=EF=BF=BD=EF=BF=BD=EF=BF=BD; did you mean =EF=
=BF=BD=EF=BF=BD=EF=BF=BDdesc_empty=EF=BF=BD=EF=BF=BD=EF=BF=BD? [-Werror=3Di=
mplicit-function-declaration]
>  2805 |   if (!sect_empty(sechdr) && sechdr->sh_type =3D=3D SHT_NOTE &&
>
> Fixes: 9ee6682aa528 ("module: add printk formats to add module build ID t=
o stacktraces")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>

Ok. The SoB chain is wrong but you may have my SoB.

> ---
> Changes from v2:
> Put the sect_empty() definition outside of #ifdef CONFIG_SYSFS.
>
>  kernel/module.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index decf4601e943..0543b44db81d 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -1462,6 +1462,13 @@ resolve_symbol_wait(struct module *mod,
>         return ksym;
>  }
>
> +#ifdef CONFIG_KALLSYMS
> +static inline bool sect_empty(const Elf_Shdr *sect)
> +{
> +       return !(sect->sh_flags & SHF_ALLOC) || sect->sh_size =3D=3D 0;
> +}
> +#endif
> +
>  /*
>   * /sys/module/foo/sections stuff
>   * J. Corbet <corbet@lwn.net>
> @@ -1469,11 +1476,6 @@ resolve_symbol_wait(struct module *mod,
>  #ifdef CONFIG_SYSFS
>
>  #ifdef CONFIG_KALLSYMS
> -static inline bool sect_empty(const Elf_Shdr *sect)
> -{
> -       return !(sect->sh_flags & SHF_ALLOC) || sect->sh_size =3D=3D 0;
> -}
> -
>  struct module_sect_attr {
>         struct bin_attribute battr;
>         unsigned long address;
> --
> 2.17.1
>