Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     <sj38.park@gmail.com>
CC:     <Jonathan.Cameron@Huawei.com>, <acme@kernel.org>,
        <akpm@linux-foundation.org>, <alexander.shishkin@linux.intel.com>,
        <amit@kernel.org>, <benh@kernel.crashing.org>,
        <brendanhiggins@google.com>, <corbet@lwn.net>, <david@redhat.com>,
        <dwmw@amazon.com>, <elver@google.com>, <fan.du@intel.com>,
        <foersleo@amazon.de>, <greg@kroah.com>, <gthelen@google.com>,
        <guoju.fgj@alibaba-inc.com>, <linux-damon@amazon.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, <mgorman@suse.de>, <minchan@kernel.org>,
        <mingo@redhat.com>, <namhyung@kernel.org>, <peterz@infradead.org>,
        <riel@surriel.com>, <rientjes@google.com>, <rostedt@goodmis.org>,
        <rppt@kernel.org>, <shakeelb@google.com>, <shuah@kernel.org>,
        <sjpark@amazon.de>, <snu@amazon.de>, <vbabka@suse.cz>,
        <vdavydov.dev@gmail.com>, <zgf574564920@gmail.com>
References: <20210520075629.4332-6-sj38.park@gmail.com>
Subject: Re: [PATCH v29 05/13] mm/damon: Implement primitives for the virtual
 memory address spaces
From:   <sieberf@amazon.com>
Message-ID: <3da2bb79-4448-4857-a9d1-698a360c51a2@amazon.com>
Date:   Tue, 25 May 2021 17:19:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210520075629.4332-6-sj38.park@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hi SeongJae,

Some questions for this patch:

Why do we split the regions in 3 areas (heap, stack, mmaped)? I 
understand we don't want to model the whole virtual address space, but 
why don't we just use whatever is modeled by the VMAs to define the 
regions boundaries?

I am not quite understanding why we both set the page idle and young (in 
damon_ptep_mkold). For WSS computation on our end we have used 
pte_clear_young_notify. Why do we touch the page idle flag at all? What 
flags do the reclaim logic use to track access?

Kind regards,

Fernand