Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4748290pxj; Tue, 25 May 2021 15:43:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmeX0yfoeDJfdArQdKy7Yi47k4TARQZq284rlhAeRWcrlwyAz2Z424xBIIwPQetxvASZHo X-Received: by 2002:a92:ccd1:: with SMTP id u17mr5333976ilq.239.1621982638354; Tue, 25 May 2021 15:43:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621982638; cv=none; d=google.com; s=arc-20160816; b=rD9Hkzldb1VzC2u/+CD6obDewR2HifcjX5tpx0cs/qhEQdVbsIPtw/NP/NTNzI+qDN +NrHeiws8gonCv0aax9J3eXUj2IvgepWszDjb9PIY5tUJyWZaFfZMtduP1A/uGQ4Dc/L mkVOSYUH80f6Hx7rx8BkTAfHR2z4nqbdvAc+QUvDM6kGOyXLXnmBRCLp8sMAVSdOvmK6 VS3NsImnBW5ZzRR1YDLDKKamIO1n1vC5h5Rz3kWwtv5pJjWeHlyVbgA0I7svfwohUQqQ OQ27/fKODN/9NGjsCKDiLyjuKQqU0jaYQqAEJCdzx+/ay4s7i5Ku3//KSUdFVv/Tb6Vl TfVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=oIw6Lm/oEW4kxw3eJiq093+7BPtybJnf2iAVAUKE+sM=; b=ZBr4SijXZpkGZCbrKmSSG/MF3sK0Jc+o3iutviSIcFswu15qOskuDr/pPJyDSJl7Kl xx0NmRD993kIDxf3dFvzMQBCPvuiRcP9kSwbxB30tpS+caWxwJJFyFI2LtYSq/+9Qj+M ULA+dbdZQjsEe0A78mNtaHs+X4grk3aZ/HnwBkAegqvH3gYXY694KjH1vVZR6/YSSQjk 2VQtkr+ca75QIl8VJLTyn3XshwuBkuRVeaRwFLccXIbwjkz4Hmw4Cngi0OGntUWMxSgC +eZJ2zWB+ruNyoQmwo5HDh7XT4EHQNtG95ZA49BQqeTPU4yh40TK7dU39DXZ7s/X1ydK g+xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Ij/vaAeJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t128si21905557iof.16.2021.05.25.15.43.44; Tue, 25 May 2021 15:43:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Ij/vaAeJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233361AbhEYVhy (ORCPT + 99 others); Tue, 25 May 2021 17:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233009AbhEYVhy (ORCPT ); Tue, 25 May 2021 17:37:54 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 130EBC06175F for ; Tue, 25 May 2021 14:36:24 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id t24so16166716oiw.3 for ; Tue, 25 May 2021 14:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=oIw6Lm/oEW4kxw3eJiq093+7BPtybJnf2iAVAUKE+sM=; b=Ij/vaAeJmniEAxFBeZvrK6vWuXnus+DNYdZ6aQCicMy1Jc4wKLWqEETu3fAE5O2vw/ eoIb4O29CH6fH9sFGvo68N2816adL01iY3DWGtZS7QbP4VAjSFHoYVrPM87BBbaQkD2D QYxpGmbFTR8AXLvuWqCNkx6HFH4qdyQ1Pc2v8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=oIw6Lm/oEW4kxw3eJiq093+7BPtybJnf2iAVAUKE+sM=; b=N+xWpuAPYaqulMhWCGPVpAo4Mgafs5+Gh5XO8gXzbK2mwgCXCImj3fCWaiLVwNlX2t 3Tn0pUPwBy5iNQ4umsGIyIDvLF8CwF8OeX/GI0wJr825KDCnnz8sSKQpiieO8Rl5z+El whlVYWCfzJq7u/fDmvdOp4/pEOfwE4+C7kce6sESpWruAMLdKgwzA/0Q9pxrn5fIHjqu Kg5ro+YEDc8lWooeF8ilbq5hqjJTfTUadCv3rerAiQJTBX9Y6qNE8ySXLHK35Mei2KXc M51UFMy9mbxMhFOD0fi5VeqiV+z28qygWPP6VtlZH6FCXakb+yAPcg6VmIltO0PXHay/ twNA== X-Gm-Message-State: AOAM5332G13HOsUDXf3tQoOCGHMRT/GFMYNXLyV2VpUnNGSqn2sKrKuW 7yz+PEB4t5m7R1rCX/IbToDcfOMrsVClwGt04enNsA== X-Received: by 2002:a54:4501:: with SMTP id l1mr15689617oil.19.1621978583504; Tue, 25 May 2021 14:36:23 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 25 May 2021 17:36:23 -0400 MIME-Version: 1.0 In-Reply-To: <20210525131051.31250-3-rojay@codeaurora.org> References: <20210525131051.31250-1-rojay@codeaurora.org> <20210525131051.31250-3-rojay@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 25 May 2021 17:36:23 -0400 Message-ID: Subject: Re: [PATCH V11 2/2] i2c: i2c-qcom-geni: Suspend and resume the bus during SYSTEM_SLEEP_PM ops To: Roja Rani Yarubandi , wsa@kernel.org Cc: dianders@chromium.org, saiprakash.ranjan@codeaurora.org, gregkh@linuxfoundation.org, mka@chromium.org, skananth@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org, rnayak@codeaurora.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Roja Rani Yarubandi (2021-05-25 06:10:51) > Mark bus as suspended during system suspend to block the future > transfers. Implement geni_i2c_resume_noirq() to resume the bus. May also be worth noting that this causes some warnings on trogdor boards because suspend ordering is incorrect and the bus is being accessed after it is suspended. Unless that is all resolved? > > Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller") > Signed-off-by: Roja Rani Yarubandi > --- Reviewed-by: Stephen Boyd