Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 May 2021 15:23:22 -0700 (PDT)
Message-Id: <20210525.152322.1873282589367907213.davem@davemloft.net>
To:     gatis@mikrotik.com
Cc:     chris.snook@gmail.com, kuba@kernel.org, hkallweit1@gmail.com,
        jesse.brandeburg@intel.com, dchickles@marvell.com,
        tully@mikrotik.com, eric.dumazet@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] atl1c: add 4 RX/TX queue support for
 Mikrotik 10/25G NIC
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20210525081933.2845119-1-gatis@mikrotik.com>
References: <20210525081933.2845119-1-gatis@mikrotik.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

From: Gatis Peisenieks <gatis@mikrotik.com>
Date: Tue, 25 May 2021 11:19:33 +0300

> More RX/TX queues on a network card help spread the CPU load among
> cores and achieve higher overall networking performance. The new
> Mikrotik 10/25G NIC supports 4 RX and 4 TX queues. TX queues are
> treated with equal priority. RX queue balancing is fixed based on
> L2/L3/L4 hash.
> 
> This adds support for 4 RX/TX queues while maintaining backwards
> compatibility with older hardware.
> 
> Simultaneous TX + RX performance on AMD Threadripper 3960X
> with Mikrotik 10/25G NIC improved from 1.6Mpps to 3.2Mpps per port.
> 
> Backwards compatiblitiy was verified with AR8151 and AR8131 based
> NICs.
> 
> Signed-off-by: Gatis Peisenieks <gatis@mikrotik.com>
> ---
> v2:
>         - rebase on net-next master as requested by David Miller

Please fix these warnings:
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:891: warning: Function parameter or member 'queue' not described in 'atl1c_clean_tx_ring'
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:891: warning: Excess function parameter 'type' description in 'atl1c_clean_tx_ring'
drivers/net/ethernet/atheros/atl1c/atl1c_main.c:917: warning: Function parameter or member 'queue' not described in 'atl1c_clean_rx_ring'
New warnings added
0a1,3
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:891: warning: Function parameter or member 'queue' not described in 'atl1c_clean_tx_ring'
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:891: warning: Excess function parameter 'type' description in 'atl1c_clean_tx_ring'
> drivers/net/ethernet/atheros/atl1c/atl1c_main.c:917: warning: Function parameter or member 'queue' not described in 'atl1c_clean_rx_ring'
Per-file breakdown

Thank you.