Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4822293pxj; Tue, 25 May 2021 17:58:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmyGN3/9J+9iR7arEEILhLS7cb1U8KISJSRaT4Zw/cM51S7tUXp19of8d7TRI29D792LS2 X-Received: by 2002:a05:6638:d09:: with SMTP id q9mr404061jaj.32.1621990717796; Tue, 25 May 2021 17:58:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1621990717; cv=none; d=google.com; s=arc-20160816; b=olee66xDTR6lzJU16QCO3D2Sb70jUDCHa1ZjAKkGRi0fwArF7jp0x0fHiRA7A5f3A0 d4Onsvgo3ScNdxziZ0lMPAlTevjj10uXtqMkALlQQB7Ul+8hVJLyObB1J54GVwzcbKRs IrnS4dL+2sgFFCRAmLIqvUfeCrc0QxBIZ7xdQOcEy5cDSSi9jsrG17c9W9IT9Dj0BITT qW7QWnrL/22rzwxbbaNU8BxD4Ng2svmho6bHeL6Gyf8mxtcPMNOSMCR8vhiFQ/sJqOEh CmqwINFhyDxLWLVCljb6YeaxtEx97ujdQ1H6ZOacn1LcwhxE7oWpmohA5GEeWfdclOe5 urEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=AV1x4xY7BNlvbADnTNrQXi/pFbf3brHLvoWH+DisJu8=; b=Av9HI4LzWfS2lplKKQPO/My8Hfy9ZiUwBM69vN3Usk9NzbK8heonO19PGsyxAEaD11 dne8XQcazCHqLBLcRuw4gkP8o+1cecYFVa0PQxpvjGbKxsM0MPc6wgkp2rf24MB/sWIf Gw5p3f3B6utZdDtS4SHVmq+wx08e8lVhpn1v/tHLH8pzdDXygtgsnmMTchBr5fAIz3Ov 7Hxy6hGiaXx+TFW3wPZ7QyOwQrOc4eDS+Sn3K/xVVWhwGkX7MD8QGbgR6oNfyw+1TmBV V1sAUn/3pC9xF1xlthQceVxqDXy6dLss6R0uFVXG/+Gc/sDjwcMFCHXBQBUNB06++14L aSvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="TVv/M+CI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w12si19304510ill.144.2021.05.25.17.58.24; Tue, 25 May 2021 17:58:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="TVv/M+CI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232068AbhEYVgN (ORCPT + 99 others); Tue, 25 May 2021 17:36:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231164AbhEYVgN (ORCPT ); Tue, 25 May 2021 17:36:13 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CD53C061756 for ; Tue, 25 May 2021 14:34:43 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id s19so31661532oic.7 for ; Tue, 25 May 2021 14:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=AV1x4xY7BNlvbADnTNrQXi/pFbf3brHLvoWH+DisJu8=; b=TVv/M+CITgXJfBorA0YOq7+hshFN1qCmyi7/acuHDjIxa5rN4/3A6i2PsmL5+17oV2 S+cCUc9QAtjPKA1TU++KXfTwbEPFGfcYc8H/W0Wd844tGn+fT6ZgcjK3Pvjho31P8dTZ Zld23f9YNBRYC3Xo68O6dW7FMZ2eny1a2GHAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=AV1x4xY7BNlvbADnTNrQXi/pFbf3brHLvoWH+DisJu8=; b=ETJeoyoHxXBcjWTfaj4hV8rtBwEaeVFn0YNW4QrseXDLngeUF3IkBGPn9IZpFmgKx4 qfvaXJtwCyuHZoHj4HQ/d6/3b2lLcPS3Pgy0jYpEpY62zVB/QjpO3wEH8mk2qxAmzCl5 D3pQtL4CkxhuLe2a2ShRtX95+ekVAB5gNkaDCL86/ySurrQinlM/vfe2Zx+NoJySNVhA Fw3xbRzJp9qUmAONAZ9RocWsmycUXKUjEp8T/1xu9pFrq4ycEA8TsaXOI2YANab++8U+ BK8BXNvhFLv3TNiSiGjXoBY3ZFvkQL6zGeFGCoPqgKue1jjUJ419TY7k6J1oFH5ADNrI kL8w== X-Gm-Message-State: AOAM533TnUpUuK+11815+lszJQg6C4bdizV+dZkYOKEMtPj7w9bIz7R7 1lWbqSOjzbxN82Jwv/tmbKovoqJE3I1rllDhBDqxmQ== X-Received: by 2002:aca:654d:: with SMTP id j13mr262572oiw.125.1621978482401; Tue, 25 May 2021 14:34:42 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 25 May 2021 17:34:41 -0400 MIME-Version: 1.0 In-Reply-To: <20210525131051.31250-2-rojay@codeaurora.org> References: <20210525131051.31250-1-rojay@codeaurora.org> <20210525131051.31250-2-rojay@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 25 May 2021 17:34:41 -0400 Message-ID: Subject: Re: [PATCH V11 1/2] i2c: i2c-qcom-geni: Add shutdown callback for i2c To: Roja Rani Yarubandi , wsa@kernel.org Cc: dianders@chromium.org, saiprakash.ranjan@codeaurora.org, gregkh@linuxfoundation.org, mka@chromium.org, skananth@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org, rnayak@codeaurora.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Roja Rani Yarubandi (2021-05-25 06:10:50) > If the hardware is still accessing memory after SMMU translation > is disabled (as part of smmu shutdown callback), then the > IOVAs (I/O virtual address) which it was using will go on the bus > as the physical addresses which will result in unknown crashes > like NoC/interconnect errors. > > So, implement shutdown callback for i2c driver to suspend the bus > during system "reboot" or "shutdown". > > Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller") > Signed-off-by: Roja Rani Yarubandi > --- Reviewed-by: Stephen Boyd