Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 May 2021 14:49:48 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Trent Piepho <tpiepho@gmail.com>
Cc:     linux-kernel@vger.kernel.org, andy@kernel.org, oskar@scara.com,
        Daniel Latypov <dlatypov@google.com>
Subject: Re: [PATCH v2 2/2] lib/math/rational: Add Kunit test cases
Message-Id: <20210525144948.5bf487414edd6e0655902cf4@linux-foundation.org>
In-Reply-To: <20210525144250.214670-2-tpiepho@gmail.com>
References: <20210525144250.214670-1-tpiepho@gmail.com>
        <20210525144250.214670-2-tpiepho@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 25 May 2021 07:42:50 -0700 Trent Piepho <tpiepho@gmail.com> wrote:

> Adds a number of test cases that cover a range of possible code paths.
>=20
> --- /dev/null
> +++ b/lib/math/rational-test.c
> @@ -0,0 +1,56 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <kunit/test.h>
> +
> +#include <linux/rational.h>
> +
> +struct rational_test_param {
> +	unsigned long num, den;
> +	unsigned long max_num, max_den;
> +	unsigned long exp_num, exp_den;
> +
> +	const char *name;
> +};
> +
> +static const struct rational_test_param test_parameters[] =3D {
> +	{ 1230,	10,	100, 20,	100, 1,    "Exceeds bounds, semi-convergent term >=
 =BD last term" },
> +	{ 34567,100, 	120, 20,	120, 1,    "Exceeds bounds, semi-convergent term=
 < =BD last term" },

It seems to be asking for trouble to use these characters in kernel
output - heaven knows what sort of weird output devices people
are using.  So I think I'll switch to "1/2", OK?

> +	{ 1, 30,	100, 10,	0, 1,	   "Closest to zero" },
> +	{ 1, 19,	100, 10,	1, 10,     "Closest to smallest non-zero" },
> +	{ 27,32,	16, 16,		11, 13,    "Use convergent" },
> +	{ 1155, 7735,	255, 255,	33, 221,   "Exact answer" },
> +	{ 87, 32,	70, 32,		68, 25,    "Semiconvergent, numerator limit" },
> +	{ 14533, 4626,	15000, 2400,	7433, 2366, "Semiconvergent, demominator li=
mit" },
> +};
> ...
> +static struct kunit_case rational_test_cases[] =3D {
> +       KUNIT_CASE_PARAM(rational_test, rational_gen_params),
> +       {}
> +};
> +
> +static struct kunit_suite rational_test_suite =3D {
> +       .name =3D "rational",
> +       .test_cases =3D rational_test_cases,
> +};

And let's use tabs to indent here.  checkpatch detects this.