Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210525121448.30075-1-rex-bc.chen@mediatek.com> <20210525121448.30075-3-rex-bc.chen@mediatek.com>
In-Reply-To: <20210525121448.30075-3-rex-bc.chen@mediatek.com>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Wed, 26 May 2021 10:47:10 +0800
Message-ID: <CAAOTY__0EU5Sjo2ygj2tXHk3VTRuyEf+q4cGh3nGN1K1vMkFMw@mail.gmail.com>
Subject: Re: [v4,PATCH 2/3] drm/mediatek: config driver data to support dual
 edge sample
To:     Rex-BC Chen <rex-bc.chen@mediatek.com>
Cc:     Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        DTML <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        Jitao Shi <jitao.shi@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Rex:

Rex-BC Chen <rex-bc.chen@mediatek.com> =E6=96=BC 2021=E5=B9=B45=E6=9C=8825=
=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=888:15=E5=AF=AB=E9=81=93=EF=BC=
=9A
>
> Add output_fmts and num_output_fmts value for all configuration.
>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dpi.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediate=
k/mtk_dpi.c
> index d3b883c97aaf..d6a422986efc 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -695,10 +695,21 @@ static unsigned int mt8183_calculate_factor(int clo=
ck)
>                 return 2;
>  }
>
> +static const u32 mt8173_output_fmts[] =3D {
> +MEDIA_BUS_FMT_RGB888_1X24,

indent.

> +};
> +
> +static const u32 mt8183_output_fmts[] =3D {
> +MEDIA_BUS_FMT_RGB888_2X12_LE,
> +MEDIA_BUS_FMT_RGB888_2X12_BE,

ditto.

Regards,
Chun-Kuang.

> +};
> +
>  static const struct mtk_dpi_conf mt8173_conf =3D {
>         .cal_factor =3D mt8173_calculate_factor,
>         .reg_h_fre_con =3D 0xe0,
>         .max_clock_khz =3D 300000,
> +       .output_fmts =3D mt8173_output_fmts,
> +       .num_output_fmts =3D ARRAY_SIZE(mt8173_output_fmts),
>  };
>
>  static const struct mtk_dpi_conf mt2701_conf =3D {
> @@ -706,18 +717,24 @@ static const struct mtk_dpi_conf mt2701_conf =3D {
>         .reg_h_fre_con =3D 0xb0,
>         .edge_sel_en =3D true,
>         .max_clock_khz =3D 150000,
> +       .output_fmts =3D mt8173_output_fmts,
> +       .num_output_fmts =3D ARRAY_SIZE(mt8173_output_fmts),
>  };
>
>  static const struct mtk_dpi_conf mt8183_conf =3D {
>         .cal_factor =3D mt8183_calculate_factor,
>         .reg_h_fre_con =3D 0xe0,
>         .max_clock_khz =3D 100000,
> +       .output_fmts =3D mt8183_output_fmts,
> +       .num_output_fmts =3D ARRAY_SIZE(mt8183_output_fmts),
>  };
>
>  static const struct mtk_dpi_conf mt8192_conf =3D {
>         .cal_factor =3D mt8183_calculate_factor,
>         .reg_h_fre_con =3D 0xe0,
>         .max_clock_khz =3D 150000,
> +       .output_fmts =3D mt8173_output_fmts,
> +       .num_output_fmts =3D ARRAY_SIZE(mt8173_output_fmts),
>  };
>
>  static int mtk_dpi_probe(struct platform_device *pdev)
> --
> 2.18.0
>