Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp4917543pxj; Tue, 25 May 2021 21:09:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNTLtkQ5bfEbF1Ax5FwR3lp7+gRv0ZSGSPx/RFkYqoVfj1tW1JmR0fxS791XzxclKPHFgJ X-Received: by 2002:a05:6402:2215:: with SMTP id cq21mr35173733edb.28.1622002148164; Tue, 25 May 2021 21:09:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622002148; cv=none; d=google.com; s=arc-20160816; b=alU6Z3ResXDkSVb7RXgczh48qOKp2X6GNJKr7+32sO6PfPbF0E8UyBIksqnPVRrqD1 lOQ446rhE5jFL30zGiY9jVl47Xlj/s3EMUahVXyGmkRq9LktM4/OlVkS8k6rOel9m1FU H+rKDm8OgOZ9hesG7Cp4/iqtIAORGMyq6BDRkjmUK5qrGnXCdP9KdM3bLERZRALUXwxU WkBod7UBgE/uUlGYHugYpPkQczQIRjWLO7cepbyq5wf8J/MRaYY9UmB3BKT+a+d9TCY8 xPipBgn45MFWUBIxcjel0q8opvkUCMEGR5UeaakoTVe87zxAo9zs83LGif7y6ujACEjM yFJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=z4eN7IxLpn6PHpsFw2qfGqskvr49Fav7d3pD3NkuajY=; b=LmNWQYFWVkOoNm0glg1HgKXVOYwc3unV+VjxWP07/oPrX6aQkn3IH3DMIvZQZwhh3c dj2rIBSbcWci5JsqLarcIZJcJdMsTT3YNIrrc+HDv8F4W02IRvll9oAg48zF6HSmTU73 U7l9OR/+X49lEBLmxE6vYV2RUvUTUpyBAJivO7QlhkKXlFx7vJ89FhMuLJ4RQcDjWDka z2T/33eoMd8HB7y3AFm4UHFBuMEl0+3SiWgRbbziunZNeYv/T7SohkcS3+Ru9AiroYoV aozDafzmNblO1tKpSdEurPCxU5Y1gYTQFw249iyZ5nAgdyfp4AzxKTVO9j9io9yTzhr6 VC1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HxqB9QXa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w11si21784741ede.590.2021.05.25.21.08.44; Tue, 25 May 2021 21:09:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HxqB9QXa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231936AbhEZCIR (ORCPT + 99 others); Tue, 25 May 2021 22:08:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:33730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230145AbhEZCIR (ORCPT ); Tue, 25 May 2021 22:08:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9CD2961260; Wed, 26 May 2021 02:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621994806; bh=yRr75FXBDkkX6XLpZgf/r8ILJmMAe0Rn0jw76SQB5fU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HxqB9QXadza+92feVmfiJr0l8ONPm4BbzOMPBgsjDVHEaJq73542HPp1zGpMa1HgU 9cAUCVmpj3/FJxdaXrwE3o7Id+LEuVoCaT6jOwAGcOHzJl0/UpfqivPhGNVRpVaLIv EvEI9sPIJRY1N2iivViNbS02uvoRV+M1vlW14Y1pavPqAD8BcB0LECLj7tV/hUYUvT K2hHNTg6nPy5N+ZpGLqixXKirhUOhVwjyO139vMlCAXGUUkFzSybJwQUxm+GFoGJnD e0Jttoe6+ywFvlOx05GKX79atc7ohdY5+PKY7M2IgUvXpF9nZonpR9VDcVg75QxeLU XHUkIWlfVUjaQ== Received: by mail-lj1-f172.google.com with SMTP id v5so40667797ljg.12; Tue, 25 May 2021 19:06:46 -0700 (PDT) X-Gm-Message-State: AOAM532zmY8TBS9qkIzV8DKcDEW+uq0s0h4sCdlsraJObRfdQ7Y+vB9T 94x9TAvLIwSYAqC2fJQ02nMqxG9o/Q4/aoh8NS4= X-Received: by 2002:a2e:1416:: with SMTP id u22mr386289ljd.498.1621994804881; Tue, 25 May 2021 19:06:44 -0700 (PDT) MIME-Version: 1.0 References: <1621945234-37878-1-git-send-email-guoren@kernel.org> In-Reply-To: <1621945234-37878-1-git-send-email-guoren@kernel.org> From: Guo Ren Date: Wed, 26 May 2021 10:06:33 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arch: Cleanup unused functions To: Arnd Bergmann Cc: linux-riscv , Linux Kernel Mailing List , linux-arch , linux-sunxi@lists.linux.dev, Guo Ren , Michal Simek , Christoph Hellwig , Anup Patel , Palmer Dabbelt , Guo Ren Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Could you help add the patch to your next-tree? Also, please append below: Reviewed-by: Christoph Hellwig Reviewed-by: Anup Patel Thx On Tue, May 25, 2021 at 8:21 PM wrote: > > From: Guo Ren > > These functions haven't been used, so just remove them. The patch > has been tested with riscv, but I only use grep to check the > microblaze's. > > Signed-off-by: Guo Ren > Cc: Arnd Bergmann > Cc: Michal Simek > Cc: Christoph Hellwig > --- > arch/microblaze/include/asm/page.h | 3 --- > arch/riscv/include/asm/page.h | 10 ---------- > 2 files changed, 13 deletions(-) > > diff --git a/arch/microblaze/include/asm/page.h b/arch/microblaze/include/asm/page.h > index bf681f2..ce55097 100644 > --- a/arch/microblaze/include/asm/page.h > +++ b/arch/microblaze/include/asm/page.h > @@ -35,9 +35,6 @@ > > #define ARCH_SLAB_MINALIGN L1_CACHE_BYTES > > -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1))) > -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1))) > - > /* > * PAGE_OFFSET -- the first address of the first page of memory. With MMU > * it is set to the kernel start address (aligned on a page boundary). > diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h > index 6a7761c..a1b888f 100644 > --- a/arch/riscv/include/asm/page.h > +++ b/arch/riscv/include/asm/page.h > @@ -37,16 +37,6 @@ > > #ifndef __ASSEMBLY__ > > -#define PAGE_UP(addr) (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1))) > -#define PAGE_DOWN(addr) ((addr)&(~((PAGE_SIZE)-1))) > - > -/* align addr on a size boundary - adjust address up/down if needed */ > -#define _ALIGN_UP(addr, size) (((addr)+((size)-1))&(~((size)-1))) > -#define _ALIGN_DOWN(addr, size) ((addr)&(~((size)-1))) > - > -/* align addr on a size boundary - adjust address up if needed */ > -#define _ALIGN(addr, size) _ALIGN_UP(addr, size) > - > #define clear_page(pgaddr) memset((pgaddr), 0, PAGE_SIZE) > #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) > > -- > 2.7.4 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/