Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: skakit=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 26 May 2021 09:29:25 +0530
From:   skakit@codeaurora.org
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, kgunda@codeaurora.org
Subject: Re: [PATCH V5 06/11] arm64: dts: qcom: pmr735a: Correct the GPIO node
In-Reply-To: <YK1kcVj9iyekNnrj@google.com>
References: <1621937466-1502-1-git-send-email-skakit@codeaurora.org>
 <1621937466-1502-7-git-send-email-skakit@codeaurora.org>
 <YK1kcVj9iyekNnrj@google.com>
Message-ID: <f9f929f3bcf41f0188d27a57a79174a3@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

On 2021-05-26 02:26, Matthias Kaehlcke wrote:
> On Tue, May 25, 2021 at 03:41:01PM +0530, satya priya wrote:
>> Add gpio ranges and correct the compatible to add
>> "qcom,spmi-gpio" as this pmic is on spmi bus.
>> 
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> ---
>> Changes in V5:
>>  - This is split from patch [5/11] and added newly in V5.
> 
> actually it's a split from patch [5/8], right?
> 

Right, my bad. I should have mentioned this way to be more clear.
Thank you for reviewing the patches!

> https://patchwork.kernel.org/project/linux-arm-msm/patch/1621318822-29332-6-git-send-email-skakit@codeaurora.org/
> 
>>  arch/arm64/boot/dts/qcom/pmr735a.dtsi | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/pmr735a.dtsi 
>> b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
>> index b0a7cd6c0..b4b6ba24 100644
>> --- a/arch/arm64/boot/dts/qcom/pmr735a.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/pmr735a.dtsi
>> @@ -21,9 +21,10 @@
>>  		};
>> 
>>  		pmr735a_gpios: gpio@8800 {
>> -			compatible = "qcom,pmr735a-gpio";
>> +			compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio";
>>  			reg = <0x8800>;
>>  			gpio-controller;
>> +			gpio-ranges = <&pmr735a_gpios 0 0 4>;
>>  			#gpio-cells = <2>;
>>  			interrupt-controller;
>>  			#interrupt-cells = <2>;
> 
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>