Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        njavali@marvell.com
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        jejb@linux.ibm.com, GR-QLogic-Storage-Upstream@marvell.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: Remove redundant assignment to rval
Date:   Wed, 26 May 2021 00:07:22 -0400
Message-Id: <162200196243.11962.2847628665224786477.b4-ty@oracle.com>
In-Reply-To: <1620643206-127930-1-git-send-email-jiapeng.chong@linux.alibaba.com>
References: <1620643206-127930-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ca-mkp.mkp.ca.oracle.com (138.3.201.9) by SN6PR2101CA0004.namprd21.prod.outlook.com (2603:10b6:805:106::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.2 via Frontend Transport; Wed, 26 May 2021 04:07:43 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 31cac82b-fff9-43b9-b189-08d91ffbd08d
X-MS-TrafficTypeDiagnostic: PH0PR10MB4469:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <PH0PR10MB4469261DBC08609AB104DB268E249@PH0PR10MB4469.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6790;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RaVXEiTfnRJhMSLPW2iCKkywrXZrmvhYJNdfDhp2QOhEjpJCQSdoHnUh5sdDLxi5JWS6xdxT2khHZLJKBCXQWRfHjHOqA2F45PgyyazNuLFyvcreaCheRoLv4Ox9avJ3ZgMwA6C9enRCHd76pdb7g+Pdn8tvoHoQLyQcFj99tmUUWBcrY4p5RYhZt5z/nnnSL3mGNx5FNcZX+RwJnqqDQligAsMjsKYiJeR+FWvI0SI+5eISSqZSs5dCBI8vFwj1xa2f1EOtzCQ9bGkQ+HP6QYv2T4LptN06gRFwcJdmYQcOTcPYuS+o2H23U5+57xVwB+uBS/iNhqKdMGh9T+Cu9/S4g1htZRyVjo5PrrKZCc0wstJzBg/PcBpwqxZORc6CCX3oPn9DUVCT/Kyl9xshPjvw9fWX8TggoXgLmsCQaOMlXppv10it8JULAAL6Eng78LqakdiP9U19LpJiwZ5UM5ZW0oZ+Iw979ei1vwQ2owXPMK4KyENAW3IOOGmuBnKL40B4bfb9f7W/8ESJAgH7zszWSL2zBL0UprR7H2namKUA0K8r9rn++avBUjAGGpSByJawSidC1v4/wAbvetnge5ECv1bOcgS/EqSQc/F3awqCYOaYM+qncNbZ9zOIBo8FhCXftWKR0I9+z6DNIxofMYg1VctgsLLtxXpL44ZvDQHWXMNe7kjZKW5Kc0ossfS2u/CW/T2Hj4IlNmDmhl+rVbIcGVrczy5YjEvbD9Lib+CPS5815LJZ6ZlpxdsV6NxucCXvY4JDNOUfFyhn5xUWXA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR10MB4759.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(346002)(39860400002)(376002)(136003)(316002)(16526019)(186003)(66946007)(4326008)(103116003)(26005)(2616005)(4744005)(8936002)(956004)(2906002)(66476007)(66556008)(7696005)(38350700002)(52116002)(38100700002)(5660300002)(8676002)(6486002)(86362001)(6666004)(83380400001)(478600001)(966005)(36756003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VTY5ZUFBNWlxWkh5WjhFWFU1SFcvUy9TZnp0MSsxeHdISXpjU1FlUG9VS05k?=
 =?utf-8?B?alN5VUxORXdGdjFJaHhtYmljbXRoMjdqN0t5c2RUMDd4bWV6S1hwdS9Fd3pu?=
 =?utf-8?B?MFNiYTN3Zlpydm80Tm4zVHB4VGU4QllpSDY3bnA0WEpybFc1V05aV01OMEkr?=
 =?utf-8?B?cStSUnRPSkhRSGRqK2dsRlRuMFU2dEw5KzZEVlNYZk9IaWZoQWxnNzIyQ01x?=
 =?utf-8?B?VDNBQlhPYmR2MWp6eVEwblhkeVJmbXNvWks3dnZRUTlCNDU0R1VBT0l4YjZs?=
 =?utf-8?B?Uno0dlVJZll3aFkvVnlnM0lOL0MyTjRWNW1NU0VmelhlOGtYRUd2TGZ4UUNm?=
 =?utf-8?B?WW52RDdnUmdZOEhmclExMitXR2hqV0F3N0VScHZwSWRwZTRJRFNaaU5RTzV4?=
 =?utf-8?B?aW03WVR2QjZDYXpOZExGL2NuMHc2a05BbjhSdlhDeVdQSmQ0U0twVU1BMnVo?=
 =?utf-8?B?clEwTnVLaHhyRVN0KzdveHBqNDJDcHIyZTFUbTI3VXg4L3dEQTN3LzRBVGxh?=
 =?utf-8?B?b0wwOHE1SmhwL21La2ZCaU1JN3pSK2RUemdKQTJpK3VPR05zd1ZESDRLbnpZ?=
 =?utf-8?B?cTE3aFJ4bzNuK1ExaEdOVGRGRCs3T21zR21QbU11elRnR1NiaUY4cGJ5R2dN?=
 =?utf-8?B?Ylh6NWltaWltUUVCM04vbmVtdjBrNWMxTXhSTk1WZDA4QVQ1QlMwaUdqeWlj?=
 =?utf-8?B?Sm9JVmx3WWpLWjBzZVJIVkxhS2xTcFUzUXg2RlI4TW9PZ0o4T1ZkV3FZZVQv?=
 =?utf-8?B?NHdKZTJhcVdWZm0zaW4wZ0JNUVdXL2NMOFgwQ1BndDFINXpmZUw3ZENZVHh2?=
 =?utf-8?B?NHV2VXdVNi9KYWpKQkZQTHVwTDBpTU1iMURxS1Q2OTlPTi9SMTh4ZHRvNVgr?=
 =?utf-8?B?MDd6TzBJNDg4bnE2S3RLcEhSZEdjenZDeFJuL25GN2hITlhyZXdsTXB2MkJn?=
 =?utf-8?B?U25yQmdrU2w4WHkrZmdHMHdZUU9wQnpCa1J4bjB5cko2ajVja21iRVI5NWhy?=
 =?utf-8?B?TndhVjFqVitYeVJSblF3c0lZNllRd2FWYnNxSjh0TXc2UWxuQVUxb2RHc1Vh?=
 =?utf-8?B?YTVxeFdCZm5sNWtNbitjR29IYlVwOE52MS9CSjN4djlOUVR3K0dGK2l5M2Qx?=
 =?utf-8?B?bTQ1bVFNVWhOTmZndHRMZm81Nm1UVkszeEJBRHZWK1RZR05nY0hNQ1dzT2cz?=
 =?utf-8?B?UWJ6NWM1NTBXRzFUYnJEb3F4S2YxbTR1VW96endzWlQrVEtkYXlCNzVvc2Nx?=
 =?utf-8?B?RUMwMStreXVod2Y0VVdHS3BOZnFwclVTOFY5cmEwSU0wbzlhNk9SVXNZWkpn?=
 =?utf-8?B?TEJBdlF5aEZLUWJwVmZjcFMrcG1jODJlZ2hvZFZqSDJqdVd3enpReHVRZXMw?=
 =?utf-8?B?RUtmVDJqbHE3RWxtRFZSTGFPQk9tMlBuZ3NIdVpkbSsvY2VmN2FsMlZXdzh0?=
 =?utf-8?B?SHNCcndHSk4zY0RQZFRvSnNjaStLYSsrMStNZnpuUnFyUGZjMnpzcEE3bGNJ?=
 =?utf-8?B?TVJLMERhTWlmeHl3aTJIbVF3R204MktNODZEbUZiOC9EWElBWVEzWFhMcldH?=
 =?utf-8?B?K1o2TVdka2NPTGltVC9lRlZxNHNUbnVTOTMydTRobHFJYUxsM2ZDVE9QVUFW?=
 =?utf-8?B?WXRuZmFPUkhaK1RvRmZkRUUrMURRUGZsMVpRbFJhT2dlZ2tmOVRtVHUyQmt6?=
 =?utf-8?B?bDVXL3g3UXJqT2gwYTNCOFJoaE16UGEwNEFoSmQ0K1B3YzdCUHV6bUh1M3ZW?=
 =?utf-8?Q?PkkurIoaftEGdTx4HZLxcK05AVbIhTcEHTktb92?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31cac82b-fff9-43b9-b189-08d91ffbd08d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2021 04:07:44.7846
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bsr+k3Dx3g15VFwf6frm+n3SVLROubHpyfY60jU87wkI0fKIX5KDKppNOWX8KB0+IVCCvqPx5qjopwgzgcE9s7/YFCDZbjG5oph6CWZ4XGg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4469
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9995 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 spamscore=0
 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105260026
X-Proofpoint-ORIG-GUID: o-CXk9YLFtCfVmQngN8Pqk2DfWtILguP
X-Proofpoint-GUID: o-CXk9YLFtCfVmQngN8Pqk2DfWtILguP
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9995 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxscore=0
 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0
 adultscore=0 phishscore=0 priorityscore=1501 clxscore=1015 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000
 definitions=main-2105260025
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 10 May 2021 18:40:06 +0800, Jiapeng Chong wrote:

> Variable rval is set to QLA_SUCCESS, but this value is never read as
> it is overwritten later on, hence it is a redundant assignment and
> can be removed.
> 
> Clean up the following clang-analyzer warning:
> 
> drivers/scsi/qla2xxx/qla_init.c:4359:2: warning: Value stored to 'rval'
> is never read [clang-analyzer-deadcode.DeadStores].

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: qla2xxx: Remove redundant assignment to rval
      https://git.kernel.org/mkp/scsi/c/cb9eb11fd572

-- 
Martin K. Petersen	Oracle Linux Engineering