Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: nxpnwqmksiAezhgL5EXgcKsxf47edoQYs+zF+X67YCaWAXHl7o28PNp7lbyynyI8j6Hln74Xqm
 yrmCv8GszZtQ==
IronPort-SDR: BOWpYMucKBb3PRHow4HJKfeFxbQ+pJKhFKY5nU+pkjl7zsFefbeEHbETfh1r5dRm5uMGJqIp9W
 Suf9sRUeo7HA==
Date:   Wed, 26 May 2021 10:54:39 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Daniel Scally <djrscally@gmail.com>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        Wolfram Sang <wsa@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Maximilian Luz <luzmaximilian@gmail.com>,
        linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        linux-i2c@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        devel@acpica.org, Len Brown <lenb@kernel.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Russell King <linux@armlinux.org.uk>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Mark Gross <mgross@linux.intel.com>,
        Robert Moore <robert.moore@intel.com>,
        Erik Kaneda <erik.kaneda@intel.com>,
        laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com
Subject: Re: [PATCH v4 7/8] platform/x86: Add intel_skl_int3472 driver
Message-ID: <YK3+vxmWfD0mhjU0@smile.fi.intel.com>
References: <20210520140928.3252671-1-djrscally@gmail.com>
 <20210520140928.3252671-8-djrscally@gmail.com>
 <YKeuQM/O9+jDZFpb@smile.fi.intel.com>
 <6294177b-d6e1-8bbd-d313-5cce1c498604@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6294177b-d6e1-8bbd-d313-5cce1c498604@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, May 25, 2021 at 11:53:21PM +0100, Daniel Scally wrote:
> On 21/05/2021 13:57, Andy Shevchenko wrote:

...

> >> +static const struct regulator_ops int3472_gpio_regulator_ops;
> > Hmm... Can you use 'reg-fixed-voltage' platform device instead?
> >
> > One example, although gone from upstream, but available in the tree, I can
> > point to is this:
> >
> >   git log -p -- arch/x86/platform/intel-mid/device_libs/platform_bcm43xx.c
> >
> > It uses constant structures, but I think you may dynamically generate the
> > necessary ones.
> >
> 
> I can experiment with this, though one thing is we have no actual idea
> what voltages these are supplying...it doesn't look like that matters
> from drivers/regulator/fixed.c, but I'd have to try it to be sure.

I believe it is likely 1.8v. But I can check if I have the schematics of a
reference design for something like this.

...

> >> +	if (int3472->clock.ena_gpio) {
> >> +		ret = skl_int3472_register_clock(int3472);
> >> +		if (ret)
> >> +			goto out_free_res_list;
> >> +	} else {
> > Hmm... Have I got it correctly that we can't have ena_gpio && led_gpio together?
> 
> 
> No, just that we can only have led_gpio if we also have ena_gpio (at
> least that's the intention...)

Okay, perhaps then a comment above?

-- 
With Best Regards,
Andy Shevchenko