Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5077370pxj; Wed, 26 May 2021 02:12:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylaw5UHBn32J23W+2ySI+TYjqHaKkODXjgrXIXLiEDzkPiLDFAuOTsqYkoIzeqeL4MhJQk X-Received: by 2002:a17:906:4341:: with SMTP id z1mr33125656ejm.422.1622020374811; Wed, 26 May 2021 02:12:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622020374; cv=none; d=google.com; s=arc-20160816; b=zKjldmnWbKWMON2mQX6bowgPLvqrIBcpxubbC1ZQW4/0txQ85jiEfE+HrnokMC3DWV vQt+3G94+1NhX/jnze5UgPvGqXhTpAbhKO5HuFoTnVQSCUVH+WkAWCpb21+vP/NHWAlc OfjZZbVenn6kltdp/q6+HwOPssOicb/pOwqJ8cRYBTfJve9ZMprVJxKC6mylkHOEhIrk x1smSnjSsvnW4j1rbZdSXlmo8NLfFUPRhn/Z1OHz7+Mn0wnrjnEX43/1q27W8fpDgdT1 hy+s8fZVTRjhY4GzvszGKybUiwIBT3OQUIHNG8m7xCq9bGokASuRwsT/65WIlBYIBhwG ayDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :to:subject; bh=fgFFjwFKGYwn0mB8025G6LfiysoWoceOU3dNg5JWgSs=; b=BzxleBeQt4Lac1yLkUDKWOA7n3hg7f1gX+afyvJWHpAVjE8CpL6ZaDos3QFdMHoSzU nQiHhAf3mPlW51G7E/tvn8GNRcuEcnF1FZFNyHincG7If58MjoBhDmc4rsK0YTutq8gr pMwIkU4gccLrJ8a9893Acs0LRKHiUI4QTdLe+2hEFOtb+x3S9wPIRhenVEagGB00HC2k UEndhZ6C4SWpYc753LKJ5h7jqcpRw203z+6/gQ6dVJaCLr0P7ZS2YZH85kn9v2d9gOag ei6KaIu0RM5YMz1EnngPixWkj0cpeHr8T3zGAoad89wSUnjdDYMbV7/1wN6ABc8ENnQV /o8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i2si20651848ejp.119.2021.05.26.02.12.30; Wed, 26 May 2021 02:12:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233483AbhEZJKQ (ORCPT + 99 others); Wed, 26 May 2021 05:10:16 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:6638 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbhEZJKP (ORCPT ); Wed, 26 May 2021 05:10:15 -0400 Received: from dggems702-chm.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FqlRL157hz1BQ9W; Wed, 26 May 2021 17:05:50 +0800 (CST) Received: from dggemx753-chm.china.huawei.com (10.0.44.37) by dggems702-chm.china.huawei.com (10.3.19.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 26 May 2021 17:08:41 +0800 Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 26 May 2021 17:08:41 +0800 Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: immutable file can have null address in compressed chunk To: Jaegeuk Kim , , References: <20210521190217.2484099-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <33c5c36e-b5e1-cecc-fdc4-28a173a5b0a1@huawei.com> Date: Wed, 26 May 2021 17:08:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210521190217.2484099-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggemx704-chm.china.huawei.com (10.1.199.51) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/22 3:02, Jaegeuk Kim wrote: > If we released compressed blocks having an immutable bit, we can see less > number of compressed block addresses. Let's fix wrong BUG_ON. > > Signed-off-by: Jaegeuk Kim It looks it will be better to merge this into ("f2fs: compress: remove unneeded preallocation")? Reviewed-by: Chao Yu Thanks,