Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5126695pxj; Wed, 26 May 2021 03:32:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJweS1uLUIB6b94Aq72PuH0+tbT07qckjHi2tb0kDWDj36CvxMipddJzILygDFuFO7zukkDr X-Received: by 2002:a05:6402:1ac7:: with SMTP id ba7mr37684709edb.299.1622025175081; Wed, 26 May 2021 03:32:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622025175; cv=none; d=google.com; s=arc-20160816; b=lyce22NQJNukW7xdsUpHL7OtJmLcS0iKZSX3hRqx/B1WAHMZ1g6izolzZ6a7sgYcHb qNJE22bOPCLskD9ez/GKho6PelHUot7QHsGFgEdeGoBEi/DHJv6p6yTIc3FEDz7VOnpY 3tKfBtbnz5iO6DNeb3APVn3/CEDWTQ+SPrVlYvEPaf75fZT4NxZhKt6P058Ulvx3Lrl8 GVPv7qKzlc/NzOflJFt5svcX8gCFRdOILlpLIhfS3iZbfe5qwJ0OUprdddRZATF6GGb9 sol5iQ56EiRWNGiRaPbmO5F1fzft+tOyiVAkRXYWa9wS6fnxa4fdS7br3b9HZ/Kly2Od ol3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=IMes2+IKb1HAO/X5r/fVwBkJHZoFWVk8BYTRf1X5fck=; b=Q3ENgL8ExyJwPFe0igebJD6TXV/Ozjg9TwyCgIPxyx9tSbMNnOriBrxmabvDF1cE9E 8jd7qXg5U4l/dq8j8f8rYsqSTbnww7U5To9+t+vbsR+2VlBAbOc0rj1jZOOwxvmXgV70 Htqo6SvOaomH6BQLBkC4qpW94yfSjg8686PtjGL3n0VRy1d+dawiNywsxA2lJIUb692r FglilS/L9yaA2qUUOxh0KOAHgChZrGgOoQujaa+eO1krpVg8p0n56zIxnCn8FrHc2GsB D+5EdkPG2slOjW6gEPBJVAirs0K29A8OyW6To0VFJdVtuaWr+bPIRAS50uf+Dx207WR2 3FFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j25si17198959ejx.681.2021.05.26.03.32.29; Wed, 26 May 2021 03:32:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233953AbhEZKa5 (ORCPT + 99 others); Wed, 26 May 2021 06:30:57 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:47544 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233830AbhEZKa4 (ORCPT ); Wed, 26 May 2021 06:30:56 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04426;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Ua9losT_1622024957; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Ua9losT_1622024957) by smtp.aliyun-inc.com(127.0.0.1); Wed, 26 May 2021 18:29:23 +0800 From: Jiapeng Chong To: alim.akhtar@samsung.com Cc: avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] scsi: ufs: Fix missing error code in ufshcd_hba_init_crypto_capabilities() Date: Wed, 26 May 2021 18:29:16 +0800 Message-Id: <1622024956-39680-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eliminate the follow smatch warning: drivers/scsi/ufs/ufshcd-crypto.c:167 ufshcd_hba_init_crypto_capabilities() warn: missing error code 'err'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/scsi/ufs/ufshcd-crypto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd-crypto.c b/drivers/scsi/ufs/ufshcd-crypto.c index d70cdcd..c0163a3 100644 --- a/drivers/scsi/ufs/ufshcd-crypto.c +++ b/drivers/scsi/ufs/ufshcd-crypto.c @@ -163,8 +163,10 @@ int ufshcd_hba_init_crypto_capabilities(struct ufs_hba *hba) * hasn't advertised that crypto is supported. */ if (!(hba->capabilities & MASK_CRYPTO_SUPPORT) || - !(hba->caps & UFSHCD_CAP_CRYPTO)) + !(hba->caps & UFSHCD_CAP_CRYPTO)) { + err = -EINVAL; goto out; + } hba->crypto_capabilities.reg_val = cpu_to_le32(ufshcd_readl(hba, REG_UFS_CCAP)); -- 1.8.3.1