Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 May 2021 12:40:38 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Zhen Lei <thunder.leizhen@huawei.com>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Anssi Hannula <anssi.hannula@gmail.com>,
        Dmitry Torokhov <dtor@mail.ru>,
        linux-usb <linux-usb@vger.kernel.org>,
        linux-input <linux-input@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] HID: pidff: fix error return code in
 hid_pidff_init()
In-Reply-To: <20210508024737.1927-1-thunder.leizhen@huawei.com>
Message-ID: <nycvar.YFH.7.76.2105261240280.28378@cbobk.fhfr.pm>
References: <20210508024737.1927-1-thunder.leizhen@huawei.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 8 May 2021, Zhen Lei wrote:

> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: 224ee88fe395 ("Input: add force feedback driver for PID devices")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
>  drivers/hid/usbhid/hid-pidff.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
> index ea126c50acc3..3b4ee21cd811 100644
> --- a/drivers/hid/usbhid/hid-pidff.c
> +++ b/drivers/hid/usbhid/hid-pidff.c
> @@ -1292,6 +1292,7 @@ int hid_pidff_init(struct hid_device *hid)
>  
>  	if (pidff->pool[PID_DEVICE_MANAGED_POOL].value &&
>  	    pidff->pool[PID_DEVICE_MANAGED_POOL].value[0] == 0) {
> +		error = -EPERM;
>  		hid_notice(hid,
>  			   "device does not support device managed pool\n");
>  		goto fail;

Good catch, applied, thank you.

-- 
Jiri Kosina
SUSE Labs