Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <2fd417c59f40bd10a3446f9ed4be434e17e9a64f.camel@redhat.com>
Subject: Re: Writable module parameters in KVM
From:   Maxim Levitsky <mlevitsk@redhat.com>
To:     Paolo Bonzini <pbonzini@redhat.com>,
        Ben Gardon <bgardon@google.com>,
        Sean Christopherson <seanjc@google.com>,
        Jim Mattson <jmattson@google.com>,
        Junaid Shahid <junaids@google.com>,
        Peter Xu <peterx@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>
Date:   Wed, 26 May 2021 14:10:10 +0300
In-Reply-To: <35fe7a86-d808-00e9-a6aa-e77b731bd4bf@redhat.com>
References: <CANgfPd_Pq2MkRUZiJynh7zkNuKE5oFGRjKeCjmgYP4vwvfMc1g@mail.gmail.com>
         <35fe7a86-d808-00e9-a6aa-e77b731bd4bf@redhat.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2021-05-26 at 12:49 +0200, Paolo Bonzini wrote:
> On 26/05/21 01:45, Ben Gardon wrote:
> > At Google we have an informal practice of adding sysctls to control some 
> > KVM features. Usually these just act as simple "chicken bits" which 
> > allow us to turn off a feature without having to stall a kernel rollout 
> > if some feature causes problems. (Sysctls were used for reasons specific 
> > to Google infrastructure, not because they're necessarily better.)
> > 
> > We'd like to get rid of this divergence with upstream by converting the 
> > sysctls to writable module parameters, but I'm not sure what the general 
> > guidance is on writable module parameters. Looking through KVM, it seems 
> > like we have several writable parameters, but they're mostly read-only.
> 
> Sure, making them writable is okay.  Most KVM parameters are read-only 
> because it's much simpler (the usecase for introducing them was simply 
> "test what would happen on old processors").  What are these features 
> that you'd like to control?
> 
> > I also don't see central documentation of the module parameters. They're 
> > mentioned in the documentation for other features, but don't have their 
> > own section / file. Should they?
> 
> They probably should, yes.
> 
> Paolo
> 
I vote (because I have fun with my win98 once in a while),
to make 'npt' writable, since that is the only way
to make it run on KVM on AMD.
My personal itch only though!

Best regards,
	Maxim Levitsky