Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drm/rockchip: kick firmware-based framebuffer when
 initializing
To:     Icenowy Zheng <icenowy@aosc.io>, Sandy Huang <hjc@rock-chips.com>,
        =?UTF-8?Q?Heiko_St=c3=bcbner?= <heiko@sntech.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     linux-rockchip@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20210526085527.155840-1-icenowy@aosc.io>
From:   Thomas Zimmermann <tzimmermann@suse.de>
Message-ID: <13c50c42-4f2a-eed3-fc79-cbe6d1e7cae9@suse.de>
Date:   Wed, 26 May 2021 14:00:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <20210526085527.155840-1-icenowy@aosc.io>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="8BYw6q2hiLDaE4D6t7JULaNP7Anat21W2"
Precedence: bulk

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--8BYw6q2hiLDaE4D6t7JULaNP7Anat21W2
Content-Type: multipart/mixed; boundary="LZzy5vKYeS6aAktdZRJoJ4RLNbvtCfZeM";
 protected-headers="v1"
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Icenowy Zheng <icenowy@aosc.io>, Sandy Huang <hjc@rock-chips.com>,
 =?UTF-8?Q?Heiko_St=c3=bcbner?= <heiko@sntech.de>,
 David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Message-ID: <13c50c42-4f2a-eed3-fc79-cbe6d1e7cae9@suse.de>
Subject: Re: [PATCH] drm/rockchip: kick firmware-based framebuffer when
 initializing
References: <20210526085527.155840-1-icenowy@aosc.io>
In-Reply-To: <20210526085527.155840-1-icenowy@aosc.io>

--LZzy5vKYeS6aAktdZRJoJ4RLNbvtCfZeM
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

Hi

I think we already fixed this at [1]. Apparently no on epicked it up. If =

you awant to test, I'll add your Tested-by before merging the patch.

Best regards
Thomas

[1]=20
https://lore.kernel.org/dri-devel/20210516074833.451643-1-javierm@redhat.=
com/

Am 26.05.21 um 10:55 schrieb Icenowy Zheng:
> Since U-Boot now supports EFI and FB passing via EFI GOP, when booting
> rockchip SoCs via EFI, a EFI FB is available. However, currently when
> re-initializing display pipeline, the EFI FB is not removed, lead to
> fbcon not working (because the EFI FB is no longer bound to the display=

> pipeline although it's still /dev/fb0 and fbcon is bound to it).
>=20
> Add some code for removing firmware-based FB when initializing KMS of
> rockchipdrm.
>=20
> Tested on Pinebook Pro (RK3399) with U-Boot patchset for initializing
> eDP display applied.
>=20
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 3 +++
>   1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/=
drm/rockchip/rockchip_drm_drv.c
> index 212bd87c0c4a..3905fce6ce0b 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> @@ -158,6 +158,9 @@ static int rockchip_drm_bind(struct device *dev)
>   	 */
>   	drm_dev->irq_enabled =3D true;
>  =20
> +	/* Remove early framebuffers (ie. efifb) */
> +	drm_fb_helper_remove_conflicting_framebuffers(NULL, "rockchipdrmfb", =
false);
> +
>   	ret =3D rockchip_drm_fbdev_init(drm_dev);
>   	if (ret)
>   		goto err_unbind_all;
>=20

--=20
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
(HRB 36809, AG N=C3=BCrnberg)
Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer


--LZzy5vKYeS6aAktdZRJoJ4RLNbvtCfZeM--

--8BYw6q2hiLDaE4D6t7JULaNP7Anat21W2
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmCuOFcFAwAAAAAACgkQlh/E3EQov+CU
Mg//V2gspuj9JuJo17jjUtDZxGtg0cclw4uF6RWE0TZxjSpREAsLdCEFd9WrxIqgbGTJU+nFVzE1
wJaL1TfnACOmm/6BYr+xUm4F9ArpMDKbJcLpDzCYJmP+n0u1twXjrVBfE5xoW7ja40Vvx0LcImpb
/dnWF2xks5dZt0KbaOXAmtySqL1N4wQZr+BKj6T00bXctekhz/Hfgc8FwwQy+gD8ToEBfb46uzuT
wZGfXMbPPZ5BFvQFj6FwsXfORTpyevyeQGoFruqj6aTDxQpiYXWxtLS9/DzlTmHCPYHXqjxHSltM
igkb8qVEw7yAsuThVSTPBK6lt1C0YCvFUVpZGHL2LSraDXLna7K3bYvMDqbTNgWnprB0ImaL2RVy
9+1SYL2MDwBZFle8qsZsUbrG8w6zRZYUUO3H5EjUGC0ZG3dnFvLuH3IS5HUHhu2RPAv8dXfysvc7
wi3lQ+lNylV6Vt7NbQELWQC5Y8fHp08Un8MCQJFpXbYnQZUr2+ALdUc6RADPcBtuWipWKTkw+HwI
e5lBnZ9DeHsQkGDq9M0/PJu34NjeyK2vCjvqgsCsI7UrhooJ0ray9h038FNP/h5XA+NULExYIvC6
SMSAtmLsTjyryAgMHEMpJLaADJG0nr3OE/mReUG6Kn+dsjrSR71y7NOIRMOm5dJ2Z/iiWr/BEWrD
S84=
=LAV6
-----END PGP SIGNATURE-----

--8BYw6q2hiLDaE4D6t7JULaNP7Anat21W2--