Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5343361pxj; Wed, 26 May 2021 08:25:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynYoC+I8swwid9UMJEBsfR1X/1DRxv1lLZcvoxWbLsgmzss6IxSsIOmwSiqZVnsZicyHYU X-Received: by 2002:a17:906:af72:: with SMTP id os18mr33296829ejb.327.1622042719606; Wed, 26 May 2021 08:25:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622042719; cv=none; d=google.com; s=arc-20160816; b=Z8hs9O/p7X52E+715HXYDKJFgypQ/0EdgF605XxOyy2NLvW2KgIPRrDUMFBoHwtJlZ 5uBBimj5tVdQicGNKbrj6b2iFeG5I1uB0wo2gqqRJWIfx+a6ZCTQxwu7Ch+ZqrPRarxT FiL8si7BmSnd0WOUJkyrk4Suy2y7W+s5eoHiJLxFM1+4lHjKTRB0RThKQJjevyPmavO2 3xu3haToSStN+zC9WCrAKGD26mZdjPshRbt14wA8KJz/vCwLPfM8rgSoGLEj8HBwsxUC LDOdx5h20TNm/qTT8ht9QNhYwGn6iN8yEIq604R/d5uSt73WJyeJk/1xG3O8uPL/s3YO nQTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pEYv/cVE8dpSFqbeMd7nSL6UuSjcYO8ph/UZQDKS7+g=; b=Mt16aQZ1rxt/zMh0GdYD7mn8mejFB3fAiB1DnN9H8gXW8AXOP7WVMx4J5DOhk7pczS +L355FzYWXu4aLsVzZ0ztMTQKQePesxS2cr6d1each5Qg86mPDkbHZhHQmI8gMdqN840 g7zPdYajK49Utms7RXlrFxIQ6WfXZqJpgP+K5fKViq6nvd03ownyH7cLzBKrjzVnn/FL L3jy3TMW4GPGeq7x6WtaDGYPtNuMHd646YsPBDFlkseWPjfsPd2LVkxiuNHwxmolLFUQ DzaTmjmC2ensfaQAeFzbKauSzTkpl4Merrdb2B2K+2lc0YU8CfFq0KE8xlrdBF+Q+0ak URXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=bscH4fWQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si3346325edw.144.2021.05.26.08.24.54; Wed, 26 May 2021 08:25:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=bscH4fWQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235461AbhEZPZM (ORCPT + 99 others); Wed, 26 May 2021 11:25:12 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:59196 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235470AbhEZPZJ (ORCPT ); Wed, 26 May 2021 11:25:09 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 14QFNUZL001547; Wed, 26 May 2021 10:23:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1622042610; bh=pEYv/cVE8dpSFqbeMd7nSL6UuSjcYO8ph/UZQDKS7+g=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=bscH4fWQadjdVVcQPI0Aq/PIEhgMbuTtGhCuPdWwCp1Hu3fuhly+Gniw9wXjTgsBz gpcoSVRRHuuXWgswp+blEYud8l/qBiIHKpgKXah4xybgeJPHjw8jl0EJ3af1LTDeVc kvCOXKMUNwunomPNs7kpPhYI648B0PvwY4h+H/BI= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 14QFNUA5093201 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 May 2021 10:23:30 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 26 May 2021 10:23:30 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 26 May 2021 10:23:30 -0500 Received: from pratyush-OptiPlex-790.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 14QFN9Jb056314; Wed, 26 May 2021 10:23:25 -0500 From: Pratyush Yadav To: Maxime Ripard , Mauro Carvalho Chehab , Rob Herring , Pratyush Yadav , Kishon Vijay Abraham I , Vinod Koul , Peter Ujfalusi , Steve Longerbeam , Benoit Parrot , , , , , CC: Vignesh Raghavendra , Tomi Valkeinen , Chunfeng Yun , Laurent Pinchart Subject: [PATCH v2 03/18] phy: cdns-dphy: Allow setting mode Date: Wed, 26 May 2021 20:52:53 +0530 Message-ID: <20210526152308.16525-4-p.yadav@ti.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210526152308.16525-1-p.yadav@ti.com> References: <20210526152308.16525-1-p.yadav@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Allow callers to set the PHY mode. The main mode should always be PHY_MODE_MIPI_DPHY but the submode can either be PHY_MIPI_DPHY_SUBMODE_RX or PHY_MIPI_DPHY_SUBMODE_TX. Update the ops based on the requested submode. Signed-off-by: Pratyush Yadav --- (no changes since v1) drivers/phy/cadence/cdns-dphy.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dphy.c index 8656f2102a91..7d5f7b333893 100644 --- a/drivers/phy/cadence/cdns-dphy.c +++ b/drivers/phy/cadence/cdns-dphy.c @@ -365,11 +365,41 @@ static int cdns_dphy_configure(struct phy *phy, union phy_configure_opts *opts) return 0; } +static int cdns_dphy_set_mode(struct phy *phy, enum phy_mode mode, int submode) +{ + struct cdns_dphy *dphy = phy_get_drvdata(phy); + const struct cdns_dphy_driver_data *ddata; + + ddata = of_device_get_match_data(dphy->dev); + if (!ddata) + return -EINVAL; + + if (mode != PHY_MODE_MIPI_DPHY) + return -EINVAL; + + if (submode == PHY_MIPI_DPHY_SUBMODE_TX) { + if (!ddata->tx) + return -EOPNOTSUPP; + + dphy->ops = ddata->tx; + } else if (submode == PHY_MIPI_DPHY_SUBMODE_RX) { + if (!ddata->rx) + return -EOPNOTSUPP; + + dphy->ops = ddata->rx; + } else { + return -EOPNOTSUPP; + } + + return 0; +} + static const struct phy_ops cdns_dphy_ops = { .configure = cdns_dphy_configure, .validate = cdns_dphy_validate, .power_on = cdns_dphy_power_on, .power_off = cdns_dphy_power_off, + .set_mode = cdns_dphy_set_mode, }; static int cdns_dphy_probe(struct platform_device *pdev) -- 2.30.0