Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     dhowells@redhat.com, viro@zeniv.linux.org.uk
Cc:     phillip@squashfs.org.uk, squashfs-devel@lists.sourceforge.net,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Sean Nyekjaer <sean@geanix.com>
Subject: Squashfs on ubi blockdev
Message-ID: <2d27c68c-4ac8-c0ae-3f95-9b6234a4d31d@geanix.com>
Date:   Wed, 26 May 2021 15:21:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

After: 5a2be1288b514 ("vfs: Convert squashfs to use the new mount API")

We see this; when mounting a squashfs from a ubiblockdev:
root@iwg26-v2:/data/root# mount /dev/ubiblock0_6 /mnt

[   39.884295] /dev/ubiblock0_6: Can't open blockdev

But the filesystem is mounted anyway...

I have tried checking the returned error code get_tree_bdev() -> blkdev_get_by_path() returns -EROFS.

I have also tried to see what happens in squashfs_get_tree() it will be re-run with the ro option set.
Which explains why the filesystem ends up mouted.
[   39.889461] ####Custom debug: squashfs_get_tree -30


[   39.906309] ####Custom debug: squashfs_get_tree 0


Fair enough it's after all a squashfs :)

But could the error message be better? Or just filter out the print when getting a EROFS?

Br,
/Sean