Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5503342pxj; Wed, 26 May 2021 12:05:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhOhH9KodgKq47SBvZRpZKBdUdJq4Cl2cBEYb0mcAPwk03qqIbnblXhEIWAC35lTVhiIdR X-Received: by 2002:a17:906:f84d:: with SMTP id ks13mr991970ejb.103.1622055908406; Wed, 26 May 2021 12:05:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622055908; cv=none; d=google.com; s=arc-20160816; b=g9jHqsItNVCyQ9vmI6+1D8XjT31EMtbZY98hO0rG6J2RXK2zDP66y94yspmKW5ITz8 f4UiifA18BD1m3ph1nqz+XTlwcsdBWAFzz1JKpf8rNVlE9gO11D9fp8nYi7aWhsH3b1x /1VG20TyIaT1WAO1RNzeGG29sgDvp/ckfQEWtnpfpFSeUCY0uA1XE45PAXs+5+HJ8rBI z5xfIEcqHtWkc4o3f6CogVjpcUcd/+zK8Ye13TSdCA11mmgR/5Szf2ru4anbmMB6gcP1 1PkNxLOkt9fPyVTgH6ZdLsgUxnpmbXbZamAjPmthmlv9ZkhytqPTaEPx4j4W58ii+CpD DdWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=y47ptFTk8aLjiI5AFBqywGcPhDmxzelrkQcv54bfk3A=; b=fzt9IzloZRy6Psaiv/sfj3ceUqmMVwnfqgA5khmjAmv80VfAr2dn8knBwKOncm1tFG SMC3DyDLOYVyEkIQzU3DVZ+PuMh2dx5FkeZPhe3QNeruQYeV5oIJtmm2Ob2T1SYKPLgt 0WgDb/0cZao141YUCt7lT1SOrWBep9yOO64VFm8TlylrwOw6K2/j2YJxJEb0Pzm36M0V +nm+QtUWllZvZuG5aerNtQP+SQmQmMPFjgadB7pKHB3j+rwygwpETClLPHIKFChReCG1 GmkYv72qxfAd9rCA7XCPihEbynyDrEKBFAoxG096AmW/bXPi1hUyFLHQj+p6k8Vz37Dp 68GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=OXr+bS8a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y17si173747edw.191.2021.05.26.12.04.36; Wed, 26 May 2021 12:05:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=OXr+bS8a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235456AbhEZP0I (ORCPT + 99 others); Wed, 26 May 2021 11:26:08 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:57326 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235445AbhEZPZo (ORCPT ); Wed, 26 May 2021 11:25:44 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 14QFO614076951; Wed, 26 May 2021 10:24:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1622042646; bh=y47ptFTk8aLjiI5AFBqywGcPhDmxzelrkQcv54bfk3A=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=OXr+bS8a/T10qsBSE5NKV0OYgjnsLiCYN8KX0lLiiufvzApJhumI4PKtyjetLxxJJ +ijciwbp6QAef/Xm9kOY5mJMgBN6g/KTrNIYOIyO2GbBJ0xJORCUKNyNbcBXLDhioM R5CkEhFfsYr1xukjAzsQWxFxUtkEYp+8JCN7p+Mo= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 14QFO6Jr079220 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 May 2021 10:24:06 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 26 May 2021 10:24:06 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 26 May 2021 10:24:06 -0500 Received: from pratyush-OptiPlex-790.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 14QFN9Ji056314; Wed, 26 May 2021 10:24:01 -0500 From: Pratyush Yadav To: Maxime Ripard , Mauro Carvalho Chehab , Rob Herring , Pratyush Yadav , Kishon Vijay Abraham I , Vinod Koul , Peter Ujfalusi , Steve Longerbeam , Benoit Parrot , , , , , CC: Vignesh Raghavendra , Tomi Valkeinen , Chunfeng Yun , Laurent Pinchart Subject: [PATCH v2 10/18] media: cadence: csi2rx: Populate subdev devnode Date: Wed, 26 May 2021 20:53:00 +0530 Message-ID: <20210526152308.16525-11-p.yadav@ti.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210526152308.16525-1-p.yadav@ti.com> References: <20210526152308.16525-1-p.yadav@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The devnode can be used by media-ctl and other userspace tools to perform configurations on the subdev. Without it, media-ctl returns ENOENT when setting format on the sensor subdev. Signed-off-by: Pratyush Yadav --- (no changes since v1) drivers/media/platform/cadence/cdns-csi2rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c index 1df21f462f3c..49bed63d5faa 100644 --- a/drivers/media/platform/cadence/cdns-csi2rx.c +++ b/drivers/media/platform/cadence/cdns-csi2rx.c @@ -613,6 +613,7 @@ static int csi2rx_probe(struct platform_device *pdev) csi2rx->pads[CSI2RX_PAD_SINK].flags = MEDIA_PAD_FL_SINK; for (i = CSI2RX_PAD_SOURCE_STREAM0; i < CSI2RX_PAD_MAX; i++) csi2rx->pads[i].flags = MEDIA_PAD_FL_SOURCE; + csi2rx->subdev.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; ret = media_entity_pads_init(&csi2rx->subdev.entity, CSI2RX_PAD_MAX, csi2rx->pads); -- 2.30.0