Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <4337451.LvFx2qVVIh@kreacher> <4f0f3e94-d42a-a0fd-ced6-bd1edd6d471b@infradead.org>
In-Reply-To: <4f0f3e94-d42a-a0fd-ced6-bd1edd6d471b@infradead.org>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 26 May 2021 19:12:33 +0200
Message-ID: <CAJZ5v0iVS0YR67M0b6V4p6Bk9gDR_x5YPVB0JYB8jBfQj0eKUw@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: intel_pstate: hybrid: Fix build with CONFIG_ACPI unset
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Chen Yu <yu.c.chen@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, May 26, 2021 at 6:10 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 5/26/21 8:01 AM, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > One of the previous commits introducing hybrid processor support to
> > intel_pstate broke build with CONFIG_ACPI unset.
> >
> > Fix that and while at it fix up empty stubs of two functions related
> > to ACPI CPPC.
> >
> > Fixes: eb3693f0521e ("cpufreq: intel_pstate: hybrid: CPU-specific scaling factor")
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Hi Rafael,
>
> I still have this build error:
>
> ../drivers/cpufreq/intel_pstate.c: In function ‘show_base_frequency’:
> ../drivers/cpufreq/intel_pstate.c:950:10: error: implicit declaration of function ‘intel_pstate_get_cppc_guranteed’; did you mean ‘intel_pstate_get_epp’? [-Werror=implicit-function-declaration]
>   ratio = intel_pstate_get_cppc_guranteed(policy->cpu);

Well, I did too much in this patch, will send an update shortly.

> BTW: s/guranteed/guaranteed/g

Right.