Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 May 2021 13:59:17 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Rob Herring <robh+dt@kernel.org>
CC:     Kishon Vijay Abraham I <kishon@ti.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        PCI <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH] dt-bindings: PCI: ti,am65: Convert PCIe host/endpoint
 mode dt-bindings to YAML
Message-ID: <20210526185917.23icpjsuc37x3pae@slashing>
References: <20210526134708.27887-1-kishon@ti.com>
 <20210526140902.lnk5du5k3b4sny3m@handheld>
 <CAL_Jsq+7AD4WXggRrVVb=HKVmuomda3KVXuC1mcjYwbgnWRUkg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAL_Jsq+7AD4WXggRrVVb=HKVmuomda3KVXuC1mcjYwbgnWRUkg@mail.gmail.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 11:04-20210526, Rob Herring wrote:

[...]

> > > +unevaluatedProperties: false
> >
> > Is it possible to lock this down further with additionalProperties: false?
> 
> unevaluatedProperties is what we want here.
> 
> > I could add some ridiculous property like system-controller; to the
> > example and the checks wont catch it.
> 
> Yes, because unevaluatedProperties is currently unimplemented. Once
> the upstream jsonschema tool supports it[1], there will be warnings.
> The other way we could address this is there are $ref resolving tools
> that flatten schemas.
> 
> [1] https://github.com/Julian/jsonschema/issues/613#issuecomment-636026577


Aha.. Thanks.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D