Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc:     Michael Schmitz <schmitz@debian.org>,
        Roman Zippel <zippel@linux-m68k.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-input@vger.kernel.org
References: <20210526070345.31114-1-rdunlap@infradead.org>
From:   Michael Schmitz <schmitzmic@gmail.com>
Message-ID: <662f3b08-0f28-eda8-82a3-7d29b6474a47@gmail.com>
Date:   Thu, 27 May 2021 07:16:18 +1200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210526070345.31114-1-rdunlap@infradead.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Randy,

On 26/05/21 7:03 pm, Randy Dunlap wrote:
> MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
> depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
> selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.

Right you are! Thanks for spotting this.

Reviewed-by: Michael Schmitz <schmitzmic@gmail.com>

>
> WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
>    Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
>    Selected by [y]:
>    - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
>
> Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michael Schmitz <schmitz@debian.org>
> Cc: Roman Zippel <zippel@linux-m68k.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> ---
>   drivers/input/mouse/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-next-20210525.orig/drivers/input/mouse/Kconfig
> +++ linux-next-20210525/drivers/input/mouse/Kconfig
> @@ -348,6 +348,7 @@ config MOUSE_AMIGA
>   
>   config MOUSE_ATARI
>   	tristate "Atari mouse"
> +	depends on INPUT_KEYBOARD
>   	depends on ATARI
>   	select ATARI_KBD_CORE
>   	help