Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] MOUSE_ATARI: fix kconfig unmet dependency warning
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Randy Dunlap <rdunlap@infradead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Michael Schmitz <schmitz@debian.org>,
        Roman Zippel <zippel@linux-m68k.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-input <linux-input@vger.kernel.org>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>
References: <20210526070345.31114-1-rdunlap@infradead.org>
 <CAMuHMdXdpzmFMSmM+8z9csZ094O5UG6nmAyTYYb=4TAmyUiSnw@mail.gmail.com>
From:   Michael Schmitz <schmitzmic@gmail.com>
Message-ID: <f8718a4f-8338-ef71-53fa-6e1504156ba0@gmail.com>
Date:   Thu, 27 May 2021 07:27:42 +1200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CAMuHMdXdpzmFMSmM+8z9csZ094O5UG6nmAyTYYb=4TAmyUiSnw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

Hi Geert,

On 26/05/21 7:20 pm, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Wed, May 26, 2021 at 9:03 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> MOUSE_ATARI should depend on INPUT_KEYBOARD since ATARI_KBD_CORE
>> depends on INPUT_KEYBOARD. This prevents MOUSE_ATARI from
>> selecting ATARI_KBD_CORE when INPUT_KEYBOARD is not set/enabled.
>>
>> WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
>>    Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
>>    Selected by [y]:
>>    - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
>>
>> Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Thanks for your patch!
>
>> --- linux-next-20210525.orig/drivers/input/mouse/Kconfig
>> +++ linux-next-20210525/drivers/input/mouse/Kconfig
>> @@ -348,6 +348,7 @@ config MOUSE_AMIGA
>>
>>   config MOUSE_ATARI
>>          tristate "Atari mouse"
>> +       depends on INPUT_KEYBOARD
>>          depends on ATARI
>>          select ATARI_KBD_CORE
>>          help
> It looks like arch/m68k/atari/atakeyb.c doesn't use anything from the
> input subsystem, so I think you can move the ATARI_KBD_CORE symbol
> outside the "if INPUT_KEYBOARD" section instead.

Correct - while we're at it, what about moving it to 
arch/m68k/Kconfig.machine?

Cheers,

     Michael

>
> Gr{oetje,eeting}s,
>
>                          Geert
>