Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5561726pxj; Wed, 26 May 2021 13:39:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4lMnFWCbD8fWti5/GIeQOdjZovSOUQNM7QnFFIPh6yzUW9Qp3NxmxP9tphZeUVAvSl94w X-Received: by 2002:a17:906:4704:: with SMTP id y4mr177725ejq.68.1622061554583; Wed, 26 May 2021 13:39:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622061554; cv=none; d=google.com; s=arc-20160816; b=RC+B6e6R0MvQ11of+m1GWmi1D2NeyUv15tIfF0nVZZDh4ucIoj4T7FHGWitzBeFAo5 obPWb8UpM5ZoIuFsAkDi8glSxtaHeDPUjb7oGPSxzeCKkVkENHZOa+hbztDkRGndiFNr GjnYCjx3yCi4SYfRGImPFRuXbfcqdE+wnRN+3jOEjXMgz96lI4cjQHNdlhvBjyAzNwG5 iQO6l7kgaAyUFY5Ja5lZEstxhFbuIK/AuYmBIY2EvqcCk3DlzeD76sM/jaQbx7YYnPa4 ziy3b463INZbspL73IaqFaoQjIlB0hgcgmrlDrODdYZlVfPou75mkpsQeAriMEYnSBhb /aSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=r6STU0lSdqkJZ1l/0zSvxRxB6BYDy9YIUjxLAdeTKfA=; b=YuwvgOqJFTI/N9xVu7CEs+c+0gLlhraYeO3VKXdh4QxyQwmaItln46PvdgAwjyICE5 MdovmEJPnDRC85DIctrfhb0o8+yCXA6DqDfZekJ+mWAVtm72qpVkQZ/7NBpE5j5Uuwz6 EzPo4mBXiWv7Rg/OrCKBWP32Kfx2Sdo74QU6C6k0ZOMY8sV6Y/CMppoC7nt1eijTPU2v JFqYQ+TCzSybIsUhFdc5PJTdEfTA8fTqMP9kOxl4DgKPJo6i/vd/xUmhDpytPknkEzQK G1hs/eWxVJedbsB4OdeWaq6fepcko/IfVOFaf945f0N7NKfqgaddfIsrsuaEXws8PteH VyQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JtKdivv3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n15si145019eje.4.2021.05.26.13.38.47; Wed, 26 May 2021 13:39:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JtKdivv3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233605AbhEZTky (ORCPT + 99 others); Wed, 26 May 2021 15:40:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:52662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231321AbhEZTkv (ORCPT ); Wed, 26 May 2021 15:40:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 61F4A613D3; Wed, 26 May 2021 19:39:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622057959; bh=C1PDxAiFXhmg6+qT5ljIvCqHchzsAkjnDyHZI2utLYI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JtKdivv3C0UX4qKxEHf7gYe/3LBD9kjmLyUwGOvf4VenEMjqGUGBQFyV+3InsabNV RGF0K6P77wG7VECG7kZeygrZOy/Ci1o4wQSTgweNZTGG1LEUWcctsj9R+QXZ0J+NMM kqyu9BklBHqbNmkWkbjy5Qo+251VK/IftrnOtnfNn/jDyOyei0K4J+KYXonYO8D97G k2IvilqmsBkt5k3ffgxMcg56ij5+yc1F/72DALcRA/1nflrF8oRjigPdq94eL1RNEZ I+pCoEiq3DkrUJA2JoTKKFoKE+yr9I1VXa0emdumO+7AOUvKUq1LlFjCoaLFd3Iy+1 MOesh9aB8mvZA== Date: Wed, 26 May 2021 12:39:18 -0700 From: Jakub Kicinski To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Wei Wang , David Miller , netdev@vger.kernel.org, Willem de Bruijn , virtualization@lists.linux-foundation.org, Jason Wang Subject: Re: [PATCH v3 4/4] virtio_net: disable cb aggressively Message-ID: <20210526123918.0aef851d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210526082423.47837-5-mst@redhat.com> References: <20210526082423.47837-1-mst@redhat.com> <20210526082423.47837-5-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 May 2021 04:24:43 -0400 Michael S. Tsirkin wrote: > @@ -1605,12 +1608,17 @@ static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev) > struct netdev_queue *txq = netdev_get_tx_queue(dev, qnum); > bool kick = !netdev_xmit_more(); > bool use_napi = sq->napi.weight; > + unsigned int bytes = skb->len; FWIW GCC says bytes is unused.