Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp5574893pxj; Wed, 26 May 2021 14:03:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO5Pq2DXWTfdGUUdxys8OSaGuRb/lhTS3ec8CXuqD6kbwClTmsX5f2nkKaNL+198Y8Q8Ws X-Received: by 2002:a05:6e02:789:: with SMTP id q9mr233406ils.292.1622063008295; Wed, 26 May 2021 14:03:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622063008; cv=none; d=google.com; s=arc-20160816; b=fdGpzZZY5gvr7IWt/w6IkVYxbj2Z8RVHqXBwBQANClNdzuVUQUmquzr/D5wToM3DNN Yq1nRgqzj02tg/dRoaC258hViJlXOt75EtVRba1jh06vFYpuvMwwkAx2IQwR9mrAxZo7 lfP2/6uuB4Fo2ur+Sc2hUaRxdfWQs0kkXvei5qq096GKDk670r7eAu45JWbU6vr7QnRh gN11kPD1nuVUkpwe9fqNERkqbs/oeRs/YJGBbmn3ZnX0yxwQeLGG2dMMSmbdm78CPhxp Gx95fUi4K3hlEeqB4SBwsuxMTeyTuFNbK2hEtSUWVNlFeqB3dsQS9DbKVotqXIqk6RhO LgMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=l48jC3erVA2+3dsNyPrwjVQi4loUlksxzkUCOK7XbBY=; b=RsOc4pxZBCjWjPWfljB5A8L0rTUwF6zOwzODVyN5fLpFgwfWq90YFagFQSoERSJ1H3 AshOxntQEd5IFGVph5S4F/hUUlJ3ULtypnaQ6zs+5oq8l9d+OsK+kRXkExGy4JFpBMZ/ kM4CNFzp/UPCAe6CrTMFwYLXmMhSk7zrIGNJQ85tV1smLOyIEGP070E2u6Rc/2FHOT26 AVg3IkS0oGTGrrJ+hZykyBvMji3W4T0l385T2U+SpgQX94xDYgBf9wWTF/X04PjQZdvc XYNZoDB80wwZy+WIsS2ZqoVjmUQWEbXApczVGw/kDfnN40MVVqULHnMQ0viRJBb01H/b MDEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KkO4x62i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o19si100424ilt.69.2021.05.26.14.03.04; Wed, 26 May 2021 14:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=KkO4x62i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232832AbhEZU2U (ORCPT + 99 others); Wed, 26 May 2021 16:28:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbhEZU2T (ORCPT ); Wed, 26 May 2021 16:28:19 -0400 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3286C061574 for ; Wed, 26 May 2021 13:26:47 -0700 (PDT) Received: by mail-oi1-x22f.google.com with SMTP id s19so2797926oic.7 for ; Wed, 26 May 2021 13:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=l48jC3erVA2+3dsNyPrwjVQi4loUlksxzkUCOK7XbBY=; b=KkO4x62ipqLrd1vB/3ZYMOoeF6E0oF8Toceds26PSo6RX0C4IJxsuSHLQtScA5IUve xxSogbqN2ttnf503Xc5rqVGuGPwYC3l3mdyAYFaFHzhnNIugTpleG4bgQP9FVupa+gG3 4nQahMZ4ccd9OEegpeReNeb3M2nCo32/bYG4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=l48jC3erVA2+3dsNyPrwjVQi4loUlksxzkUCOK7XbBY=; b=uHSE2uUiwhH5hRVmugOIrdTcA96AoeQJqGrGDTGgej2ulNsSY6xaye0D2CvfoTO+nL 95CWOA6wPg02Byag49g4WCOapyfYVpW7024WUa7rjFBh27xlACj5r9cB+zxtTTNLWZha T99D3zpHijf6Rkf+xmsLWAck4ZFOyNPKy4jyhgEeFCc9SUwopJafOVLsrAie1xR7P35N 0xOqky3D09lrIhzF0/s94N0kA1XWvbGk10GsY6LpW/1MR4yM5J2IVVTEQjHyBw4Hu3va oXN4NRETYSdedF5vZUbkKi0ybTLOmfVKNYqXPeRxAlSV4TKWQH2fWFjPHcmML9WBzWwU 48vQ== X-Gm-Message-State: AOAM531XfByktIArnswV6yZm8FThjz0OdLs0kPIjMyNzTJ+gtB6JCVVw QANvmUtG7n9ocdeo6Un2H+BGrPdXwqA4Qjj3yDIzlQ== X-Received: by 2002:a05:6808:144e:: with SMTP id x14mr3308962oiv.166.1622060807146; Wed, 26 May 2021 13:26:47 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 May 2021 16:26:46 -0400 MIME-Version: 1.0 In-Reply-To: <20210526034500.954219-1-gwendal@chromium.org> References: <20210526034500.954219-1-gwendal@chromium.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Wed, 26 May 2021 16:26:46 -0400 Message-ID: Subject: Re: [PATCH] mfd: cros_ec_dev: Load lightbar module only present To: Gwendal Grignou , bleung@chromium.org, enric.balletbo@collabora.com, groeck@chromium.org, lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Gwendal Grignou (2021-05-25 20:45:00) > The pixel lightbar is only present on chromebook pixel (link), pixel 2 > and pixel C. For the latter two, the EC reports its presence. > Instead of always loading the lightbar driver on all chromebook, only > load it when reported by the EC or Link device. > > Signed-off-by: Gwendal Grignou > --- Tested-by: Stephen Boyd Reviewed-by: Stephen Boyd