Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: HKKgB+h8a3yK+7R/fYCZYdbnOdk7zlWyeuBnGiH0Mtsdjrt09jAnZYQ1smtbsIkmQqyrueLmJb
 sCtaWy1ymIxQ==
IronPort-SDR: B+C9Mk8p7JICAVQrvXzXDmFMaIO7LGs20hUpYkAejRCSFiApi7ahziZVrCEVBNRZiFbYksQhwW
 c8BHhqSY5Ghw==
Subject: Re: [RFC v2 28/32] x86/tdx: Make pages shared in ioremap()
To:     Tom Lendacky <thomas.lendacky@amd.com>,
        Borislav Petkov <bp@alien8.de>
Cc:     Sean Christopherson <seanjc@google.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Tony Luck <tony.luck@intel.com>,
        Kirill Shutemov <kirill.shutemov@linux.intel.com>,
        Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
        Raj Ashok <ashok.raj@intel.com>, linux-kernel@vger.kernel.org,
        Brijesh Singh <brijesh.singh@amd.com>
References: <cover.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <eaaa692ce1ed897f66f864bbfa2df8683768d79e.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com>
 <b884067a-19d6-105f-9f8c-28feb3b43446@intel.com>
 <312879fb-d201-a16d-2568-150152044c54@linux.intel.com>
 <797c95bf-9516-8aee-59d0-f5259d77bb75@linux.intel.com>
 <5b4b4fc0-aaa8-3407-6602-537d59572bc1@intel.com>
 <YJm5QY8omAvdpBO9@google.com> <YJpP/S8MajKNhBl4@zn.tnic>
 <0e233779-9c10-11df-b527-ef61e003ea35@linux.intel.com>
 <YKfPLlulaqwypNkO@zn.tnic> <f5e64c61-7f3c-3936-1b8e-7874ec81d83e@amd.com>
From:   "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@linux.intel.com>
Message-ID: <a53cd108-8758-e153-7ae6-c508fce02003@linux.intel.com>
Date:   Wed, 26 May 2021 14:37:39 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <f5e64c61-7f3c-3936-1b8e-7874ec81d83e@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/21/21 9:19 AM, Tom Lendacky wrote:
> In arch/x86/mm/mem_encrypt.c, sme_early_init() (should have renamed that
> when SEV support was added), we do:
> 	if (sev_active())
> 		swiotlb_force = SWIOTLB_FORCE;
> 
> TDX should be able to do a similar thing without having to touch
> arch/x86/kernel/pci-swiotlb.c.
> 
> That would remove any confusion over SME being part of a
> protected_guest_has() call.

You mean sme_active() check in arch/x86/kernel/pci-swiotlb.c is redundant?

  41 int __init pci_swiotlb_detect_4gb(void)
  42 {
  43         /* don't initialize swiotlb if iommu=off (no_iommu=1) */
  44         if (!no_iommu && max_possible_pfn > MAX_DMA32_PFN)
  45                 swiotlb = 1;
  46
  47         /*
  48          * If SME is active then swiotlb will be set to 1 so that bounce
  49          * buffers are allocated and used for devices that do not support
  50          * the addressing range required for the encryption mask.
  51          */
  52         if (sme_active() || is_tdx_guest())
  53                 swiotlb = 1;


-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer