Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 26 May 2021 15:11:04 +0100
Message-Id: <CBN8KRXT6GKH.3TIZOGGT3RG0W@arch-thunder>
To:     "Lee Jones" <lee.jones@linaro.org>
Cc:     <linux-kernel@vger.kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
        <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 06/24] usb: isp1760: isp1760-udc: Provide missing
 description for 'udc' param
From:   "Rui Miguel Silva" <rui.silva@linaro.org>
References: <20210526130037.856068-1-lee.jones@linaro.org>
 <20210526130037.856068-7-lee.jones@linaro.org>
In-Reply-To: <20210526130037.856068-7-lee.jones@linaro.org>
Precedence: bulk

Hi Lee,
On Wed May 26, 2021 at 2:00 PM WEST, Lee Jones wrote:

> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/usb/isp1760/isp1760-udc.c:150: warning: Function parameter or me=
mber 'udc' not described in 'isp1760_udc_select_ep'
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Rui Miguel Silva <rui.silva@linaro.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/usb/isp1760/isp1760-udc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1=
760-udc.c
> index 3e05e36054357..a78da59d6417b 100644
> --- a/drivers/usb/isp1760/isp1760-udc.c
> +++ b/drivers/usb/isp1760/isp1760-udc.c
> @@ -137,6 +137,7 @@ static void __isp1760_udc_select_ep(struct isp1760_ud=
c *udc,
>  /**
>   * isp1760_udc_select_ep - Select an endpoint for register access
>   * @ep: The endpoint
> + * @udc: Reference to the device controller

I had this in my latest patch set, but got lost, thanks for fixing
this.

I'd like to ask you to swap the order to match the order in which
the args appear in the function declaration.

With this changed you can add my:
Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org>

------
Cheers,
     Rui


>   *
>   * The ISP1761 endpoint registers are banked. This function selects the =
target
>   * endpoint for banked register access. The selection remains valid unti=
l the
> --=20
> 2.31.1