Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v7] mm: slub: move sysfs slab alloc/free interfaces to
 debugfs
To:     Faiyaz Mohammed <faiyazm@codeaurora.org>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        glittao@gmail.com, vinmenon@codeaurora.org
References: <1621928285-751-1-git-send-email-faiyazm@codeaurora.org>
 <YKys873HUNp/ZMqV@kroah.com>
 <7324d56f-c5fe-05fa-55f2-7dd2dbf9bce0@codeaurora.org>
 <YKzlia5b/vaDaul9@kroah.com> <371e20a8-6b07-1eaa-d587-3b444d03ba2f@suse.cz>
 <544e7eaf-ceaa-0ff0-15c3-b615db7e1b00@codeaurora.org>
From:   Vlastimil Babka <vbabka@suse.cz>
Message-ID: <0d39e26f-b641-e142-6c90-7f4bcf91fc21@suse.cz>
Date:   Wed, 26 May 2021 17:07:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.2
MIME-Version: 1.0
In-Reply-To: <544e7eaf-ceaa-0ff0-15c3-b615db7e1b00@codeaurora.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/26/21 5:06 PM, Faiyaz Mohammed wrote:
>> How about simply replicating the empty function in
>> include/linux/slab_def.h
>> 
> Yes, we can add empty function in include/linux/slab_def.h.
> I will add in next patch version.
> 
>> We could do the same with SYSFS, except the SLAB (and SLUB w/o SYSFS) versions
>> of sysfs_slab_release() would not be empty, but just call
>> slab_kmem_cache_release(s);
>> Then we could get rid of the #ifdef's completely?
>> 
> Is it okay, if I raise separate patch for sysfs by adding empty function
> in slab_def.h?

Yeah that would be cleaner. Thanks.

> Thanks and regards,
> Mohammed Faiyaz
>>> greg k-h
>>>
>> 
>