Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Tammana, Gowtham" <g-tammana@ti.com>
To:     Tony Lindgren <tony@atomide.com>, "Anna, Suman" <s-anna@ti.com>
CC:     "bcousson@baylibre.com" <bcousson@baylibre.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "Strashko, Grygorii" <grygorii.strashko@ti.com>,
        "Menon, Nishanth" <nm@ti.com>
Subject: RE: [EXTERNAL] Re: [PATCH] ARM: dts: DRA7x: Fix duplicate USB4 device
 node
Thread-Topic: [EXTERNAL] Re: [PATCH] ARM: dts: DRA7x: Fix duplicate USB4
 device node
Thread-Index: AQHXTob/r6XIvLZ62EiiRlopKG8wt6rzGHyAgAD8fACAAfUYsA==
Date:   Wed, 26 May 2021 17:23:28 +0000
Message-ID: <8e9a178380914fc4bc9f7cef5f9d84f9@ti.com>
References: <20210521211851.14674-1-g-tammana@ti.com>
 <9445e5c9-819c-0aed-f96f-b1ac2ea7d13e@ti.com> <YKyY7mYkNCHIrgSm@atomide.com>
In-Reply-To: <YKyY7mYkNCHIrgSm@atomide.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk


>-----Original Message-----
>From: Tony Lindgren <tony@atomide.com>
>Sent: Tuesday, May 25, 2021 1:28 AM
>
>* Suman Anna <s-anna@ti.com> [210524 15:24]:
>> This can be fixed in couple of different ways, and I see there have been
>> different commits that have ultimately caused this.
>>  6b14eb4705d6 ("ARM: dts: DRA7: Move USB_OTG 4 to dra74x.dtsi")
>>  549fce068a31 ("ARM: dts: dra7: Add l4 interconnect hierarchy and ti-
>sysc data"
>>  bcbb63b80284 (ARM: dts: dra7: Separate AM57 dtsi files")
>>  c7b72abca61e ("ARM: OMAP2+: Drop legacy platform data for dra7 dwc3")
>>
>> Would you prefer that we just drop the USB4 target-module reference in
>> dra7-l4.dtsi following the first commit?
>
>Looking at commit 549fce068a31 above, we have dra7-l4.dtsi define a module
>at 0x48940000. But maybe the module is only used for dwc on dra74x?
>
>If this controller instance is on all dra7 SoCs, then it should be in
>dra7-l4.dtsi. If the controller instance is only on dra74x, it should be
>only in dra74x.dtsi file.
>
>Sorry sounds like I have confused some hardware differences along the
>way.

Thanks for the review. The controller instance is seen only in dra74x, push=
ed
a v2 based on the above suggestion.

Thanks,
Gowtham