Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp96090pxj; Wed, 26 May 2021 17:16:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhLwKloWaj1zNb9W59ZpjO59ngG4yu2CbNXAq9/I0OPbbpo21Y61RxN6cuuWR3aeSBk9rn X-Received: by 2002:a05:6402:190e:: with SMTP id e14mr956350edz.146.1622074571571; Wed, 26 May 2021 17:16:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622074571; cv=none; d=google.com; s=arc-20160816; b=uTo1SH5EikZmQcG1AZomw1qrpe16Qp+R7zO+6vc4sIzLLkwDxW156RaaaT6AvE85Es sAqxj+q8XRRdSQW9NGlwn/CiKMJrWjBNisy96XynWAxwg5jbgh2PoVkP5IveOrD/w6jR 6erI62TEKgF1G28ACZvaQcbuvjhWLG209A/TS6KgyZ+G9FddvQcupnBLPCOh5VChKjhk VgWnnspdGmCRCaC5ZmdmgcScZJv4oV2hj/+DWtYpj6TbIcSTnvF04cEyAjqtRCtoDjS1 g6C/gNEGc/KC5+Z4NpphnEmxgaoETjmeKrhcdr0HaHwHoBVCL2Ai11UOtCzeXUpqsUkU HFAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=vj/jhYSkYrKwV/nWkNv3q5h6kn0sLf6/OfU3Zp6fU/w=; b=LdHZvC826iEtkks5LnOZMeVhVKnInwvaXX5Qi0EhE2ZVPA2TC8HJFurDmOgsW85Zkl RfJE+pMu5G+ayAGX+/CKnOf49K0R6ST9RIInUKRLy5HgOzQ19WXTqv2Ut5HF0bqMOR33 TDB1EpnV+zb4M/LdWTJyNE6Ur/d6c2vRJSarUa1RlCnnXAeyI9E1MDAyoUh55Hn31uqK tDUGuGpAdmvaj4qIq00H5QiP3defhbRe8XMiAl8ih/rcEhvxx+sAKhzNEBDYUIxgI36Y G7g3BEhhcXqgAnCOCh4nu9hUOkT9XWlBYAeIm/20sQ3G2m/9J1N5zhMwtjDl7/yDKcv1 GPOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z5si401548edc.206.2021.05.26.17.15.47; Wed, 26 May 2021 17:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233689AbhEZUyf (ORCPT + 99 others); Wed, 26 May 2021 16:54:35 -0400 Received: from foss.arm.com ([217.140.110.172]:49830 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233669AbhEZUyd (ORCPT ); Wed, 26 May 2021 16:54:33 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D1F511D4; Wed, 26 May 2021 13:43:23 -0700 (PDT) Received: from mammon-tx2.austin.arm.com (mammon-tx2.austin.arm.com [10.118.28.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id ED4A23F73B; Wed, 26 May 2021 13:43:02 -0700 (PDT) From: Jeremy Linton To: coresight@lists.linaro.org Cc: mathieu.poirier@linaro.org, suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, alexander.shishkin@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jeremy Linton Subject: [PATCH] coresight: Propagate symlink failure Date: Wed, 26 May 2021 15:40:42 -0500 Message-Id: <20210526204042.2681700-1-jeremy.linton@arm.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the symlink is unable to be created, the driver goes ahead and continues device creation. Instead lets propagate the failure, and fail the probe. Signed-off-by: Jeremy Linton --- drivers/hwtracing/coresight/coresight-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c index 6c68d34d956e..2dc4b0110442 100644 --- a/drivers/hwtracing/coresight/coresight-core.c +++ b/drivers/hwtracing/coresight/coresight-core.c @@ -1392,7 +1392,7 @@ static int coresight_fixup_device_conns(struct coresight_device *csdev) } } - return 0; + return ret; } static int coresight_remove_match(struct device *dev, void *data) -- 2.31.1