Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp165648pxj; Wed, 26 May 2021 19:22:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6W/ilfV2gPdeUMSm0ZgWIS55Zg1ecEfnCVTV7r2KPqDi4Vf10h3PnRQTQTa5YEd+tiM6z X-Received: by 2002:aa7:db08:: with SMTP id t8mr1386625eds.277.1622082126070; Wed, 26 May 2021 19:22:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622082126; cv=none; d=google.com; s=arc-20160816; b=SFW20vgzaLQzYind7y4SO5XqRDPI+XyNYSaG/ZYg2Hf8UgZZ8VypPDBN4EPPO7lRa9 BF0DkARF3Eg+xbxbzzSFZhJszx7IDzwtseetv7NWqNhV3SuCAHq1OJLUggJ/a6eFEu5K I9os8NAG3trpUaLCvMkA1V6+sP0QyE+VoIZCEqvlacCvpnxmDwRYGf7214yilHKPhPw0 7J1OCTHGKCh/4j/4cfQj8/caT0lJ6h8x0rbsIUxXFRs8dKCGdlTMmgi7+zLyB1TiXdbU FZGOd+sUEk69RORoDQd1E6AXKMAzorw9T8BA7vEYuYXZ6qYsluTUa1heMd1o6u7K3eEm XDfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=fpE0wnS0jXdbwvLdWmZhSR/3TeDBKU2v3+hfotKas20=; b=eZYWtmAL4ZtbN6BFcZ1HTfSXIfynhFGqNwxuEk0nBqFRF+urAcjIL1bbs4VB37nOmi juxr15MDQr0Cj9nglKsJbnuS3g6oaHFFW5jzzZDaRw4rM005chNQY1O4u6+dTyrOIBN3 DeEObBdORMXptYRjmYY9e9lP7IzSLOfHvuBZ6ibbXjpiyoxFBYhFxf1nS3NnAZ2L5STg oQICXJS9OvY0EcaRogsuLEGJj/W3tGYjKPhY2nXx/vjdyA029YwKbKRrWgTe4H9VnQ6a Z11MGUky2zfXK5GEFRpSpaWAh5DjDRLnPXa2R/SuDXTk/N8ICc3tKl6kT0KZQzEA54vI xEcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f12si780048edx.197.2021.05.26.19.21.39; Wed, 26 May 2021 19:22:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233414AbhE0Bsf (ORCPT + 99 others); Wed, 26 May 2021 21:48:35 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:5563 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232006AbhE0Bsf (ORCPT ); Wed, 26 May 2021 21:48:35 -0400 Received: from dggems705-chm.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Fr9bF3Mx9zjX6g; Thu, 27 May 2021 09:44:09 +0800 (CST) Received: from dggpemm500004.china.huawei.com (7.185.36.219) by dggems705-chm.china.huawei.com (10.3.19.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 27 May 2021 09:47:01 +0800 Received: from [10.174.177.91] (10.174.177.91) by dggpemm500004.china.huawei.com (7.185.36.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 27 May 2021 09:47:01 +0800 Subject: Re: [PATCH -next v2] module: fix build error when CONFIG_SYSFS is disabled To: Jessica Yu CC: , , , References: <20210525105049.34804-1-cuibixuan@huawei.com> From: Bixuan Cui Message-ID: Date: Thu, 27 May 2021 09:47:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.91] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500004.china.huawei.com (7.185.36.219) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/26 20:09, Jessica Yu wrote: >> Fix build error when disable CONFIG_SYSFS: >> kernel/module.c:2805:8: error: implicit declaration of function ‘sect_empty’; did you mean ‘desc_empty’? [-Werror=implicit-function-declaration] >> 2805 |   if (!sect_empty(sechdr) && sechdr->sh_type == SHT_NOTE && >> >> Fixes: 9ee6682aa528 ("module: add printk formats to add module build ID to stacktraces") > > Hm, can't find this commit in the next-20210526 tree. Commit 7685f91fed25 > ("module: add printk formats to add module build ID to stacktraces") > seems to be the correct one. It was my linux-next repository that was abnormal. :-( I re-downloaded it and commit id is 7685f91fed25. Thanks, Bixuan Cui