Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210525125925.112306-1-lambert.q.wang@gmail.com>
 <20210525132035.GA66609@rocinante.localdomain> <CAATamay8WTiJnB=5OLYdFTqVUcRF9LarN6_1Eej3QUgFzWRnkA@mail.gmail.com>
 <20210526181810.GA13052@wunner.de>
In-Reply-To: <20210526181810.GA13052@wunner.de>
From:   Lambert Wang <lambert.q.wang@gmail.com>
Date:   Thu, 27 May 2021 11:52:30 +0800
Message-ID: <CAATamazbYRnTJuPKVt_ypu_PVPXN407dSmo1EyExXHH0aHeyaQ@mail.gmail.com>
Subject: Re: [PATCH] pci: add pci_dev_is_alive API
To:     Lukas Wunner <lukas@wunner.de>
Cc:     "Krzysztof Wilczy??ski" <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, May 27, 2021 at 2:18 AM Lukas Wunner <lukas@wunner.de> wrote:
>
> On Wed, May 26, 2021 at 02:12:38PM +0800, Lambert Wang wrote:
> > The user is our new PCI driver under development for WWAN devices .
> > Surprise removal could happen under multiple circumstances.
> > e.g. Exception, Link Failure, etc.
> >
> > We wanted this API to detect surprise removal or check device recovery
> > when AER and Hotplug are disabled.
>
> You may want to take a look at pci_dev_is_disconnected().
>
> Be aware of its limitations, which Bjorn has already pointed out
> and which are discussed in more detail under the following link
> in the "Surprise removal" section:
>
> https://lwn.net/Articles/767885/
>

Thanks for the suggestion and the article. Currently I prefer
pci_device_is_present() for my scenario.

e.g. pci_dev_is_disconnected() seems to use a cached value. If the
driver wants to check the device's absence
after it *senses* something abnormal, pci_device_is_present() is more suitable.

> Thanks,
>
> Lukas