Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp251312pxj; Wed, 26 May 2021 22:14:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw6cNr335/Zy5q0TtxhBcoEsoUc78QMRs+c6GAiPs6dxjfzab1OFmngUQ3llttMOPZ7h4oX X-Received: by 2002:a05:6e02:1088:: with SMTP id r8mr1587110ilj.76.1622092492258; Wed, 26 May 2021 22:14:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622092492; cv=none; d=google.com; s=arc-20160816; b=DZNjM2nrxQUhlPzfu6E0pfn4Nlek5y90VfL+AVfktd0ieSWA4MQtehrksEjMvSoCDc 3HlTDi3KK9xZfUqTHslcl8lc2JvXVNdbpBviebcYOMazwtVzNqT9thUoROAoNl5cQvuj oVhPXo13vNffPTqrI4NRnzDTSvs6PuJG32lYwNCmIA0CR7B3JauF90yrVvtA7joC3krF PpZyf/be5LONpdtoMFWQeXb97Sp933w48Vw8zHJ6IaN/okPUkcWDq36Iy7yZvokHAHpB AvPsJc0Ioa3REHVfyR7kV2D7s3UXBl/Zf5/lyaUrSlkqoqB7YUUggMnvxO0OYjZMS62Q FNvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=iNP/SjcyNaIT9Sh+6s8gT1hO3S0wd0g5pCSpuyaozkw=; b=b9Lc/8ukdEwGcp5avkmXx+0drP/LnLJ6S/C4Rrk2EsIwiMv8Dc6ovA27lppUPNjbkB xsaYWe0ROQYSLiiTkrc9wuPhc+3eKHhYLrMSbgBeOZOcvnBNiWD58Sk7uIF27qaVAa9p /h9gwoDVvxMxK9Px0/weTpGaBw8YNUHqZ+XdRkRM1X1fH79ab9hXPYNd3sHmKhvybf4B dDa7x7FuH1eNPmScNwIjWKW15QodpW8nuruzxbKe6uNZ7354frwZCWFrRlhCzlxIpGqs PKZSh4Ogtgn2ke2PmveUh1Xb7MZSUGs1ueSixsHYkoz+6m92k8U9nJycGaJ1OqnD5apq sobw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PVk7nItG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k10si1159829iow.62.2021.05.26.22.14.38; Wed, 26 May 2021 22:14:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PVk7nItG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233847AbhE0Cri (ORCPT + 99 others); Wed, 26 May 2021 22:47:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233841AbhE0Crh (ORCPT ); Wed, 26 May 2021 22:47:37 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4077C061574 for ; Wed, 26 May 2021 19:46:04 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id f22so2581129pgb.9 for ; Wed, 26 May 2021 19:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iNP/SjcyNaIT9Sh+6s8gT1hO3S0wd0g5pCSpuyaozkw=; b=PVk7nItGG9eUgo1RgIty5RHK8WNgpUKygbC/XyLZ+bCNVUctQeKddIwv7nwuobMJmp 4QWL/b0oxWQqzgu+n3GXsD3vybSuW/8pNpqIO3Reg/9YYX53Q9at+2q9yWKllwV9rOWS w8SGJ+mCBoQYkmnaPb3fmb3D3KWBgiFlM4S1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iNP/SjcyNaIT9Sh+6s8gT1hO3S0wd0g5pCSpuyaozkw=; b=qKKhmdrLkTjwpQ3SPCG/v3whaCuAVqFto0OQp681D4F8VT3Cf6Ahii/faLDZwqCpS8 /YFL9SHQgXRsHc+Sq3n4x2/n5nQcToOp0uXQdE52PvUxlJVf2gP1kNmdFO/1j16mwWCS G7LaQcQTe10Zxv+ZKfIDNeEmTrN8y6rtCl+SbtI114LDZxwzagWVLb3E8txiga/v1LnR Ud56uhZZUUfW1rDxzbnv7NUacn+SwHEtRoAHQ7x7lpaOGzulYnzA+rXQslEC1xxBIS2K HUZ4i52VDJJpwVizmkrenrz6jn6sTfn0xu5H4ZOFzwLUOUE1Ke+2dT39nfyZBIaMXp+e cYfg== X-Gm-Message-State: AOAM533oYBqlARXcpl6+Qr+PUaMqg/CZknr+VBAh8OzyzA8z5XpslSCI XLAiyGhwSXhjCZ/1FRQdFDtCSQ== X-Received: by 2002:a63:5a01:: with SMTP id o1mr1563433pgb.313.1622083564242; Wed, 26 May 2021 19:46:04 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id k38sm350372pgi.73.2021.05.26.19.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 May 2021 19:46:03 -0700 (PDT) From: Kees Cook To: Tycho Andersen , containers@lists.linux.dev, Sargun Dhillon , Andy Lutomirski , LKML Cc: Kees Cook , Rodrigo Campos , =?UTF-8?q?Mauricio=20V=C3=A1squez=20Bernal?= , Christian Brauner , Giuseppe Scrivano , =?UTF-8?q?Micka=C3=ABl=20Sala=C3=BCn?= Subject: Re: [PATCH v2 0/4] Atomic addfd send and reply Date: Wed, 26 May 2021 19:43:59 -0700 Message-Id: <162208342966.3725800.17683913220837738980.b4-ty@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210517193908.3113-1-sargun@sargun.me> References: <20210517193908.3113-1-sargun@sargun.me> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 May 2021 12:39:04 -0700, Sargun Dhillon wrote: > This is somewhat of a respin of "Handle seccomp notification preemption" > but without the controversial parts. > > > This patchset addresses a race condition we've dealt with recently with > seccomp. Specifically programs interrupting syscalls while they're in > progress. This was exacerbated by Golang's recent adoption of "async > preemption", in which they try to interrupt any syscall that's been running > for more than 10ms during GC. During certain syscalls, it's non-trivial to > write them in a reetrant manner in userspace (socket). > > [...] Thanks for your patience on this series! I think this is a clear solution for the race. Applied to for-next/seccomp, thanks! [1/4] Documentation: seccomp: Fix user notification documentation https://git.kernel.org/kees/c/1e2ca403fa89 [2/4] seccomp: Refactor notification handler to prepare for new semantics https://git.kernel.org/kees/c/6a1e0616acde [3/4] seccomp: Support atomic "addfd + send reply" https://git.kernel.org/kees/c/ba9ef89cf83e [4/4] selftests/seccomp: Add test for atomic addfd+send https://git.kernel.org/kees/c/75c98a0d5d3a -- Kees Cook