Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp325190pxj; Thu, 27 May 2021 00:40:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqjjkK5L9VQAQDTNCJVjrRA7u8X7ygV7R0+DLG5Yx5r/4bAnsaDrWcfIOvz5r7OrkGCkjN X-Received: by 2002:a92:d4c7:: with SMTP id o7mr1976505ilm.130.1622101228392; Thu, 27 May 2021 00:40:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622101228; cv=none; d=google.com; s=arc-20160816; b=yXgj3Yl0dJTFedzebg/u8R6UUSbZvt/IoBGruR9T1B9IUOl19lh9ohEFG8NdYGtwp5 mTs0k1DtEjqWUFOY+BBbgx2ZwE3qlm/OLqcTiWvevHMl1RpccCeMJUp3WM7l2buUb5IP so9DOhh9/70T0SLF5yxAnOmM8QT80cx+3+aD07NO7yUAKKbjm41rpjPrahbCICJK6juT +6Ups7+/DbM/rRHHYIYnEjlKWOmqkZXKiK1dJEGJbHRLuOw9tZQKmfJhN4mtJ6XO4nyb bXYUdVEn1IJ/8IYaS9kimX1LwJSXU4QLZGuySqypKoq0bQvRqhIkl3Yvx7q776xOXshV nf3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GYt500bVx/Dyi/n6BF6iwP/37enfzf4TLvbEGeJHSYQ=; b=kiDvFo6hiRScR8SBpQqiX1WEyXxijNTaVVlsMQX8j7oJrGCI9bTnlrrqj1Wzg12dmJ aU0Rdd3SuxP94ZYYMR79eVdQV3/M9urMQTojUIy2OldGKV+RNRSjrQKBiQVKrqC0FvlI G6gIF/o6s91vYis9Y4msMNSgsVo99Ub7H8XWdDCIv1KwFhLwVmvI3QqJVckk9RqBlZ9I aROq34Y+ka5Wi5+EQRe1TTn0Yyh8JM/gRJjxWVDjR2dCpupFSqJLuH5BHWmObho4N+BH L3Pb9YZdy8of/eVaPPx5wtHAEk+kW4lTnPbcX+qnezkrnV51TZMFP3MfVqZEi8ucxJ/P e1QQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q15si1853802jar.110.2021.05.27.00.40.13; Thu, 27 May 2021 00:40:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234985AbhE0HP5 (ORCPT + 99 others); Thu, 27 May 2021 03:15:57 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:36000 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234521AbhE0HPz (ORCPT ); Thu, 27 May 2021 03:15:55 -0400 Received: from localhost (unknown [192.168.167.235]) by lucky1.263xmail.com (Postfix) with ESMTP id 1D9A2D1892; Thu, 27 May 2021 15:14:21 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P31748T140095126476544S1622099649869875_; Thu, 27 May 2021 15:14:11 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <94ac37adb4dfa438bda265326c85f1ca> X-RL-SENDER: jay.xu@rock-chips.com X-SENDER: xjq@rock-chips.com X-LOGIN-NAME: jay.xu@rock-chips.com X-FST-TO: heiko@sntech.de X-RCPT-COUNT: 7 X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 From: Jianqun Xu To: heiko@sntech.de, linus.walleij@linaro.org, robh+dt@kernel.org Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jianqun Xu Subject: [PATCH v5 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Date: Thu, 27 May 2021 15:14:08 +0800 Message-Id: <20210527071408.1424603-1-jay.xu@rock-chips.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210527071239.1424430-1-jay.xu@rock-chips.com> References: <20210527071239.1424430-1-jay.xu@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock. Reviewed-by: Heiko Stuebner Signed-off-by: Jianqun Xu --- drivers/gpio/gpio-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 048e7eecddba..c9c55614bbef 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) irq_set_handler_locked(d, handle_level_irq); raw_spin_lock_irqsave(&bank->slock, flags); - irq_gc_lock(gc); level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type); polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity); @@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type); rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity); out: - irq_gc_unlock(gc); raw_spin_unlock_irqrestore(&bank->slock, flags); return ret; -- 2.25.1