Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp333467pxj; Thu, 27 May 2021 00:57:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9ZBonRftzVdb6TyLlMRDTm1mecUDORwVZdz2EDOtxprOfpq9koeeSmbYDoFU8iVEEjhiT X-Received: by 2002:a02:c912:: with SMTP id t18mr2239656jao.100.1622102265315; Thu, 27 May 2021 00:57:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622102265; cv=none; d=google.com; s=arc-20160816; b=A6O8POJZo4Ji/LGFQ56pdG5XrTEHfwwTzjs93cDOk7VNuzA5NPw2fJl3gPKuJ529ap TV++weekJaeVwd8BEfR9HzKk/JKpCgLbqJdzm7zxunifoFD6GcFYxL6LZ2PGZ4RKCPUh /S+s6GCc0sK61NHKh3pvo/U5QpXGgOBDgY2h5IH1LEkiW8wTUKy5VVyexdIeA8YNUoVh 23Y6fzrBVnyqbWQO1IGjvu/qN/vQ7ZrefV539XxfqAX9onx2SBSV6lgqZbdTI106SNxX qDSb+iFgUYsd/ZalAphcD3edSYq1kcA5w/bHN12bS8yFZuW3EBFKzpImGqCodIwdrnNC w/Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VZUPXREZ1PjKj1d2Hxat9QQw1N2e9nbL6sFWBfS1Vpw=; b=ifPF51yzlZFLlgP0zzV4HhjfVhGY0Wk8wyMb+vaCul9s2P31IouIxTZTUeolie2em3 4Fr289vPTLL/m7Zre4MtNQu1c6WUSOMcTKw/ViCXg3N4TOgAgpwCdu0sPrJQGv+SLQIV OEmgdROIasnbDtg88iELXvUS7IYw96oaW8WYpw+jYB4QcqsQHU8qGsGbxBwO+Jl4MwGb QWF7F28d+57DLJzHzy0IFMwcARlAzcYOlK+xrF89oq5/jxE4yx3MVXA9UoVC/9i39XIH 5JiZNMMpMJIjIntjn9EFDOyCO2KwITREX6+UOHWYp08bie2IaUVztjFoL4d19k1fbeHC G0Ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HhR2Z+UR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z22si1702354iof.57.2021.05.27.00.57.32; Thu, 27 May 2021 00:57:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=HhR2Z+UR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235295AbhE0H6N (ORCPT + 99 others); Thu, 27 May 2021 03:58:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235068AbhE0H5h (ORCPT ); Thu, 27 May 2021 03:57:37 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B1A3C06138B for ; Thu, 27 May 2021 00:56:05 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id ot16so2275722pjb.3 for ; Thu, 27 May 2021 00:56:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VZUPXREZ1PjKj1d2Hxat9QQw1N2e9nbL6sFWBfS1Vpw=; b=HhR2Z+UR/b0SShfqRiDIqIeE9XVO40D7x12Ut0QL5fW0cu5OdPFV9MLpkYra2tKOeG SZMsmj2c++8KLKom7kTzirRKt2eHGZbxXvFJrFmUTZdB+sfx/I7LEIPg+5LQKFXgPZax SotQId1UeMa8u1Kppg+8CkVd/TwF+ppbFN3aM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VZUPXREZ1PjKj1d2Hxat9QQw1N2e9nbL6sFWBfS1Vpw=; b=AXPWsTwXyP0vM1ju8qKkyfKCVh7O3XwW54Ge43JZrEtHSpaEnDhHZachU2TR9Zz1J0 7tMqolpDloWfIi5JyPE9ShXBCeL8gq2y+wVeDqi+Q/Uk1+pMcXCc33C2cCZIMZ5L9M9u mCiT935QoM0iExXqFds3WIkl9MDj404DyP0jSAqJ98rHEiwEVBjBT3mTl7J0M9CwAAPM WsEy4HWxkgVjbXxtJ+LrWXLOpym8uNHtygNGvL6dH0sFbqTICFY4FBuCRl+yjzZFUChy 5yI1O+l5hiJ5dkoCEXWkTMWY8jfN+1fREyvtpxI/9AOB5YsiqXl36+tvIHhY6CR5PaOd +8/Q== X-Gm-Message-State: AOAM531c7+KAU3nuCPL6PG2YSl+8W9HroXoMWy5HBiqZXnm938IGNXvQ Y0kjExCTKtyTgwdYgBOLgJejCQ== X-Received: by 2002:a17:90a:7bcc:: with SMTP id d12mr8385514pjl.230.1622102164520; Thu, 27 May 2021 00:56:04 -0700 (PDT) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:ece5:55a4:6ad3:d20f]) by smtp.gmail.com with ESMTPSA id 69sm1217790pfx.115.2021.05.27.00.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 May 2021 00:56:04 -0700 (PDT) From: Hsin-Yi Wang To: Wolfram Sang , Matthias Brugger , Jean Delvare , Rob Herring , Bartosz Golaszewski Cc: linux-i2c@vger.kernel.org, Qii Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Mark Brown , Marek Szyprowski , Bibby Hsieh , Arnd Bergmann Subject: [PATCH v21 RESEND 1/4] i2c: core: support bus regulator controlling in adapter Date: Thu, 27 May 2021 15:55:53 +0800 Message-Id: <20210527075556.1709140-2-hsinyi@chromium.org> X-Mailer: git-send-email 2.31.1.818.g46aad6cb9e-goog In-Reply-To: <20210527075556.1709140-1-hsinyi@chromium.org> References: <20210527075556.1709140-1-hsinyi@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bibby Hsieh Although in the most platforms, the bus power of i2c are alway on, some platforms disable the i2c bus power in order to meet low power request. We can control bulk regulator if it is provided in i2c adapter device. Signed-off-by: Bibby Hsieh Signed-off-by: Marek Szyprowski Signed-off-by: Hsin-Yi Wang Reviewed-by: Matthias Brugger --- drivers/i2c/i2c-core-base.c | 95 +++++++++++++++++++++++++++++++++++++ include/linux/i2c.h | 2 + 2 files changed, 97 insertions(+) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 5a97e4a02fa2..23bc7c269184 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -461,12 +461,14 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client) static int i2c_device_probe(struct device *dev) { struct i2c_client *client = i2c_verify_client(dev); + struct i2c_adapter *adap; struct i2c_driver *driver; int status; if (!client) return 0; + adap = client->adapter; client->irq = client->init_irq; if (!client->irq) { @@ -532,6 +534,14 @@ static int i2c_device_probe(struct device *dev) dev_dbg(dev, "probe\n"); + if (adap->bus_regulator) { + status = regulator_enable(adap->bus_regulator); + if (status < 0) { + dev_err(&adap->dev, "Failed to enable bus regulator\n"); + goto err_clear_wakeup_irq; + } + } + status = of_clk_set_defaults(dev->of_node, false); if (status < 0) goto err_clear_wakeup_irq; @@ -589,8 +599,10 @@ static int i2c_device_probe(struct device *dev) static int i2c_device_remove(struct device *dev) { struct i2c_client *client = to_i2c_client(dev); + struct i2c_adapter *adap; struct i2c_driver *driver; + adap = client->adapter; driver = to_i2c_driver(dev->driver); if (driver->remove) { int status; @@ -605,6 +617,8 @@ static int i2c_device_remove(struct device *dev) devres_release_group(&client->dev, client->devres_group_id); dev_pm_domain_detach(&client->dev, true); + if (!pm_runtime_status_suspended(&client->dev) && adap->bus_regulator) + regulator_disable(adap->bus_regulator); dev_pm_clear_wake_irq(&client->dev); device_init_wakeup(&client->dev, false); @@ -617,6 +631,86 @@ static int i2c_device_remove(struct device *dev) return 0; } +#ifdef CONFIG_PM_SLEEP +static int i2c_resume_early(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + int err; + + if (!client) + return 0; + + if (pm_runtime_status_suspended(&client->dev) && + client->adapter->bus_regulator) { + err = regulator_enable(client->adapter->bus_regulator); + if (err) + return err; + } + + return pm_generic_resume_early(&client->dev); +} + +static int i2c_suspend_late(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + int err; + + if (!client) + return 0; + + err = pm_generic_suspend_late(&client->dev); + if (err) + return err; + + if (!pm_runtime_status_suspended(&client->dev) && + client->adapter->bus_regulator) + return regulator_disable(client->adapter->bus_regulator); + + return 0; +} +#endif + +#ifdef CONFIG_PM +static int i2c_runtime_resume(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + int err; + + if (!client) + return 0; + + if (client->adapter->bus_regulator) { + err = regulator_enable(client->adapter->bus_regulator); + if (err) + return err; + } + + return pm_generic_runtime_resume(&client->dev); +} + +static int i2c_runtime_suspend(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + int err; + + if (!client) + return 0; + + err = pm_generic_runtime_suspend(&client->dev); + if (err) + return err; + + if (client->adapter->bus_regulator) + return regulator_disable(client->adapter->bus_regulator); + return 0; +} +#endif + +static const struct dev_pm_ops i2c_device_pm = { + SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late, i2c_resume_early) + SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL) +}; + static void i2c_device_shutdown(struct device *dev) { struct i2c_client *client = i2c_verify_client(dev); @@ -674,6 +768,7 @@ struct bus_type i2c_bus_type = { .probe = i2c_device_probe, .remove = i2c_device_remove, .shutdown = i2c_device_shutdown, + .pm = &i2c_device_pm, }; EXPORT_SYMBOL_GPL(i2c_bus_type); diff --git a/include/linux/i2c.h b/include/linux/i2c.h index e8f2ac8c9c3d..953a4eecb88f 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -15,6 +15,7 @@ #include /* for struct device */ #include /* for completion */ #include +#include #include #include /* for Host Notify IRQ */ #include /* for struct device_node */ @@ -729,6 +730,7 @@ struct i2c_adapter { const struct i2c_adapter_quirks *quirks; struct irq_domain *host_notify_domain; + struct regulator *bus_regulator; }; #define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev) -- 2.31.1.818.g46aad6cb9e-goog