Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp343568pxj; Thu, 27 May 2021 01:15:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpfSBPgGe0FhBNRqlvpN1juCh6iJsYLvsgDrkzGsmqkjzXD9QSJgW79aJi5uaFUfXgRd5Q X-Received: by 2002:a17:906:14d9:: with SMTP id y25mr935040ejc.523.1622103310761; Thu, 27 May 2021 01:15:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622103310; cv=none; d=google.com; s=arc-20160816; b=ry3ClhWSdZMl3M7qki48zum240xJpVHFm3wXqiS637+iI3nMwNcmrgTqwynBcWx2U/ YURzs6+uuJ23E7tJS8/ljeXmQBFChQ1+NIC+Ah4EoU+WP4twQ5lL14j2zwNFv40IJ/1f ci2GmcgtQpPyrZZE2yCR866aDGHLVFx4TezJW17ZGtYOca9tTFAmYKC02d2KgGS9GfA4 AGO8g75XWTD46tzxlYzxxcjsE3EEok90BanwsKZvxGwRd4bVy2+DAkh1w29jsq7I/75p C14uUsA4l0q09/np1mr83Y/0WbpBz3aiNPOAXo+7r12nive6FLEoTNczA5Z67hKimQpJ uJMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vT74XKRQuhUfgLTtwSOq9b0Z9WdSrSMbTGF3sw2pf4s=; b=mLmvvctR24+esZ8fkU3+lKCtikHFcjg3vRjoYLyjPiiphEEBYK9e84Zsf+e9w8apPT g6ptNXqeZO45QjMp0YuttbgRuIlZPtHA4synuBLFRGlIeXpfvLPxAODuVNqhANYQNWVB UJGWW6FfBYnin0jH91LIECfSX9EVoQ/LQQMsolMaNtfQnm6hgP+7J1iPZE2b8NMRGVIw hY8pEglgSCiKjMz5GIAw5PIDOX1ZWysCZrpTJH9648CbUjKcohv835jdGpAynrA2RI7R Gc9YB4TqeKztwsGCvntj5uv0eq7UnD60JhpsylgQ1LVSiLQSsvxcaf28xyEYtgeO2i2E LRsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=fm1v8qYS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v7si1868853edd.219.2021.05.27.01.14.45; Thu, 27 May 2021 01:15:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=fm1v8qYS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235156AbhE0IMj (ORCPT + 99 others); Thu, 27 May 2021 04:12:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbhE0IMi (ORCPT ); Thu, 27 May 2021 04:12:38 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF2B4C061574; Thu, 27 May 2021 01:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vT74XKRQuhUfgLTtwSOq9b0Z9WdSrSMbTGF3sw2pf4s=; b=fm1v8qYSLk//NA61Wa8uZtqNSz J0lO9IAJT+GN0aRGc52FJmjtq0GlQVFkBK3NA7L44OgjOgusQSJcn3PIkC9Hu2+O7uUBe6r2H1XOz jqHxQ+ewhbQr2dJvcd47dA0aGWjkSqz6XeK2CjAFTRadU32IDtOejSZ1JNo+emJGJrn11WdFGEOL/ o+IJ1Wk+T/j1rm0NSFu6vTlYKTBbOc62eb2af4hqNzp/XbVD0iTENsCOj8xDX8QIlYAUkpEW+xnHp nOvxJilMB3cAEn/a3Pfcg6AcFLfKwRRC4L8qQ0NhtZ0+d/yEwuSzQ2S2hLTOP1ywL/49VxG1w14Py f3SLCeyQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lmB67-005Jn6-PC; Thu, 27 May 2021 08:10:36 +0000 Date: Thu, 27 May 2021 09:10:31 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Vlastimil Babka , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zi Yan , Christoph Hellwig , Jeff Layton Subject: Re: [PATCH v10 07/33] mm: Add folio_get Message-ID: References: <20210511214735.1836149-1-willy@infradead.org> <20210511214735.1836149-8-willy@infradead.org> <88a265ab-9ecd-18b7-c150-517a5c2e5041@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 03:24:26PM +0100, Matthew Wilcox wrote: > On Fri, May 14, 2021 at 01:56:46PM +0200, Vlastimil Babka wrote: > > Nitpick: function names in subject should IMHO also end with (). But not a > > reason for resend all patches that don't... > > Hm, I thought it was preferred to not do that. I can fix it > easily enough when I go through and add the R-b. I hate the pointless (). Some maintainers insist on it. No matter what you do you'll make some folks happy and others not.