Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 May 2021 09:43:53 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Min Li <min.li.xe@renesas.com>
Cc:     "sameo@linux.intel.com" <sameo@linux.intel.com>,
        "grant.likely@linaro.org" <grant.likely@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit
 (SMU) support
Message-ID: <20210527084353.GJ543307@dell>
References: <1619466246-11198-1-git-send-email-min.li.xe@renesas.com>
 <20210519080807.GH805368@dell>
 <OS3PR01MB659398F1C336CA2A03A0A7EABA249@OS3PR01MB6593.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <OS3PR01MB659398F1C336CA2A03A0A7EABA249@OS3PR01MB6593.jpnprd01.prod.outlook.com>
Precedence: bulk

On Wed, 26 May 2021, Min Li wrote:

> > 
> > > +	ret = rsmu_dev_init(rsmu);
> > > +	mutex_unlock(&rsmu->lock);
> > > +
> > > +	if (ret == 0)
> > > +		dev_info(rsmu->dev, "Probe %s successful\n",
> > > +			 rsmu_name(rsmu->type));
> > 
> > No thank you.  Please remove this.
> > 
> Hi Lee
> 
> What is the rule for adding informational log in the driver probe function?

The rule generally is 'don't'.

Especially if it doesn't provide any actual information.

Strings are expensive with regards to binary size.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog