Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp390102pxj; Thu, 27 May 2021 02:40:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjIhvsGMkNc91E1itfUn+EH8Xqz3z9Vug38r/9bv3KiywIFjC2llDi94i92vs2uCrrdi1W X-Received: by 2002:a50:a69b:: with SMTP id e27mr3069378edc.7.1622108447927; Thu, 27 May 2021 02:40:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622108447; cv=none; d=google.com; s=arc-20160816; b=aTcrxRdaofXx6oUBeB+9OZ12noBU/4nFRK93VIkcrnkQG+6EuyXwjQya2P+71MhldS q531xrsY3yRTwjguys1JC803fAy5TbIuqA0ZOYhxi4PAwWlq0r7kPYtnK3jhelAmEOWv TNFOU3u80KzlQB24eZKZySXRmGpfdhMlZVgjnrZ45F7vvpCJjndnXB/jRnrOssQA1uWZ S2ESwqnSWe40mmlvB0Dr9qqXG5y2kB7ZPqfsWBmy6KbQhARL1Too3RfYnBoQrqg1z7nZ 6VhezDXfWqsJhe2HhZFjnpfljM/ptEKVphPFmcgnsGNF6gYt8u7IjNXpboCmCcM5bmf4 Bg/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=YXTOjZGCp77C4e0Lxq7AgCj5jnTSIL2rgFT0woCINvs=; b=09jbaKpoNMrF/CYUPQKgH5H+ybZSRMWUD0oRJB9E57raiPnVVDJxi8/L7bS6EdSvFm hhSDhI71nznHjk2ZpXzauEi5VrteVRFlNEUS3BBbqi6xwara24rVuckV4O3dzs6L/pwq AmYjWr8S0i1XRLCQbBMgQDltp/LvIO9ZUkXtXzjxc/kHZgE87VOZSaML/EGfXrHR5zy/ dN/EBCYoFGbIJPGjFb1gaHeCpaWAfMzFvH8jjSmBYe5aogK0wfbGUhKoI6twpiwZ40CU E49DMIu+nytKgkG5LcrLbQ58NY5VkHI1dTpfpfg/XZWR0RBt+jbcwkFMIS1e87NvhvYo ZvYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h6si1669490ejp.651.2021.05.27.02.40.23; Thu, 27 May 2021 02:40:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235844AbhE0Jih (ORCPT + 99 others); Thu, 27 May 2021 05:38:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:40272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235675AbhE0Jig (ORCPT ); Thu, 27 May 2021 05:38:36 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC6F3610CE; Thu, 27 May 2021 09:37:03 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lmCRp-003uYV-Up; Thu, 27 May 2021 10:37:02 +0100 From: Marc Zyngier To: Zenghui Yu , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Resolve all pending PC updates before immediate exit Date: Thu, 27 May 2021 10:36:58 +0100 Message-Id: <162210811963.2571441.8247846241479651886.b4-ty@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210526141831.1662-1-yuzenghui@huawei.com> References: <20210526141831.1662-1-yuzenghui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 May 2021 22:18:31 +0800, Zenghui Yu wrote: > Commit 26778aaa134a ("KVM: arm64: Commit pending PC adjustemnts before > returning to userspace") fixed the PC updating issue by forcing an explicit > synchronisation of the exception state on vcpu exit to userspace. > > However, we forgot to take into account the case where immediate_exit is > set by userspace and KVM_RUN will exit immediately. Fix it by resolving all > pending PC updates before returning to userspace. > > [...] Applied to fixes, thanks! [1/1] KVM: arm64: Resolve all pending PC updates before immediate exit commit: e3e880bb1518eb10a4b4bb4344ed614d6856f190 with: Fixes: 26778aaa134a ("KVM: arm64: Commit pending PC adjustemnts before returning to userspace") Cc: stable@vger.kernel.org # 5.11 Cheers, M. -- Without deviation from the norm, progress is not possible.