Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 May 2021 13:36:41 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Richard Gong <richard.gong@linux.intel.com>
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        gregkh@linuxfoundation.org, atull@kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] firmware: stratix10-svc: Fix a resource leak in an error
 handling path
Message-ID: <20210527103641.GS1955@kadam>
References: <0ca3f3ab139c53e846804455a1e7599ee8ae896a.1621621271.git.christophe.jaillet@wanadoo.fr>
 <f669ed42-348f-808b-afeb-9528d2ece6ee@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f669ed42-348f-808b-afeb-9528d2ece6ee@linux.intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, May 26, 2021 at 02:13:12PM -0500, Richard Gong wrote:
> >   	dev_set_drvdata(dev, svc);
> >   	pr_info("Intel Service Layer Driver Initialized\n");
> > +	return 0;
> > +
> > +err_put_device:
> > +	platform_device_put(svc->stratix10_svc_rsu);
> > +err_free_kfifo:
> > +	kfifo_free(&controller->svc_fifo);
> 
> Need for the allocated memory pool as well,
> 	if (ctrl->genpool)
>                 gen_pool_destroy(ctrl->genpool);
> 

Good point, but there is no need to check, the genpool is not optional
and the "if (ctrl->genpool)" condition could be deleted from the remove
function as well.

err_put_device:
	platform_device_put(svc->stratix10_svc_rsu);
err_free_kfifo:
	kfifo_free(&controller->svc_fifo);
err_destroy_pool:
	gen_pool_destroy(genpool);

	return ret;

But the other question is what's on with the &svc_ctrl list?  I would
have thought that we needed to remove freed controller from the list as
well, but looking at it now I think the list itself should be removed.
I think there can only be one item in the list at a time.  So we could
just make the controller pointer a file scope global or we could find
some other way to go from the client pointer to the controller pointer.

regards,
dan carpenter