Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nava kishore Manne <navam@xilinx.com>
To:     Moritz Fischer <mdf@kernel.org>
CC:     "trix@redhat.com" <trix@redhat.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Michal Simek <michals@xilinx.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        git <git@xilinx.com>,
        "chinnikishore369@gmail.com" <chinnikishore369@gmail.com>
Subject: RE: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support
Thread-Topic: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support
Thread-Index: AQHW7UWZwDiwSbkqzUWMwmmZwUyntqozISAAgAgZmKCANxU1wIBrXauAgAFH0bCAGPoWwA==
Date:   Thu, 27 May 2021 10:43:30 +0000
Message-ID: <MW4PR02MB733201057C43C9EEC54EF255C2239@MW4PR02MB7332.namprd02.prod.outlook.com>
References: <20210118025058.10051-1-nava.manne@xilinx.com>
 <YApf1jlEghbnDFo/@archbook>
 <MWHPR02MB2623B63A5359BB35B89BF086C2BB9@MWHPR02MB2623.namprd02.prod.outlook.com>
 <BN6PR02MB2612733F9D85ED6A36BBF801C2989@BN6PR02MB2612.namprd02.prod.outlook.com>
 <YJlw5fk0ORhioDb4@epycbox.lan>
 <MWHPR02MB2623E6E6759FA574129901E7C2539@MWHPR02MB2623.namprd02.prod.outlook.com>
In-Reply-To: <MWHPR02MB2623E6E6759FA574129901E7C2539@MWHPR02MB2623.namprd02.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 2
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3l8dwNNOewDhAxdnNtz5vJaDJIiwL5hZbIQfm08ICalXIsCC5Jz2zqakvjOh?=
 =?us-ascii?Q?grMQmnlVlmM0NtPJC/R4fefE2j6QVbAe6AMGSdi2K1rNFeTU8SDFqODBVwQm?=
 =?us-ascii?Q?yqrWN5XwT+H30Womh4JhdAcPe9WerzeXGu/7W3F2OivH+w2CdXcLfmHqA0za?=
 =?us-ascii?Q?FzWe1+UR8yymRJGc+9uFayXxwu+3hrfQ0Ux3ipQwbdGFZWC68YXlPFQ97v5B?=
 =?us-ascii?Q?PL7tDboiS2difoft2nes3kob9EKYFvRHVpEzkENYdQNe4yt/tIt1y91TfUcd?=
 =?us-ascii?Q?6h7YI2VwGvP6UTjv4Bx+8kmqR/R71YAekJ1dOshRPCbwkI3kMxwr8mB4HgbP?=
 =?us-ascii?Q?5hN7n0S9x1Ymz5J0iFtHCeWoH+EuFqZ9XdxJ3bnHKn/qk6jB/ZomGZqphIoJ?=
 =?us-ascii?Q?uXNxHaYxxT0D07EPzAfnIjkbSqYILt6B0m4dT4qVlTg9XhRKSO9qGSrwB71b?=
 =?us-ascii?Q?58WMOvKp33t6wCYETPv3iMNze3BrlyF4YX2/JREQxplUEzTycxYEEBiiHhgC?=
 =?us-ascii?Q?q9Lw4PXv63h94GVb5IE4/qkDsJivaKtKGe02rEenPIYtSf38khsQM5oSEAs5?=
 =?us-ascii?Q?NnOZv4PQuuqFAuuMYGOAuZNRUhnkI7U4rEZZnI22FVpHZuhmVjLcoPvqXBRC?=
 =?us-ascii?Q?UvfWq3j955bUNiipCvLsl3Boemipix1mCwJa94Gx693Y6aU8KBHODHUQ6l9s?=
 =?us-ascii?Q?6ah8VB7i8GaWuPUI2C7UTl2P6NRiIPJIkEN3EPL8wFdo2PoWM8HsHj4qYcbD?=
 =?us-ascii?Q?v+xjFyFUGnWYPvG2TNDzPNBKV2sMrVfBYZttv1Zm4GStAbMIfZG79eV2mCDF?=
 =?us-ascii?Q?iBX0iMKtgPLg30xABNlU4v0qWCoQLiopRxd3S7yfsoO76hfnXO/TRhNV9FAQ?=
 =?us-ascii?Q?WS/vmnCHOCrLAZxfZiU0J4jATHDhWFrX/0BvpTjrzMX5LmgXrQLmYARgfh1t?=
 =?us-ascii?Q?BBZJouQn1AiR0fZQrFxgmc/xEajs2lxJRC5ddLK7?=
x-ms-exchange-antispam-messagedata-1: q3RHf5lpcsxrlVOzlJCMnLH9YOqVlshsXnxhx2bobU+G41cj3oUvAeWj9IlQLPhXrle4OJjFtrpoapcUnVxNeHW1HgTFIe8YoHDEvsLl1Cm7IffaY4jHvMPaPS4fbl/JdK3R8uurotmBmDAmYdt3UmIClaPj0gTXtE3gbKmv7mNAz1R70rA/iTeLtxYFicyAi5hwuctXm6GlVPOW1Bw7PSHY9E2Q5Jc6lo0tPgRrjMqegHsIFoIPVOPrG1uBoYpn8Af9MSirfd4RvOJ7PhvsAqQjVnKarZS3vPgzqy3/NTQzx3diOhVImNDln2yB1yKxv430/w1HzwYB+XokG0JWf2UP
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR02MB7332.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f029725-8a6c-49b2-62a3-08d920fc44e8
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2021 10:43:30.8926
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 511DWmTWM2FYStbi5W2xcgv65yNjGAH74B9iti9NBiO9IvefFWJJipJulIy3xwmaBMAHqEB9O3R0zfO+BzHrPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0201MB3482
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ping!

> -----Original Message-----
> From: Nava kishore Manne <navam@xilinx.com>
> Sent: Tuesday, May 11, 2021 7:02 PM
> To: Moritz Fischer <mdf@kernel.org>
> Cc: trix@redhat.com; robh+dt@kernel.org; Michal Simek
> <michals@xilinx.com>; linux-fpga@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; git <git@xilinx.com>; chinnikishore369@gmail.com
> Subject: RE: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support
>=20
> Hi Moritz,
>=20
> Please find my response inline.
>=20
> > -----Original Message-----
> > From: Moritz Fischer <mdf@kernel.org>
> > Sent: Monday, May 10, 2021 11:14 PM
> > To: Nava kishore Manne <navam@xilinx.com>
> > Cc: Moritz Fischer <mdf@kernel.org>; trix@redhat.com;
> > robh+dt@kernel.org; Michal Simek <michals@xilinx.com>; linux-
> > fpga@vger.kernel.org; devicetree@vger.kernel.org; linux-arm-
> > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git
> > <git@xilinx.com>; chinnikishore369@gmail.com
> > Subject: Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading
> > support
> >
> > On Wed, Mar 03, 2021 at 10:11:51AM +0000, Nava kishore Manne wrote:
> > > Ping!
> > >
> > > > -----Original Message-----
> > > > From: Nava kishore Manne
> > > > Sent: Wednesday, January 27, 2021 2:43 PM
> > > > To: Moritz Fischer <mdf@kernel.org>
> > > > Cc: trix@redhat.com; robh+dt@kernel.org; Michal Simek
> > > > <michals@xilinx.com>; linux-fpga@vger.kernel.org;
> > > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > > linux- kernel@vger.kernel.org; git <git@xilinx.com>;
> > > > chinnikishore369@gmail.com
> > > > Subject: RE: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading
> > > > support
> > > >
> > > > Hi Moritz,
> > > >
> > > > 	Thanks for the review.
> > > > Please find my response inline.
> > > >
> > > > > -----Original Message-----
> > > > > From: Moritz Fischer <mdf@kernel.org>
> > > > > Sent: Friday, January 22, 2021 10:47 AM
> > > > > To: Nava kishore Manne <navam@xilinx.com>
> > > > > Cc: mdf@kernel.org; trix@redhat.com; robh+dt@kernel.org; Michal
> > > > > Simek <michals@xilinx.com>; linux-fpga@vger.kernel.org;
> > > > > devicetree@vger.kernel.org;
> > > > > linux-arm-kernel@lists.infradead.org;
> > > > > linux- kernel@vger.kernel.org; git <git@xilinx.com>;
> > > > > chinnikishore369@gmail.com
> > > > > Subject: Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream
> > > > > loading support
> > > > >
> > > > > On Mon, Jan 18, 2021 at 08:20:57AM +0530, Nava kishore Manne
> > wrote:
> > > > > > This commit adds secure flags to the framework to support
> > > > > > secure BitStream Loading.
> > > > > >
> > > > > > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > > > > > ---
> > > > > >  drivers/fpga/of-fpga-region.c | 10 ++++++++++
> > > > > > include/linux/fpga/fpga-mgr.h | 12 ++++++++++++
> > > > > >  2 files changed, 22 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/fpga/of-fpga-region.c
> > > > > > b/drivers/fpga/of-fpga-region.c index
> > > > > > e405309baadc..3a5eb4808888
> > > > > > 100644
> > > > > > --- a/drivers/fpga/of-fpga-region.c
> > > > > > +++ b/drivers/fpga/of-fpga-region.c
> > > > > > @@ -228,6 +228,16 @@ static struct fpga_image_info
> > > > > *of_fpga_region_parse_ov(
> > > > > >  	if (of_property_read_bool(overlay, "encrypted-fpga-config"))
> > > > > >  		info->flags |=3D FPGA_MGR_ENCRYPTED_BITSTREAM;
> > > > > >
> > > > > > +	if (of_property_read_bool(overlay, "userkey-encrypted-fpga-
> > > > > config"))
> > > > > > +		info->flags |=3D
> > > > > FPGA_MGR_USERKEY_ENCRYPTED_BITSTREAM;
> > > > >
> > > > > Can this just be encrypted-fpga-config/FPGA_MGR_ENCRYPTED?
> > > >
> > > > In Encryption we have two kinds of use case one is Encrypted
> > > > Bitstream loading with Device-key and Other one is Encrypted
> > > > Bitstream loading with User-key. To differentiate both the use
> > > > cases this
> > Changes are needed.
> > > >
> > > > Regards,
> > > > Navakishore.
> >
> > Is this region specific, or could this be a sysfs attribute?
> >
>=20
> These changes are region specific.
>=20
> Regards,
> Navakishore.