Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 27 May 2021 14:59:29 +0300
From:   Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To:     Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
        Matti Vaittinen <mazziesaccount@gmail.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
        linux-kernel@vger.kernel.org, linux-power@fi.rohmeurope.com,
        Lee Jones <lee.jones@linaro.org>
Subject: [PATCH] regulator: bd70528: Drop BD70528 support
Message-ID: <d7271362129edceebc512b49efed9ee7c3efcb6a.1622116622.git.matti.vaittinen@fi.rohmeurope.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt"
Content-Disposition: inline
Precedence: bulk


--pf9I7BMVVzbSWLtt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The only known BD70528 use-cases are such that the PMIC is controlled
=66rom separate MCU which is not running Linux. I am not aware of
any Linux driver users. Furthermore, it seems there is no demand for
this IC. Let's ease the maintenance burden and drop the driver. We can
always add it back if there is sudden need for it.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
This was previously a part of the series here:
https://lore.kernel.org/lkml/cover.1621937490.git.matti.vaittinen@fi.rohmeu=
rope.com/

 drivers/regulator/Kconfig             |  11 -
 drivers/regulator/Makefile            |   1 -
 drivers/regulator/bd70528-regulator.c | 278 --------------------------
 3 files changed, 290 deletions(-)
 delete mode 100644 drivers/regulator/bd70528-regulator.c

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 9aeb32c320aa..bc02ea3ea2ef 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -193,17 +193,6 @@ config REGULATOR_BCM590XX
 	  BCM590xx PMUs. This will enable support for the software
 	  controllable LDO/Switching regulators.
=20
-config REGULATOR_BD70528
-	tristate "ROHM BD70528 Power Regulator"
-	depends on MFD_ROHM_BD70528
-	help
-	  This driver supports voltage regulators on ROHM BD70528 PMIC.
-	  This will enable support for the software controllable buck
-	  and LDO regulators.
-
-	  This driver can also be built as a module. If so, the module
-	  will be called bd70528-regulator.
-
 config REGULATOR_BD71815
 	tristate "ROHM BD71815 Power Regulator"
 	depends on MFD_ROHM_BD71828
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 580b015296ea..6a5d55e209d3 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -29,7 +29,6 @@ obj-$(CONFIG_REGULATOR_AS3722) +=3D as3722-regulator.o
 obj-$(CONFIG_REGULATOR_ATC260X) +=3D atc260x-regulator.o
 obj-$(CONFIG_REGULATOR_AXP20X) +=3D axp20x-regulator.o
 obj-$(CONFIG_REGULATOR_BCM590XX) +=3D bcm590xx-regulator.o
-obj-$(CONFIG_REGULATOR_BD70528) +=3D bd70528-regulator.o
 obj-$(CONFIG_REGULATOR_BD71815)	+=3D bd71815-regulator.o
 obj-$(CONFIG_REGULATOR_BD71828) +=3D bd71828-regulator.o
 obj-$(CONFIG_REGULATOR_BD718XX) +=3D bd718x7-regulator.o
diff --git a/drivers/regulator/bd70528-regulator.c b/drivers/regulator/bd70=
528-regulator.c
deleted file mode 100644
index e6fec70fabfa..000000000000
--- a/drivers/regulator/bd70528-regulator.c
+++ /dev/null
@@ -1,278 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-// Copyright (C) 2018 ROHM Semiconductors
-// bd70528-regulator.c ROHM BD70528MWV regulator driver
-
-#include <linux/delay.h>
-#include <linux/err.h>
-#include <linux/interrupt.h>
-#include <linux/kernel.h>
-#include <linux/mfd/rohm-bd70528.h>
-#include <linux/module.h>
-#include <linux/of.h>
-#include <linux/platform_device.h>
-#include <linux/regmap.h>
-#include <linux/regulator/driver.h>
-#include <linux/regulator/machine.h>
-#include <linux/regulator/of_regulator.h>
-#include <linux/slab.h>
-
-static const struct linear_range bd70528_buck1_volts[] =3D {
-	REGULATOR_LINEAR_RANGE(1200000, 0x00, 0x1, 600000),
-	REGULATOR_LINEAR_RANGE(2750000, 0x2, 0xf, 50000),
-};
-static const struct linear_range bd70528_buck2_volts[] =3D {
-	REGULATOR_LINEAR_RANGE(1200000, 0x00, 0x1, 300000),
-	REGULATOR_LINEAR_RANGE(1550000, 0x2, 0xd, 50000),
-	REGULATOR_LINEAR_RANGE(3000000, 0xe, 0xf, 300000),
-};
-static const struct linear_range bd70528_buck3_volts[] =3D {
-	REGULATOR_LINEAR_RANGE(800000, 0x00, 0xd, 50000),
-	REGULATOR_LINEAR_RANGE(1800000, 0xe, 0xf, 0),
-};
-
-/* All LDOs have same voltage ranges */
-static const struct linear_range bd70528_ldo_volts[] =3D {
-	REGULATOR_LINEAR_RANGE(1650000, 0x0, 0x07, 50000),
-	REGULATOR_LINEAR_RANGE(2100000, 0x8, 0x0f, 100000),
-	REGULATOR_LINEAR_RANGE(2850000, 0x10, 0x19, 50000),
-	REGULATOR_LINEAR_RANGE(3300000, 0x19, 0x1f, 0),
-};
-
-/* Also both LEDs support same voltages */
-static const unsigned int led_volts[] =3D {
-	20000, 30000
-};
-
-static const unsigned int bd70528_buck_ramp_table[] =3D {
-	250, 125
-};
-
-static int bd70528_led_set_voltage_sel(struct regulator_dev *rdev,
-				       unsigned int sel)
-{
-	int ret;
-
-	ret =3D regulator_is_enabled_regmap(rdev);
-	if (ret < 0)
-		return ret;
-
-	if (ret =3D=3D 0)
-		return regulator_set_voltage_sel_regmap(rdev, sel);
-
-	dev_err(&rdev->dev,
-		"LED voltage change not allowed when led is enabled\n");
-
-	return -EBUSY;
-}
-
-static const struct regulator_ops bd70528_buck_ops =3D {
-	.enable =3D regulator_enable_regmap,
-	.disable =3D regulator_disable_regmap,
-	.is_enabled =3D regulator_is_enabled_regmap,
-	.list_voltage =3D regulator_list_voltage_linear_range,
-	.set_voltage_sel =3D regulator_set_voltage_sel_regmap,
-	.get_voltage_sel =3D regulator_get_voltage_sel_regmap,
-	.set_voltage_time_sel =3D regulator_set_voltage_time_sel,
-	.set_ramp_delay =3D regulator_set_ramp_delay_regmap,
-};
-
-static const struct regulator_ops bd70528_ldo_ops =3D {
-	.enable =3D regulator_enable_regmap,
-	.disable =3D regulator_disable_regmap,
-	.is_enabled =3D regulator_is_enabled_regmap,
-	.list_voltage =3D regulator_list_voltage_linear_range,
-	.set_voltage_sel =3D regulator_set_voltage_sel_regmap,
-	.get_voltage_sel =3D regulator_get_voltage_sel_regmap,
-	.set_voltage_time_sel =3D regulator_set_voltage_time_sel,
-};
-
-static const struct regulator_ops bd70528_led_ops =3D {
-	.enable =3D regulator_enable_regmap,
-	.disable =3D regulator_disable_regmap,
-	.is_enabled =3D regulator_is_enabled_regmap,
-	.list_voltage =3D regulator_list_voltage_table,
-	.set_voltage_sel =3D bd70528_led_set_voltage_sel,
-	.get_voltage_sel =3D regulator_get_voltage_sel_regmap,
-};
-
-static const struct regulator_desc bd70528_desc[] =3D {
-	{
-		.name =3D "buck1",
-		.of_match =3D of_match_ptr("BUCK1"),
-		.regulators_node =3D of_match_ptr("regulators"),
-		.id =3D BD70528_BUCK1,
-		.ops =3D &bd70528_buck_ops,
-		.type =3D REGULATOR_VOLTAGE,
-		.linear_ranges =3D bd70528_buck1_volts,
-		.n_linear_ranges =3D ARRAY_SIZE(bd70528_buck1_volts),
-		.n_voltages =3D BD70528_BUCK_VOLTS,
-		.enable_reg =3D BD70528_REG_BUCK1_EN,
-		.enable_mask =3D BD70528_MASK_RUN_EN,
-		.vsel_reg =3D BD70528_REG_BUCK1_VOLT,
-		.vsel_mask =3D BD70528_MASK_BUCK_VOLT,
-		.ramp_reg =3D BD70528_REG_BUCK1_VOLT,
-		.ramp_mask =3D BD70528_MASK_BUCK_RAMP,
-		.ramp_delay_table =3D bd70528_buck_ramp_table,
-		.n_ramp_values =3D ARRAY_SIZE(bd70528_buck_ramp_table),
-		.owner =3D THIS_MODULE,
-	},
-	{
-		.name =3D "buck2",
-		.of_match =3D of_match_ptr("BUCK2"),
-		.regulators_node =3D of_match_ptr("regulators"),
-		.id =3D BD70528_BUCK2,
-		.ops =3D &bd70528_buck_ops,
-		.type =3D REGULATOR_VOLTAGE,
-		.linear_ranges =3D bd70528_buck2_volts,
-		.n_linear_ranges =3D ARRAY_SIZE(bd70528_buck2_volts),
-		.n_voltages =3D BD70528_BUCK_VOLTS,
-		.enable_reg =3D BD70528_REG_BUCK2_EN,
-		.enable_mask =3D BD70528_MASK_RUN_EN,
-		.vsel_reg =3D BD70528_REG_BUCK2_VOLT,
-		.vsel_mask =3D BD70528_MASK_BUCK_VOLT,
-		.ramp_reg =3D BD70528_REG_BUCK2_VOLT,
-		.ramp_mask =3D BD70528_MASK_BUCK_RAMP,
-		.ramp_delay_table =3D bd70528_buck_ramp_table,
-		.n_ramp_values =3D ARRAY_SIZE(bd70528_buck_ramp_table),
-		.owner =3D THIS_MODULE,
-	},
-	{
-		.name =3D "buck3",
-		.of_match =3D of_match_ptr("BUCK3"),
-		.regulators_node =3D of_match_ptr("regulators"),
-		.id =3D BD70528_BUCK3,
-		.ops =3D &bd70528_buck_ops,
-		.type =3D REGULATOR_VOLTAGE,
-		.linear_ranges =3D bd70528_buck3_volts,
-		.n_linear_ranges =3D ARRAY_SIZE(bd70528_buck3_volts),
-		.n_voltages =3D BD70528_BUCK_VOLTS,
-		.enable_reg =3D BD70528_REG_BUCK3_EN,
-		.enable_mask =3D BD70528_MASK_RUN_EN,
-		.vsel_reg =3D BD70528_REG_BUCK3_VOLT,
-		.vsel_mask =3D BD70528_MASK_BUCK_VOLT,
-		.ramp_reg =3D BD70528_REG_BUCK3_VOLT,
-		.ramp_mask =3D BD70528_MASK_BUCK_RAMP,
-		.ramp_delay_table =3D bd70528_buck_ramp_table,
-		.n_ramp_values =3D ARRAY_SIZE(bd70528_buck_ramp_table),
-		.owner =3D THIS_MODULE,
-	},
-	{
-		.name =3D "ldo1",
-		.of_match =3D of_match_ptr("LDO1"),
-		.regulators_node =3D of_match_ptr("regulators"),
-		.id =3D BD70528_LDO1,
-		.ops =3D &bd70528_ldo_ops,
-		.type =3D REGULATOR_VOLTAGE,
-		.linear_ranges =3D bd70528_ldo_volts,
-		.n_linear_ranges =3D ARRAY_SIZE(bd70528_ldo_volts),
-		.n_voltages =3D BD70528_LDO_VOLTS,
-		.enable_reg =3D BD70528_REG_LDO1_EN,
-		.enable_mask =3D BD70528_MASK_RUN_EN,
-		.vsel_reg =3D BD70528_REG_LDO1_VOLT,
-		.vsel_mask =3D BD70528_MASK_LDO_VOLT,
-		.owner =3D THIS_MODULE,
-	},
-	{
-		.name =3D "ldo2",
-		.of_match =3D of_match_ptr("LDO2"),
-		.regulators_node =3D of_match_ptr("regulators"),
-		.id =3D BD70528_LDO2,
-		.ops =3D &bd70528_ldo_ops,
-		.type =3D REGULATOR_VOLTAGE,
-		.linear_ranges =3D bd70528_ldo_volts,
-		.n_linear_ranges =3D ARRAY_SIZE(bd70528_ldo_volts),
-		.n_voltages =3D BD70528_LDO_VOLTS,
-		.enable_reg =3D BD70528_REG_LDO2_EN,
-		.enable_mask =3D BD70528_MASK_RUN_EN,
-		.vsel_reg =3D BD70528_REG_LDO2_VOLT,
-		.vsel_mask =3D BD70528_MASK_LDO_VOLT,
-		.owner =3D THIS_MODULE,
-	},
-	{
-		.name =3D "ldo3",
-		.of_match =3D of_match_ptr("LDO3"),
-		.regulators_node =3D of_match_ptr("regulators"),
-		.id =3D BD70528_LDO3,
-		.ops =3D &bd70528_ldo_ops,
-		.type =3D REGULATOR_VOLTAGE,
-		.linear_ranges =3D bd70528_ldo_volts,
-		.n_linear_ranges =3D ARRAY_SIZE(bd70528_ldo_volts),
-		.n_voltages =3D BD70528_LDO_VOLTS,
-		.enable_reg =3D BD70528_REG_LDO3_EN,
-		.enable_mask =3D BD70528_MASK_RUN_EN,
-		.vsel_reg =3D BD70528_REG_LDO3_VOLT,
-		.vsel_mask =3D BD70528_MASK_LDO_VOLT,
-		.owner =3D THIS_MODULE,
-	},
-	{
-		.name =3D "ldo_led1",
-		.of_match =3D of_match_ptr("LDO_LED1"),
-		.regulators_node =3D of_match_ptr("regulators"),
-		.id =3D BD70528_LED1,
-		.ops =3D &bd70528_led_ops,
-		.type =3D REGULATOR_VOLTAGE,
-		.volt_table =3D &led_volts[0],
-		.n_voltages =3D ARRAY_SIZE(led_volts),
-		.enable_reg =3D BD70528_REG_LED_EN,
-		.enable_mask =3D BD70528_MASK_LED1_EN,
-		.vsel_reg =3D BD70528_REG_LED_VOLT,
-		.vsel_mask =3D BD70528_MASK_LED1_VOLT,
-		.owner =3D THIS_MODULE,
-	},
-	{
-		.name =3D "ldo_led2",
-		.of_match =3D of_match_ptr("LDO_LED2"),
-		.regulators_node =3D of_match_ptr("regulators"),
-		.id =3D BD70528_LED2,
-		.ops =3D &bd70528_led_ops,
-		.type =3D REGULATOR_VOLTAGE,
-		.volt_table =3D &led_volts[0],
-		.n_voltages =3D ARRAY_SIZE(led_volts),
-		.enable_reg =3D BD70528_REG_LED_EN,
-		.enable_mask =3D BD70528_MASK_LED2_EN,
-		.vsel_reg =3D BD70528_REG_LED_VOLT,
-		.vsel_mask =3D BD70528_MASK_LED2_VOLT,
-		.owner =3D THIS_MODULE,
-	},
-
-};
-
-static int bd70528_probe(struct platform_device *pdev)
-{
-	int i;
-	struct regulator_config config =3D {
-		.dev =3D pdev->dev.parent,
-	};
-
-	config.regmap =3D dev_get_regmap(pdev->dev.parent, NULL);
-	if (!config.regmap)
-		return -ENODEV;
-
-	for (i =3D 0; i < ARRAY_SIZE(bd70528_desc); i++) {
-		struct regulator_dev *rdev;
-
-		rdev =3D devm_regulator_register(&pdev->dev, &bd70528_desc[i],
-					       &config);
-		if (IS_ERR(rdev)) {
-			dev_err(&pdev->dev,
-				"failed to register %s regulator\n",
-				bd70528_desc[i].name);
-			return PTR_ERR(rdev);
-		}
-	}
-	return 0;
-}
-
-static struct platform_driver bd70528_regulator =3D {
-	.driver =3D {
-		.name =3D "bd70528-pmic"
-	},
-	.probe =3D bd70528_probe,
-};
-
-module_platform_driver(bd70528_regulator);
-
-MODULE_AUTHOR("Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>");
-MODULE_DESCRIPTION("BD70528 voltage regulator driver");
-MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:bd70528-pmic");
--=20
2.25.4


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--pf9I7BMVVzbSWLtt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmCviZYACgkQeFA3/03a
ocVjNAf9GHNC05St7zcofrQMKA/GllJ3/Lj1rhl+A16DKIR3k7/uGilQ5h3PVTvU
+Ey9hAhYvEZg3bBgeGXDkH2j1yDLeJ8M9npSf2gbNAxVwnZGBM+NuGMooKlGOt+O
wzTvadBQgzAuCxn20F6Fjwy5maNRXuan/pPnITOV+dDad0bAHMYwAdPt5Si4KElG
xZqmmr5dcDkWrPb2mtya0PGwoXq5185yFV2KMUoXDq5vWJQhfmPE0p8osubPWORY
5pocXtBp4Cb5quiQU6qDftXcXC4FbFJm7G5wjF5kRvOxGsq3U8Jz+TaQW5ToeVaJ
3TenQIrQorfgWdNRp7+JYlHLPsHvJw==
=8q8N
-----END PGP SIGNATURE-----

--pf9I7BMVVzbSWLtt--